Download
(35 Kb)
Download
Updated: 05/09/24 03:27 PM
Pictures
File Info
Compatibility:
Gold Road (10.0.0)
Scions of Ithelia (9.3.0)
Updated:05/09/24 03:27 PM
Created:03/08/21 06:02 AM
Monthly downloads:4,580
Total downloads:147,479
Favorites:194
MD5:
Categories:Character Advancement, TradeSkill Mods, Miscellaneous, Utility Mods
9.3.0
Jack of all Trades - Automatic CP Respec  Popular! (More than 5000 hits)
Version: 1.2.30
by: CyberOnEso, Kyzeragon

Automatically adjust your green champion bar depending on what you want to achieve

New with V.1.2 Adjust which slot each star gets slotted into.

Crafting
  • Automatically slots Master Gatherer and Plentiful Harvest when you start harvesting a crafting node.
  • Automatically slots Meticulous Disassembly when you start crafting, ensuring you always get optimal refining results!
  • Also works with the new deconstruction assistant.
Looting
  • Automatically slots Treasure Hunter, and Homemaker whenever you are looting the relevant container.
Fishing
  • Slots Reel Technique and Angler's Instincts whenever you start fishing.
Thieving
  • Slots Infamous whenever you interact with a fence, helping you always get the best selling price.
  • Slots Cutpurse's Art whenever you pickpocket someone.
Riding
  • Slots Gifted Rider and War Mount whenever you mount up!
Miscellaneous
  • Slots Professional Upkeep when you talk with a merchant, ensuring you always get your gear repaired for less!
  • Slots rationer whenever you switch quick slot slots!

Optional Features
  • Get a notification whenever any skill you wish to be notified of is slotted
  • Receive a warning message whenever you don't have enough points into a star for it to be automatically slotted
  • Disable automatically slotting any skill you wish
  • Change which slot any stars are slotted into.
  • Slot rationer whenever you port into nBRP.
  • A bunch more intricacies to customize it to your every desire.


Jack of all Trades addon will not respec your champion points, and will not charge you 3000 gold etc.
It will only equip the skills if you have enough points into them already.
It is intended to be a seamless quality of life improvement.

Full German, French, Russian and Spanish translations are available.
V 1.2.30
  • Jack of All Trades will no longer attempt to slot CP in non-CP campaigns or battlegrounds (this is a hack that should work until there are new campaigns like Cyrodiil events)
  • Fixed leaking global variables. Thanks Dack!
  • Added LibChatMessage as an optional dependency
  • Bumped API to Scions of Ithelia and Gold Road
V 1.2.29
  • Fixed slotting for thieves troves. Thanks lancerchan!
V.1.2.28
  • Fixed error / interact CP not slotting for Necrom
  • I (@Kyzeragon) will be maintaining the addon to fix issues, so I most likely won't be adding new features unless ZOS adds new green CP
V.1.2.27
  • Added Japanese translation. Massive thanks to Snorunt361!!
V.1.2.26
  • Fixed bug where Rationer and Liquid Efficiency were not slotting in High Isle. Thanks Kyzeragon!
  • Fixed bug where harvesting water plants was not slotting Master Gatherer and Plentiful Harvest when playing in German. Thanks Schrappe!
V.1.2.25
  • Fixed bug where Treasure Hunter was being slotted when interacting with crafting stations. Thanks Kyzeragon & Caaraamon
V.1.2.24
  • Added support for the deconstruction assistant. Thanks Kyzeragon
  • Improved robustness of the interact key text checking. Thanks to IsJustaGhost
V.1.2.23
  • Added toggle to automatically allocate points into stars, which is disabled by default. Thanks m-ree.
V.1.2.22
  • If you have the points to spare Jack of all Trades will slot the CP Star and all pre-requisite stars that are required to slot the star, whilst spending the minimum amount of points to do so. Real-world application of Dijkstra's algorithm!
  • Improved cooldown code to ensure that the cooldown is not set whilst assigning a start to a slot for the first time.
  • These features may cause issues as they can be kind of complex, if they cause any issues for you please let me know ASAP and I will try to fix it as soon as I can.
V.1.2.21
  • Fixed an issue where warning text would be shown in no- cp environments. Thanks Yoav!
V.1.2.20
  • API bumb to Deadlands
V.1.2.19
  • Major additions to the Spanish Translations! Thank you very much loneloba/ Inval1d for these, they are greatly appreciated.
  • Improved localization by adding more strings to language files.
V.1.2.18
  • Added a setting, which is enabled by default, to automatically slot Rationer when entering nBRP, to make sure you make the most out of your ult pots.
V.1.2.17
  • Fixed a bug where the treasure hunter CP would not get slotted when porting into a dungeon.
V.1.2.16
  • Fixed a bug where warning messages shown as an alert would cause an error. Thanks Yoav!
V.1.2.15
  • Added sustaining shadows to the menu to allow you to select where the skill should be slotted.
V.1.2.14
  • Added optional automatic slotting of Sustaining Shadows. Thank you A_Darklore for the suggestion!
  • Fixed an issue with the German client where the addon sometimes would not realise you had been collecting resources. Thank you Irniben!
  • API bump to Waking Flame
V.1.2.13
  • Fixed an issue where the folder was called JackOfAllTrades-main, this may cause unexpected side effects if it does please redownload it. Thank you Anceane!
V.1.2.12
  • Added a new sub- menu category for harvesting nodes. Thank you Sonwon!
V.1.2.11
  • Improved notifications by allowing users to select whether to show the notification/ warning as a top-right alert instead of in the chat. Thank you Saenic!
  • Added ability to remove the icon from notification if the user wishes.
V.1.2.10
  • API bumb to Blackwood
V.1.2.9
  • Fixed an issue where the Jack of all Trades CP cooldown would not be reset upon changing zones. Which it is. Thank you Kyzeragon!!
V.1.2.8
  • Added option to always post a notification when the CP cooldown ends. Thank you LoneStar2911!
V.1.2.7
  • Added additional French translations provided by Jakez31. Thank you very much!!
V.1.2.6
  • Added additional French translations provided by Jakez31. Thank you very much!!
  • Fixed a bug where "CP Cooldown complete" could show up multiple times. Thank you LoneStar2911!
  • Added localization support for more strings
V.1.2.5
  • Added the option to post a notification to chat when the cooldown is complete if you have disabled 'Automatically slotting stars after the cooldown ends' Thank you LoneStar2911!
  • Updated the menu text
V.1.2.4
  • Added menu option to enable automatically slotting treasure hunter (and homemaker if you have them as a pair) whenever you enter a dungeon. Thank you Cruxa
V.1.2.3
  • Fixed an issue where Gifted Rider and War Mount weren't working as intended. Thank you Provinzheld, FrostByghte and Baertram
V.1.2.2
  • Fixed how checking if you have the required amount of points is calculated. Thanks Baertram!
V.1.2.1
  • Fixed an issue that caused the cooldown to break, thus not allowing any stars to be slotted after an initial change, thanks Kyzeragon!
  • If you are experiencing any issues make sure you are not on V.1.2.0.
V.1.2.0
  • Added a menu option to change which skills will be slotted where.
  • Added riding stars (Gifted Rider and War Mount). These are disabled by default as I don't want to put people on cooldown too often. I still recommend you slot the movement speed passives in slot 1 and 2. But it's your call if you want to use them.
  • Fixed an issue that was causing the cooldown to not start if the CP was triggered by other addons. Thank you Kyzeragon!
V.1.1.19
  • Added a system that will ensure that pairs of passives are slotted correctly even if one is slotted in the intended slot of another.
V.1.1.18
  • Changed the priority of gathering passives to prioritize Plentiful Harvest.
  • I am going to work on a more robust system that will dynamically change the slotting of stars if you have them in the unintended order.
V.1.1.17
  • Will no longer slot Professional Upkeep if your repair cost is 0.
  • Fixed an issue causing notifications to not fully work as intended.
V.1.1.16
  • Gathering stars will no longer be slotted while in Stone Garden, as the gathering passives do not affect 'Gloomspore Agaric'. Thank you Scrofula!
V.1.1.15
  • Added the option to not Liquid Efficiency if the potion that is selected is a trash pot. Thank you Kyzeragon!
V.1.1.14
  • Will no longer slot treasure hunter when unlocking a door to a house, thanks NettleCarrier.
  • Fixed a bug where sometimes treasure hunter and homemaker slotting as a pair wasn't acting as intended. Thank you @DeadSoon!
  • Added more containers where homemaker should be slotted.
V.1.1.13
  • Added the option to disable slotting Meticulous Dissasembly whilst doing writs. Thank you gabbo1928.
V.1.1.12
  • Added the ability to disable automatically slotting queued skills after the cooldown ends. Thank you Cruxa for the suggestion
  • Changed Plentiful Harvest to slot 4 as it is the more important of the two. (Master Gatherer will now be slotted in slot 3)
V.1.1.11
  • Improved the fix substantially, should now only put the user on cooldown when they modify the hotbar.
V.1.1.10
  • Provided a temporary fix for overly aggressive cooldown blocking, if you disable the 'Show alert when attempting to slot CP on cooldown' box in the menu you will be able to use the less aggressive cooldown blocking. Thank you Kyzeragon
V.1.1.9
  • Added Russian translations, thank you Lyniss!
  • Added the option for Treasure Hunter and Homemaker to be slotted as a pair. Thank you Scrofula!
  • Fixed an issue where Liquid Efficiency wasn't being slotted as intended, also added the options for Liquid Efficiency to the menu
V.1.1.8
  • Added liquid efficency. Thank you Lumber!
  • Fixed an issue where CP stars would occasionally be reslotted if you already had them slotted.
  • When you are on CP cooldown a more helpful cooldown text will be shown in the top right, rather than in chat.
V.1.1.7
  • Rationer will not only be slotted when switching to a food/ drink item. Thank you FormlessOne
  • Added more lootables for homemaker to slot with, added the German translations for all homemaker lootables. Thank you @DeadSoon!
  • Gathering stars will not be slotted when looting Psijic Portals anymore. Thank you M-ree!
V.1.1.6
  • Fixed an issue where gathering stars would be slotted when looting corpses on occasion.
V.1.1.5
  • Professional upkeep will no longer be slotted when talking to Nuzhimeh
  • Attempted to fix the bug where notification messages would not be correct. Please let me know if the notification messages are still sometimes incorrect.
V.1.1.4
  • Fixed a bug that caused CP stars to not be correctly slotted
V.1.1.3
  • Added an option to disable homemaker when looting corpses (On by default)
  • Fixed the bug where Rationer would be slotted regardless of if you disabled it.
  • Fixed the bug where the notification would sometimes not post when a skill is slotted
V.1.1.2
  • Added togglable to show/ hide the default ZOS Alert Text when you attempt to slot CP whilst on cooldown
  • Will send a notification when the skill is actually slotted if a skill gets queued to be slotted in X seconds.
  • Fixed spelling issue on the CP cooldown text
V.1.1
  • Rewrote the addon from scratch to allow it to obey the 30-second cooldown on changing CP's
  • The addon will now only slot skills in the 3rd and 4th slot on your champion bar. This allows you to keep slots 1 and 2 the same, I suggest you slot 'Steed's Blessing' and 'Gifted Rider' in slots 1 and 2.
Optional Files (0)


Archived Files (50)
File Name
Version
Size
Uploader
Date
1.2.29
34kB
Kyzeragon
07/12/23 01:15 AM
1.2.28
34kB
Kyzeragon
06/11/23 02:18 PM
1.2.27
34kB
CyberOnEso
01/22/23 02:31 PM
1.2.26
30kB
CyberOnEso
06/21/22 04:31 AM
1.2.25
30kB
CyberOnEso
03/30/22 12:26 PM
1.2.24
30kB
CyberOnEso
03/30/22 10:34 AM
1.2.23
30kB
CyberOnEso
12/25/21 02:52 PM
1.2.22
29kB
CyberOnEso
12/24/21 02:21 PM
1.2.21
28kB
CyberOnEso
11/06/21 01:33 PM
1.2.20
28kB
CyberOnEso
10/31/21 03:58 PM
1.2.19
29kB
CyberOnEso
10/23/21 01:55 PM
1.2.18
27kB
CyberOnEso
10/16/21 06:20 PM
1.2.17
27kB
CyberOnEso
09/17/21 07:48 PM
1.2.16
27kB
CyberOnEso
09/09/21 04:37 AM
1.2.15
27kB
CyberOnEso
08/25/21 05:42 AM
1.2.14
27kB
CyberOnEso
08/24/21 04:43 AM
1.2.13
27kB
CyberOnEso
06/19/21 08:52 AM
1.2.12
27kB
CyberOnEso
06/19/21 06:15 AM
1.2.11
26kB
CyberOnEso
06/14/21 05:18 PM
1.2.10
25kB
CyberOnEso
06/01/21 06:46 PM
1.2.9
25kB
CyberOnEso
05/07/21 05:01 AM
1.2.8
25kB
CyberOnEso
04/23/21 06:18 PM
1.2.7
25kB
CyberOnEso
04/18/21 03:22 PM
1.2.6
24kB
CyberOnEso
04/18/21 05:16 AM
1.2.5
23kB
CyberOnEso
04/17/21 10:47 AM
1.2.4
23kB
CyberOnEso
04/10/21 06:22 AM
1.2.3
23kB
CyberOnEso
04/02/21 07:13 AM
1.2.2
23kB
CyberOnEso
03/25/21 06:07 PM
1.2.1
23kB
CyberOnEso
03/23/21 02:13 AM
1.2.0
23kB
CyberOnEso
03/22/21 05:50 PM
1.1.19
21kB
CyberOnEso
03/20/21 06:59 AM
1.1.17
21kB
CyberOnEso
03/19/21 06:11 PM
1.1.16
21kB
CyberOnEso
03/19/21 06:18 AM
1.1.15
21kB
CyberOnEso
03/18/21 07:24 PM
1.1.14
21kB
CyberOnEso
03/18/21 10:27 AM
1.1.13
21kB
CyberOnEso
03/17/21 12:04 PM
1.1.12
21kB
CyberOnEso
03/17/21 10:37 AM
1.1.11
20kB
CyberOnEso
03/17/21 05:48 AM
1.1.10
20kB
CyberOnEso
03/17/21 05:23 AM
1.1.9
20kB
CyberOnEso
03/16/21 10:40 AM
1.1.8
20kB
CyberOnEso
03/15/21 05:54 PM
1.1.7
20kB
CyberOnEso
03/14/21 07:55 AM
1.1.6
19kB
CyberOnEso
03/13/21 03:36 PM
1.1.5
19kB
CyberOnEso
03/12/21 04:49 PM
1.1.4
19kB
CyberOnEso
03/12/21 11:36 AM
1.1.3
19kB
CyberOnEso
03/12/21 10:54 AM
1.1.2
18kB
CyberOnEso
03/11/21 05:13 AM
1.1.1
178kB
CyberOnEso
03/10/21 08:50 AM
1.0.1
362kB
CyberOnEso
03/08/21 09:51 AM
1
362kB
CyberOnEso
03/08/21 06:02 AM


Post A Reply Comment Options
Unread 03/20/21, 12:07 AM  
satoi

Forum posts: 0
File comments: 7
Uploads: 0
Gatherer and Harvest

Great addon! I really appreciate your work!

I've noticed the "improper" order of slotting Gatherer and Harvest too.

Situation: slotted Homemaker - Treasure Hunter - Harvest - Disassembly (from left to right), cooldown finished.

Then I "harvest" a butterfly -> the addon exchanged Harvest for Gatherer. So the slots are: Homemaker - Treasure Hunter - Gatherer - Disassembly.

Now I harvest a plant or other ressource node within the 30 seconds cooldown -> the addon can't change Dissassebly because of the cooldown.

After the cooldown, Harvest slotted automatically, thats fine! And the faster gathering of butterflys and other insects is nice too

But I think, it would be better, wenn Dissassebly will changed first, especially when Harvest is slotted already.

Edit: Version is 1.1.17
Last edited by satoi : 03/20/21 at 12:08 AM.
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 09:07 PM  
NettleCarrier

Forum posts: 0
File comments: 5
Uploads: 0
Gathering Passives

I want to second Jpor's comment, I noticed that "after awhile" the green CPs do get jumbled when treasure hunter is slotted in, giving plentiful harvest lower priority to plentiful harvest. After some time my window will say "Plentiful Harvest slotted" twice in a row and I think the fact that it says it twice is indicating something. I think Jpor did a much better job explaining the technical steps so hopefully that helps .
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 08:52 PM  
jpor

Forum posts: 3
File comments: 47
Uploads: 0
I've noticed an issue with how Treasure Hunter is slotted and how the other green slots get juggled when opening treasure chests.

I have the following green slots:
Steeds - Gifted - Plentiful - Master Gatherer

When opening a treasure chest, I want Master Gatherer to be removed and Treasure Hunter to be added.

Up to v.1.1.11, this works fine. Doing use on a treasure chest swaps Treasure Hunter into slot4 and 30secs later Master Gatherer is put back.

But from 1.1.12 onward, Treasure Hunter goes into slot4 but 2x swaps follow with the final state being Master Gatherer in slot3 and Plentiful in slot4.

The problem is with the next treasure chest use, Treasure Hunter goes into slot4 with Master Gatherer staying in slot3.

I always want Plentiful active so I've rolled back to v.1.1.11.

I loaded 1.1.17 and deleted my saved variables and tested again but no joy.

Lastly, with 1.1.17 loaded and starting with slot3=Master slot4=Plentiful, I tested and ended up with Steeds - Gifted - Master - Plentiful after a chest which is not what I want.

PS - THANK YOU FOR THIS ADD ON! It is so helpful in dealing with CP2.0
Last edited by jpor : 03/19/21 at 11:12 PM.
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 04:08 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Great Addon!

Originally Posted by SithMystery
Really good job on this addon! It certainly makes the crafting bar a whole lot more useful and easier to manage.

The only thing I can think of that might be an improvement is some kind of cooldown timer to show when a skill can be swapped out.

Thanks, and keep up the great work!
Thank you very much for your kind words. If you turn on Notifications it will post how long you are on cooldown for and if you attempt to change your CP whilst on cooldown it will post an alert saying how long you are on cooldown for.

Is this what you were looking for, or are you suggesting something more?
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 04:06 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Re: Master Gatherer not slotting

Originally Posted by Orejana
This is an issue again - Master Gatherer is not slotting automatically. Would appreciate it if you could have another look

Originally Posted by Orejana
I started doing surveys (clothing, in Western Skyrim, not sure if relevant) and my Master Gatherer didn't slot automatically.
I had not changed slots in at least 10min, so the cooldown cannot have been the issue. Master Gatherer is also completey levelled with 75 CP in it.
My current slotted CP are (from slot 1-4): Treasure Hunter, Homemaker, Plentiful Harvest, Professional Upkeep

I was thinking that maybe the addon had some trouble because Plentiful Harvest was already slotted before I started harvesting the first node?
Hey'a, I just checked this it is working for me.
If you want I am happy to look at your exact situation, if you wish you can add me on discord: Cyber#0042 and I can try and diagnose why this is happening for you.
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 02:27 PM  
Orejana
AddOn Author - Click to view AddOns

Forum posts: 2
File comments: 50
Uploads: 2
Re: Master Gatherer not slotting

This is an issue again - Master Gatherer is not slotting automatically. Would appreciate it if you could have another look

Originally Posted by Orejana
I started doing surveys (clothing, in Western Skyrim, not sure if relevant) and my Master Gatherer didn't slot automatically.
I had not changed slots in at least 10min, so the cooldown cannot have been the issue. Master Gatherer is also completey levelled with 75 CP in it.
My current slotted CP are (from slot 1-4): Treasure Hunter, Homemaker, Plentiful Harvest, Professional Upkeep

I was thinking that maybe the addon had some trouble because Plentiful Harvest was already slotted before I started harvesting the first node?
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 12:36 PM  
SithMystery

Forum posts: 0
File comments: 2
Uploads: 0
Great Addon!

Really good job on this addon! It certainly makes the crafting bar a whole lot more useful and easier to manage.

The only thing I can think of that might be an improvement is some kind of cooldown timer to show when a skill can be swapped out.

Thanks, and keep up the great work!
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 10:17 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Originally Posted by M-ree
Originally Posted by CyberOnEso
Originally Posted by M-ree
[16:10] [16:10] Master Gatherer slotted.
[16:10] [16:10] Plentiful Harvest will be slotted in 24 seconds.
[16:10] [16:10] Plentiful Harvest slotted.

... I dunno what are anyone else's preferences, but I would most certainly slot Harvest over Gatherer. Especially on characters where I have point allocation into Gatherer just enough to unlock the link further.
Hey'a, could you let me know the exact scenario you are experiencing this with and the version you are using.

They should always be slotted together.

Many thanks!

I just tested it on V.1.1.16 and it works as expected, though I don't see a reason as to why it wouldn't work as intended on older versions.
If you can tell me a way to consistently experience this behavior then I more than happy to look into it.
It is anything but consistent to be honest. Version at the time was 1.1.15.
Okay, well thank you for your feedback. I will keep aware of it and if I find a way to repeat the issue I will look into exactly why that is happening for you.

I believe those skills should be slotted at the same time. And it does work on my end.

Thank you very much for your feedback.
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 10:11 AM  
M-ree

Forum posts: 2
File comments: 522
Uploads: 0
Originally Posted by CyberOnEso
Originally Posted by M-ree
[16:10] [16:10] Master Gatherer slotted.
[16:10] [16:10] Plentiful Harvest will be slotted in 24 seconds.
[16:10] [16:10] Plentiful Harvest slotted.

... I dunno what are anyone else's preferences, but I would most certainly slot Harvest over Gatherer. Especially on characters where I have point allocation into Gatherer just enough to unlock the link further.
Hey'a, could you let me know the exact scenario you are experiencing this with and the version you are using.

They should always be slotted together.

Many thanks!

I just tested it on V.1.1.16 and it works as expected, though I don't see a reason as to why it wouldn't work as intended on older versions.
If you can tell me a way to consistently experience this behavior then I more than happy to look into it.
It is anything but consistent to be honest. Version at the time was 1.1.15.
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 07:39 AM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Originally Posted by M-ree
[16:10] [16:10] Master Gatherer slotted.
[16:10] [16:10] Plentiful Harvest will be slotted in 24 seconds.
[16:10] [16:10] Plentiful Harvest slotted.

... I dunno what are anyone else's preferences, but I would most certainly slot Harvest over Gatherer. Especially on characters where I have point allocation into Gatherer just enough to unlock the link further.
Hey'a, could you let me know the exact scenario you are experiencing this with and the version you are using.

They should always be slotted together.

Many thanks!

I just tested it on V.1.1.16 and it works as expected, though I don't see a reason as to why it wouldn't work as intended on older versions.
If you can tell me a way to consistently experience this behavior then I more than happy to look into it.
Last edited by CyberOnEso : 03/19/21 at 07:46 AM.
Report comment to moderator  
Reply With Quote
Unread 03/19/21, 07:15 AM  
M-ree

Forum posts: 2
File comments: 522
Uploads: 0
[16:10] [16:10] Master Gatherer slotted.
[16:10] [16:10] Plentiful Harvest will be slotted in 24 seconds.
[16:10] [16:10] Plentiful Harvest slotted.

... I dunno what are anyone else's preferences, but I would most certainly slot Harvest over Gatherer. Especially on characters where I have point allocation into Gatherer just enough to unlock the link further.
Report comment to moderator  
Reply With Quote
Unread 03/18/21, 07:26 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Ignore trash pots?

Originally Posted by Kyzeragon
Hello, just a suggestion: can you add an option to NOT slot Liquid Efficiency if the potion that is selected is a trash pot?
This has been added with V.1.1.15.

Thank you very much for the suggestion!
Last edited by CyberOnEso : 03/18/21 at 07:26 PM.
Report comment to moderator  
Reply With Quote
Unread 03/18/21, 06:55 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: why does something slot when it is

Originally Posted by iarao
already slotted? i then get a cd.

tyty
Thank you for your comment.

Could you explain the scenario that this is happening with?

The addon does do a check that the skill is not already slotted before attempting to slot anything.

Lua Code:
  1. local function isCPSlotted(skillId)
  2.     for index=1, 4 do
  3.         if GetSlotBoundId(index, HOTBAR_CATEGORY_CHAMPION) == skillId then
  4.             if JackOfAllTrades.savedVariables.debug then d("Skill is already slotted so won't reallocate it") end
  5.             return true
  6.         end
  7.     end
  8.     return false
  9. end
  10.  
  11.  
  12. -- Adds the CP node to the queue of stars to be slotted, when the player is off cooldown these stars can be slotted
  13. function JackOfAllTrades.AddCPNodeToQueue(skillId, skillIndex)
  14.  
  15.     -- Check if the skill is already slotted
  16.     if isCPSlotted(skillId) then return false end

The addon only attempts to slot the skill if the 'AddCPNodeToQueue' function returns true.

I am more than happy to look into this issue further if you can provide me with a way to replicate the issue you are having. However, for the meantime please ensure you are using the latest version of the addon.

Many thanks for your feedback
Last edited by CyberOnEso : 03/18/21 at 07:04 PM.
Report comment to moderator  
Reply With Quote
Unread 03/18/21, 04:26 PM  
iarao

Forum posts: 10
File comments: 37
Uploads: 0
why does something slot when it is

already slotted? i then get a cd.

tyty
Report comment to moderator  
Reply With Quote
Unread 03/18/21, 12:23 PM  
CyberOnEso
 
CyberOnEso's Avatar
AddOn Author - Click to view AddOns

Forum posts: 18
File comments: 119
Uploads: 4
Re: Ignore trash pots?

Originally Posted by Kyzeragon
Hello, just a suggestion: can you add an option to NOT slot Liquid Efficiency if the potion that is selected is a trash pot? I don't really care about saving potions that are worth next to nothing, at the cost of having to deal with an extra cooldown. Should be able to just compare the item link. I think it would be fine to only check against the CP150 ones since levelling is so fast now. That would make them these three:
|H1:item:27038:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
|H1:item:27037:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
|H1:item:27036:307:50:0:0:0:0:0:0:0:0:0:0:0:0:36:0:0:0:0:0|h|h
Yes that would be possible, I will add that to the next version.
Thank you very much for the suggestion.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: