Download
(39 Kb)
Download
Updated: 10/31/23 07:27 AM
Patch for:
No, thank you!.
Compatibility:
Endless Archive (9.2.5)
base-game patch (9.1.5)
Updated:10/31/23 07:27 AM
Created:06/28/23 11:01 AM
Monthly downloads:809
Total downloads:14,487
Favorites:49
MD5:
No, thank you! - Endless Archive  Popular! (More than 5000 hits)
Version: 11.3a
by: ZaiZah [More]
This is an updated version of No, thank you! and more specifically updated version from uta.karas update

I'm still quite new to this, but i'll do my best to keep it maintained

You'll also need these libraries, so you need install them individually if not yet.
Please make sure your libraries are up-to-date

Feel free to also update/maintain this wonderful addon if you would like to
11.3a - ZaiZah
- Added check for ingame leaderboard settings. (No, Thank You should no longer send rogue leaderboard messages if you have it turned off from the ingame settings)
- Added option to show/hide Endless Archive leaderboard notifications
- Added option to disable/enable notification sound (This applies to all notifications and disabled by default)
- Added some space to the bottom of the settings menu to fix the clipping dropdown menu for LUA Errors section

11.3 - ZaiZah
- Api bump to Endless Archive (u40)
- Fixed the Leaderboard Score functionality no more errors \o/ (Thank you Complicative for your help)
- Your saved vars will reset, this should avoid any potential issues with settings

11.2 - ZaiZah
- Added the option to hide guild application notifications (Useful if you're in a large guild that gets frequent applications) - thank you @schrodingerscatgirls

11.1 - ZaiZah
- Fixed the "Jump to Leader" functionality, it should now hide or show the jump dialog depending on your selection

11 - ZaiZah
- Compatible with update 38 (Necrom)
- Fixed an issue that caused books to flash open/closed when read
- Added all city wayshrines to date for the "Hide Wayshrine" Option
- Disabled the "Hide Crown Store" option as its currently not working as intended

No, Thank You - Blackwood Change Log - uta.karas
No thank you - Blackwood#ChangeLog

Original No, Thank you Change Log
No thank you#ChangeLog
Archived Files (4)
File Name
Version
Size
Uploader
Date
11.3
39kB
ZaiZah
10/30/23 05:08 PM
11.2
39kB
ZaiZah
08/04/23 05:41 AM
11.1
39kB
ZaiZah
07/18/23 07:50 AM
11
39kB
ZaiZah
06/28/23 11:01 AM


Post A Reply Comment Options
Unread 11/06/23, 06:03 PM  
randomsilliness

Forum posts: 2
File comments: 41
Uploads: 0
Settings blank.

I removed the old version of No, Thank You, and installed this one. It worked for a day and now the settings are all blank. I've shut down, deleted saved vars, and still the settings are all blank. Other addons not having that issue. Are there incompatible addons that need to be excluded?
Report comment to moderator  
Reply With Quote
Unread 11/05/23, 03:15 PM  
Smugger21
 
Smugger21's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 23
Uploads: 1
Re: Clarification

Originally Posted by ZoLatKam
Apologies; "commenting out the end of that" is a bit vague for some of us

Could you please clarify exactly which lines/section of the rChat code you commented out?

LOL, no problem, sure

In 'rChat.lua' lines 2434-2436
The lines after
Code:
-- Only if statusMessage is set
So it looks like this:
Code:
    -- Only if statusMessage is set
    -- if statusMessage then
    --    return FormatSysMessage(statusMessage)
    -- end
This will stop rChat from posting friend status updates (Log In/Log Off messages).
I had posted on the rChat forum asking him to add this as a feature. It is a pretty simple one to add.
But until then this fix will work.
Last edited by Smugger21 : 11/05/23 at 05:28 PM.
Report comment to moderator  
Reply With Quote
Unread 11/05/23, 02:28 AM  
ZoLatKam
 
ZoLatKam's Avatar

Forum posts: 3
File comments: 146
Uploads: 0
Clarification

Originally Posted by Smugger21

Yup, it would seem there is nothing you can do in your addon about this, as he takes over this altogether:

From rChat:
Code:
-- triggers when EVENT_FRIEND_PLAYER_STATUS_CHANGED
local function OnFriendPlayerStatusChanged(displayName, characterName, oldStatus, newStatus)

    local statusMessage

    -- DisplayName is linkable
    local displayNameLink = ZO_LinkHandler_CreateDisplayNameLink(displayName)
    -- CharacterName is linkable
    local characterNameLink = ZO_LinkHandler_CreateCharacterLink(characterName)

    local wasOnline = oldStatus ~= PLAYER_STATUS_OFFLINE
    local isOnline = newStatus ~= PLAYER_STATUS_OFFLINE

    -- Not connected before and Connected now (no messages for Away/Busy)
    if not wasOnline and isOnline then
        -- Return
        -- friend has logged on with toon
        statusMessage = zo_strformat(SI_FRIENDS_LIST_FRIEND_CHARACTER_LOGGED_ON, displayNameLink, characterNameLink)
    -- Connected before and Offline now
    elseif wasOnline and not isOnline then
        -- friend has logged off with toon
        statusMessage = zo_strformat(SI_FRIENDS_LIST_FRIEND_CHARACTER_LOGGED_OFF, displayNameLink, characterNameLink)
    end

    -- Only if statusMessage is set
    if statusMessage then
        return FormatSysMessage(statusMessage)
    end

end
Looks like I will have to ask him to add this feature to his mod. Until then, I was just able to change it myself by commenting out the end of that.

Thanks for your time!
Apologies; "commenting out the end of that" is a bit vague for some of us

Could you please clarify exactly which lines/section of the rChat code you commented out?
Report comment to moderator  
Reply With Quote
Unread 11/03/23, 08:30 PM  
Smugger21
 
Smugger21's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 23
Uploads: 1
Originally Posted by Smugger21
Originally Posted by ZaiZah

This could be caused by another addon that hooks into the message handlers as you don't know which addon eso will load up first

I noticed that if you use pChat and have "Player status changed" Chat format handler on it could cause it to happen, also some ui mods that add their own chat message could also cause it. Try turning that setting off and see if it fixes it?

it's certainly something i'll see if i can make a change too though as it defeats the point of the setting otherwise :'D
So it seems that rChat is the one causing this issue. I did some testing, I tried adding rChat as a Dependency to this Addon and that did not fix the issue. Bummer. So I am not sure what else could be done then.
Yup, it would seem there is nothing you can do in your addon about this, as he takes over this altogether:

From rChat:
Code:
-- triggers when EVENT_FRIEND_PLAYER_STATUS_CHANGED
local function OnFriendPlayerStatusChanged(displayName, characterName, oldStatus, newStatus)

    local statusMessage

    -- DisplayName is linkable
    local displayNameLink = ZO_LinkHandler_CreateDisplayNameLink(displayName)
    -- CharacterName is linkable
    local characterNameLink = ZO_LinkHandler_CreateCharacterLink(characterName)

    local wasOnline = oldStatus ~= PLAYER_STATUS_OFFLINE
    local isOnline = newStatus ~= PLAYER_STATUS_OFFLINE

    -- Not connected before and Connected now (no messages for Away/Busy)
    if not wasOnline and isOnline then
        -- Return
        -- friend has logged on with toon
        statusMessage = zo_strformat(SI_FRIENDS_LIST_FRIEND_CHARACTER_LOGGED_ON, displayNameLink, characterNameLink)
    -- Connected before and Offline now
    elseif wasOnline and not isOnline then
        -- friend has logged off with toon
        statusMessage = zo_strformat(SI_FRIENDS_LIST_FRIEND_CHARACTER_LOGGED_OFF, displayNameLink, characterNameLink)
    end

    -- Only if statusMessage is set
    if statusMessage then
        return FormatSysMessage(statusMessage)
    end

end
Looks like I will have to ask him to add this feature to his mod. Until then, I was just able to change it myself by commenting out the end of that.

Thanks for your time!
Last edited by Smugger21 : 11/04/23 at 01:18 PM.
Report comment to moderator  
Reply With Quote
Unread 11/03/23, 07:20 PM  
Smugger21
 
Smugger21's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 23
Uploads: 1
Originally Posted by ZaiZah
Originally Posted by Smugger21
Since the update I have been getting User Logged on/Logged off Messages again. Even though it is blocked in the addon.
Thanks
This could be caused by another addon that hooks into the message handlers as you don't know which addon eso will load up first

I noticed that if you use pChat and have "Player status changed" Chat format handler on it could cause it to happen, also some ui mods that add their own chat message could also cause it. Try turning that setting off and see if it fixes it?

it's certainly something i'll see if i can make a change too though as it defeats the point of the setting otherwise :'D
So it seems that rChat is the one causing this issue. I did some testing, I tried adding rChat as a Dependency to this Addon and that did not fix the issue. Bummer. So I am not sure what else could be done then.
Report comment to moderator  
Reply With Quote
Unread 11/03/23, 04:29 AM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Originally Posted by JN Slevin
The option to see only the leaderboard notifications from friends seems to be gone. This was one of the primary features in this addon for me :/

Is there any way you can readd it?
I can certaintly get on that when i've got some time free over the week, i mainly removed it to get the fix in place as soon as i could as it was playing me up a little while getting it working with Endless Archive update and i wasn't sure if people did use the option

But it shouldn't be a massive undertaking now that its working, good job you reminded me otherwise i probably would of totally forgotton
Report comment to moderator  
Reply With Quote
Unread 11/03/23, 04:18 AM  
JN Slevin
 
JN Slevin's Avatar
AddOn Author - Click to view AddOns

Forum posts: 10
File comments: 95
Uploads: 4
The option to see only the leaderboard notifications from friends seems to be gone. This was one of the primary features in this addon for me :/

Is there any way you can readd it?
Report comment to moderator  
Reply With Quote
Unread 11/03/23, 03:05 AM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Originally Posted by Smugger21
Since the update I have been getting User Logged on/Logged off Messages again. Even though it is blocked in the addon.
Thanks
This could be caused by another addon that hooks into the message handlers as you don't know which addon eso will load up first

I noticed that if you use pChat and have "Player status changed" Chat format handler on it could cause it to happen, also some ui mods that add their own chat message could also cause it. Try turning that setting off and see if it fixes it?

it's certainly something i'll see if i can make a change too though as it defeats the point of the setting otherwise :'D
Report comment to moderator  
Reply With Quote
Unread 11/02/23, 04:43 PM  
Smugger21
 
Smugger21's Avatar
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 23
Uploads: 1
Since the update I have been getting User Logged on/Logged off Messages again. Even though it is blocked in the addon.
Thanks
Report comment to moderator  
Reply With Quote
Unread 10/31/23, 10:41 AM  
ApoAlaia

Forum posts: 6
File comments: 145
Uploads: 0
Originally Posted by ZaiZah
Update has been pushed out, Hopefully it should now follow your ingame settings choice when you disable/enable the Leaderboard setting in Social.
No, Thank You will no longer post rogue scores with it disabled

I've added an option to show/hide the Endless Archive scores and an option to disable the notification ping sounds

Additionally i've added a spacer at the bottom of the settings menu so that the dropdown menu doesn't clip

Happy Halloween everyone
Thanks for the update and happy Halloween to you too!
Report comment to moderator  
Reply With Quote
Unread 10/31/23, 07:32 AM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Update has been pushed out, Hopefully it should now follow your ingame settings choice when you disable/enable the Leaderboard setting in Social.
No, Thank You will no longer post rogue scores with it disabled

I've added an option to show/hide the Endless Archive scores and an option to disable the notification ping sounds

Additionally i've added a spacer at the bottom of the settings menu so that the dropdown menu doesn't clip

Happy Halloween everyone
Report comment to moderator  
Reply With Quote
Unread 10/31/23, 02:25 AM  
ApoAlaia

Forum posts: 6
File comments: 145
Uploads: 0
Originally Posted by NeuroticPixels
Originally Posted by ApoAlaia
The very last setting is 'wonky'

You can either leave it at the default setting or select 'none', can't really scroll the options.
LibAddonMenu needs updated.
Thanks for the heads up Didn't realise that this was the issue.

After reading your post went looking to the settings of other addons and... yup, definitely wonky there too.
Report comment to moderator  
Reply With Quote
Unread 10/31/23, 02:20 AM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Originally Posted by NeuroticPixels
Originally Posted by ApoAlaia
The very last setting is 'wonky'

You can either leave it at the default setting or select 'none', can't really scroll the options.
LibAddonMenu needs updated.
I thought it might be caused by the recent changes to the combobox, I'll change the version check for LibAddonMenu to the recent version

Thank you for bringing it to my attention, i'll get on to sorting these problems today
Report comment to moderator  
Reply With Quote
Unread 10/31/23, 02:19 AM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Originally Posted by Masteroshi430
Originally Posted by NeuroticPixels
Is this addon somehow keeping me from turning off Settings > Social > Leaderboard Notifications?
Multiple people told me that's the setting that needs to be turned off to stop receiving notifications in chat about Endless Archive scores, but it was off already. So I turned it on, turned it back off, and reloaded. I'm still getting the score messages in chat.

Any advice?

I figured it was this or Synced Account Settings.
I have both addons and have the same problem, the way Synced Account Settings works (I'm the mainteneer dev) I doubt it comes from it.
Does No, Thank you! check if this Leaderboard Notifications setting is on before moving the notifications to chat?
It currently doesn't, i'm sure it never did when i first got it back up and running. But no worries i can add that pretty quick to make sure its adhereing to the ingame settings
Report comment to moderator  
Reply With Quote
Unread 10/31/23, 02:03 AM  
NeuroticPixels
Addon Addict
 
NeuroticPixels's Avatar
Premium Member

Forum posts: 211
File comments: 869
Uploads: 0
Originally Posted by ApoAlaia
The very last setting is 'wonky'

You can either leave it at the default setting or select 'none', can't really scroll the options.
LibAddonMenu needs updated.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: