Pictures
File Info
| Compatibility: | Gold Road (10.0.0) Scions of Ithelia (9.3.0) Endless Archive (9.2.5) base-game patch (9.1.5) Necrom (9.0.0) Scribes of Fate (8.3.5) |
| Updated: | 05/17/24 06:14 AM |
| Created: | 05/11/15 01:10 PM |
| Monthly downloads: | 26,624 |
| Total downloads: | 868,246 |
| Favorites: | 534 |
| MD5: | |
| Categories: | Combat Mods, Bags, Bank, Inventory, Casting Bars, Cooldowns, PvP |
9.3.0
Auto Recharge (and repair) 
Optional Files (0)
Archived Files (39)
File Name |
Version |
Size |
Uploader |
Date |
2.78 |
34kB |
Baertram |
05/16/24 02:54 PM |
|
2.77 |
33kB |
Baertram |
10/21/23 06:34 AM |
|
2.76 |
32kB |
Baertram |
07/10/23 09:37 AM |
|
2.75 |
31kB |
Baertram |
12/04/22 05:27 PM |
|
2.74 |
31kB |
Baertram |
10/30/22 12:05 PM |
|
2.73 |
30kB |
Baertram |
08/21/22 05:34 AM |
|
2.72 |
30kB |
Baertram |
08/13/22 09:15 AM |
|
2.71 |
26kB |
Baertram |
02/01/22 05:10 AM |
|
2.70 |
26kB |
Baertram |
03/30/21 09:08 AM |
|
2.69 |
23kB |
Baertram |
03/28/21 01:05 PM |
|
2.68 |
23kB |
Baertram |
11/23/20 05:48 AM |
|
2.67 |
23kB |
Baertram |
10/17/20 01:04 PM |
|
2.66 |
19kB |
Baertram |
09/19/20 09:04 AM |
|
2.65 |
17kB |
Baertram |
03/21/20 08:41 PM |
|
2.64 |
17kB |
Baertram |
02/26/20 04:08 AM |
|
2.63 |
17kB |
Baertram |
02/24/20 05:14 PM |
|
2.62 |
17kB |
Baertram |
02/23/20 07:12 PM |
|
2.61 |
16kB |
Baertram |
06/18/19 06:55 AM |
|
2.60 |
16kB |
Baertram |
05/31/19 10:39 AM |
|
2.54 |
59kB |
Baertram |
01/27/18 08:23 PM |
|
2.51 |
58kB |
Baertram |
09/07/17 02:28 PM |
|
2.41 |
56kB |
Baertram |
07/04/17 01:49 PM |
|
2.4 |
57kB |
Baertram |
02/06/17 02:34 PM |
|
2.3 |
54kB |
Baertram |
11/21/16 03:46 PM |
|
2.2 |
54kB |
Baertram |
11/20/16 01:56 PM |
|
2.1 |
52kB |
Baertram |
11/12/16 02:52 PM |
|
2.0.5 |
42kB |
XanDDemoX |
09/08/15 02:08 PM |
|
2.0.4 |
42kB |
XanDDemoX |
08/12/15 03:04 PM |
|
2.0.3 |
7kB |
XanDDemoX |
08/11/15 01:25 PM |
|
2.0.2 |
6kB |
XanDDemoX |
05/23/15 01:07 AM |
|
2.0.1 |
6kB |
XanDDemoX |
05/22/15 09:58 PM |
|
1.0.7 |
5kB |
XanDDemoX |
05/20/15 09:41 PM |
|
1.0.6 |
4kB |
XanDDemoX |
05/20/15 09:16 PM |
|
1.0.5 |
4kB |
XanDDemoX |
05/18/15 10:41 PM |
|
1.0.4 |
4kB |
XanDDemoX |
05/18/15 10:00 PM |
|
1.0.3 |
4kB |
XanDDemoX |
05/18/15 08:10 PM |
|
1.0.2 |
4kB |
XanDDemoX |
05/18/15 04:28 PM |
|
0.0.6 |
4kB |
XanDDemoX |
05/18/15 02:12 PM |
|
0.0.5 |
3kB |
XanDDemoX |
05/17/15 07:36 PM |
 |
Comment Options |
07/25/22, 12:39 PM
|
|||
|
Super Moderator
  Forum posts: 5014
File comments: 6067
Uploads: 78
|
I already have the health needs to be > 0 check in there but from the debug log it says "Get out of combat" (which should happen after you are dead and not before!) and there your health was still 436 so you were not dead.
 I do not know why the server then all of sudden says you are dead and can't do that while you are dead... 436 Health is not dead. And even the [ARC]DeathStateChanged-isDead: true fires after the server said you cannot do this so the server updates your death state TOO LATE. This seems to be some server lag or whatever. API says you are alive and HP is > 0, server says you are out of combat (what only happens as you are dead or at least you do not get out of combat and all of sudden die then, except you jump of a cliff with low healt afterwards?) and then you finally die for the server. There is nothing one can rely on, right. Maybe a health needs to be at least 50% check would be okay there but this again is troubling the in combat repair checks and would not repair your equipped gear where you need it. Maybe I can add a general 1 second delay to the durability update checks as they seem to fire the second you die, before the server sends the health update to 0 and "you are dead event fires". Perhaps this will fix it. This total behaviour is weird and I guess it's server drivven madness  I'll make my mind again and see what I can find out myself. What troubles me the most is that I cannot get this "You cannot do this while mad" to even fire once for myself? Either my ping or server connection is better or I'm doing my checks at the wrong spot? Where did you try this and what did you fight there?
Last edited by Baertram : 07/25/22 at 12:41 PM.
|
||
|
|
|
07/25/22, 12:18 PM
|
||
|
Forum posts: 0
File comments: 22
Uploads: 0
|
Last edited by Busygeezus : 07/25/22 at 12:25 PM.
|
|
|
|
|
|
07/25/22, 12:15 PM
|
|||
|
Super Moderator
Forum posts: 5014
File comments: 6067
Uploads: 78
|
Oh damn, I forgot the chat output function. Fix is coming.
Found the bug and fixed it, redownload please from GitHub PTS branch link. Meanwhile: I saw the debiug log, thanks for the links. Sometimes it seems to work and detects you are dead properly, sometimes it doesn't  Seems to be server instance or whatever dependent... Could you please try if you get the "You cannot do that while dead" if no delay is used (delay to repair = 0). Maybe it's a coincidence of the delay. If this neither does work I'm really puzzled and need to find a way to consistently repeat the "You cannot do that while dead". ->From the debug messages I do not even see what it tries to do, it would not be a repair as this was done/finished before already, Maybe it's soething else ,but I do not know what exactly. This sucks 
Last edited by Baertram : 07/25/22 at 12:16 PM.
|
||
|
|
|
|
07/25/22, 11:59 AM
|
|
|
Forum posts: 0
File comments: 22
Uploads: 0
|
Last edited by Busygeezus : 07/25/22 at 12:00 PM.
|
|
|
|
|
07/25/22, 10:56 AM
|
|
|
Forum posts: 0
File comments: 22
Uploads: 0
|
Last edited by Busygeezus : 07/25/22 at 12:11 PM.
|
|
|
|
|
07/25/22, 10:52 AM
|
||
|
Super Moderator
Forum posts: 5014
File comments: 6067
Uploads: 78
|
No thats not on purpose. Will have a look and tell you as I did update the files and you need to re download it.
What settings exactly did you test with as the disconnect happened and where were you fighting against what kind of mobs please? I'll try to rebuid it with exactly your settings then. Sorry that is not added to the LibDebugLogger, we cannot. Just send me your live/SavedVariables/Recharge.lua again to [email protected] e.g. and tell me the account/charname, thanks. Edit: Found the bug and fixed it, redownload please from GitHub PTS branch link.
Last edited by Baertram : 07/25/22 at 11:02 AM.
|
|
|
|
|
|
07/25/22, 10:24 AM
|
|
|
Forum posts: 0
File comments: 22
Uploads: 0
|
quick update and a question. i cant change minim condition percentage, thats on purpose? increasing that would greatly reduce the time it takes to test
 (nvm, i got some petty repairkits)https://sir.insidi.at/or/logviewer/JirHiq "you cant do that while dead" then disconnect https://sir.insidi.at/or/logviewer/wzkM22 "you cant do that while dead" @18:32:01.231 addons active: debuglogviewer autorecharge LibCustomMenu LibDebugLogger LibAddonMenu-2.0 LibGetText
Last edited by Busygeezus : 07/25/22 at 10:51 AM.
|
|
|
|
|
07/25/22, 05:09 AM
|
|
|
Forum posts: 0
File comments: 22
Uploads: 0
|
Last edited by Busygeezus : 07/25/22 at 05:13 AM.
|
|
|
|
|
07/24/22, 06:14 AM
|
|||
|
Super Moderator
Forum posts: 5014
File comments: 6067
Uploads: 78
|
Hm, so your test was the same like mine and I never saw that "you cant do that while dead".
Important: Is any other addon active while you tested? Maybe it's a correlation of AutoRecharge and the other addons. I've tested with AR alone, and very few addons (no total UI remakes or similar like Bandits UI, Azurah, AUI, and so on). I'd be interested into the simplest test, same I did: All addons off, only AR enabled. Same settings as you said, but put it to 99% and only have the lowest repair kits so the repair will not do too much, only like 6%. Craglorn, just run into a mob group near Belkarth e.g. the scorpions if you leave the city to the crafting stations side, there is a stone passage at the right where 3 scorpions wait for your. Do not fight, just run in and wait to die. No disconnect should happen. Repeat this and fight a bit to make the fight last like 1-2 minutes, like only heal & shield yourself a bit in between and wait for the durability of your worn items to change, and the repair to happen then. Then let yourself die and see if any disconnects happen. If not, repeat the same with the biggest repair kits. I had done both and never got disconnected, nor saw that mesasge "You cannot do that while dead". So I'm interested into how to get this message then. Maybe it depends on the zone you are in and the instance, and how crowded they are. I hate non-repeatable bugs like these. Many many thnks for all of your testing and support! I guess I need to recode a lot to make the delayed repair and charge work better, and also to be able to check for deaths delayed somehow Recode of Repair features: The recode of the repair features was done now and I've added debug messages. -> Important: Auto Recharge is currently disabled to ease the debug output! Last updated: 2022-07-25, 3am CET If you re-download from the link at GitHub>PTS version you can test with this one. You might test without a delay at the repair, or a less delay of 100ms e.g. I hope it will fix the disconnects now? You can use LibDebugLogger to log the debug messages. Please install DebugLogViewer too, login, go to the DebugLogViewer settings panel, submenu LibDebugLogger -> Enable the "stack traceback" option please. Before a new test you can reset the log file to shrink it's size at the DebugLogViewer -> LibDebugLogger settings menu. If you get disconnected: Note date and time! Stay logged out and navigate to your SavedVariables folder, and backup the file LibDebugLogger.lua You can upload it here then and shar it's link with me so I can have a look at the debug message and what has happened: https://sir.insidi.at/or/logviewer/
Last edited by Baertram : 07/24/22 at 07:18 PM.
|
||
|
|
|
|
07/23/22, 06:07 AM
|
|
|
Forum posts: 0
File comments: 22
Uploads: 0
|
Last edited by Busygeezus : 07/23/22 at 06:13 AM.
|
|
|
|
|
07/23/22, 02:56 AM
|
|||
|
Super Moderator
Forum posts: 5014
File comments: 6067
Uploads: 78
|
Thanks for the feedback. I was only able to test this while running into a mob group and let them kill me, and I never got disconnected then as I died (and it never repaired after I died). I've tested this overland, not in a dungeon. So what did you do differently here? And if the repair in combat is off it should repair after combat ends, and you are still alive. Will try this too, maybe I bricked the code.
|
||
|
|
|
|
07/22/22, 03:24 PM
|
|
|
Forum posts: 0
File comments: 22
Uploads: 0
|
Last edited by Busygeezus : 07/22/22 at 04:18 PM.
|
|
|
|
|
07/22/22, 12:44 PM
|
|
|
Super Moderator
Forum posts: 5014
File comments: 6067
Uploads: 78
|
Okay @Busygeezus, I think you/Kyzeragon were right:
The durability updates if you die is fired before the event_player_dead etc. fires, and IsUnitDead("player") returns false :-(  I've circumvented this now by checking for the player health. If it's 0 I assume the player is dead. I've also asked ZOSDanBatson if the API function IsUnitDead("player") would return true earlier, before the durability is updated after death (if possible). Could you please test this version here, it should hopefully fix the disconnect issues now! https://github.com/Baertram/Recharge.../heads/PTS.zip Please ONLY extract the Recharge folder (within the Recharge-PTS folder) to your live/AddOns folder! I'm waiting for your feedback.
Last edited by Baertram : 07/22/22 at 01:00 PM.
|
|
|
|
|
07/22/22, 04:28 AM
|
|||
|
Super Moderator
Forum posts: 5014
File comments: 6067
Uploads: 78
|
Interesting, thanks for bringing this to my attention! This explains a lot... and damn, this sucks. We need to rely on the API values and if they are returning wrong values everything elso you do to circumvent it will lead to massive problems with other API functions:
I'll double check that and see if I can add a general delay to the checks, but this would trouble other checks again which need to be done "directly" like "are we in fight", "are we mounted". If I delay that in total by 1 second these values will return wrong, so I would need to cache those, then delay 1 second for the IsDeadCheck -> total code overhaul  If this really is the case, that IsUnitDead is returning false allthough one is dead already, this is a clear wrong API return value of ZOs code I'll try to test this and see if another check like "is the player's healh <= 0" would be able to return true at the sme time where IsPlayerDead returns false yet.
Last edited by Baertram : 07/22/22 at 04:35 AM.
|
||
|
|
|
|
07/21/22, 11:56 AM
|
|||
|
Forum posts: 0
File comments: 22
Uploads: 0
|
i read an interesting post by kyzeragon about autorepair and linked disconnects
Last edited by Busygeezus : 07/21/22 at 11:58 AM.
|
||
|
|
|
|
Support AddOn Development!
You have just downloaded by the author . If you like this AddOn why not consider supporting the author? This author has set up a donation account. Donations ensure that authors can continue to develop useful tools for everyone.
