Hey Troodon80,

your addon is leacking some variables to the global table _G.
Especially this one here is critical "isMarked" as FCOIS is using same variable names and you overwrite it that way!


Please fix this asap and add the local up in front:
local isMarked, markedArray = FCOIS.IsMarked(bagId, slotId, {9}, nil)


Other global leaking variables:
x !!! very critical (function AddItemsToDeconstructionQueue)
itemString (function ListItemsInQueue)
itemToDeconstruct (function MD.ContinueWork())
slotIndex !!!!!! very critical! (function AddCraftingBagItemsToRefineQueue)

Please fix those asap and check your other code files for leaking to global variables, thanks.

If the API of FCOIS is used properly ANY FCOIS marker icon is protected against deconstruction unless it was not explcitly allwowed to be deconstructed (for normal marker icons, check the submenu anti-* protection to e.g. allow deconstruction of items marked as intrictae or marked for decon -> even this is protected by default / for dynamic icons: each icon itsself defines if allowed to be deconstructed or not at the icon settings).

I've tested this with a self crafted item marked for decon (bagId 1, slotindex 44)
-Marked for decon
/tb FCOIS.IsDeconstructionLocked(1,44) -> false
-Marked as sell in guild store
/tb FCOIS.IsDeconstructionLocked(1,44) -> true
-Marked for decon & sell at guildstore (only works if you have not enabled to remove automatically other marker icons if you apply the decon/sell at guild store!)
/tb FCOIS.IsDeconstructionLocked(1,44) -> true

Also tested this with other set items etc, all was okay.
Did you maybe enable at the anti-* protection settings submenu -> deconstruction -> Allow decon (ignore others)? This would allow the item to be deconstructed if it's marked for decon AND sell at guildstore as the decon icon alone would be respected then!



Edit:
Seems the below described "open decon panle first" was added already as I can see at function MD.StartDeconstruction(). Even looks like my old provided code ;-) So decon panel seems to be properly opened meanwhile, alright.

If you are still able to deon items marked for "sell at guil store" that way, please write me a PM and I'll have a look with you guys how to fix this.




If items marked as sell at guildstore got deconstructed either the API was not used properly, or there is an "allow decon of marked at guild store" setting at the anti-* protection settings whch was enabled, or the API is not working properly (which might be the case if the addon using the API is e.g. trying to decostruct items AT THE SAME SECOND the crafting tables open AND it is not properly activating the deconstruction tab at the crafting stations -> e.g. try to decon all the second the crafting table is interacted with and we are still at the refinement tab!)

The game allows decon that way but even default vanilla UI is not working properly if you just do it that way and I have told each addon doing this to change that please. If they do not change it and want to stay at refine to do a deconstuction, not my problem.
Either use the game's API and UI as expected or live with the iterferences.

I even had added an explicity pass-in of the LF_SMITHING_DECONSTRUCTION filterId to circumvent that problem and only check this (instead of checking the active scene, fragment, controls showing which obviously fails if you expect it to show the decon inventory but refine inv. is shown!) one e.g. by using the API FCOIS.IsDeconstructionLocked(bagId, slotIndex, doNotCheckJewelry)
But I cannot say it is working each time, depends on the addons using it and what they do before (as described above).

I'm open to improve this if there is a way but I'd rather let the addons open decon panel properly before starting a decon, instead of doing all at the refine UI tab. This should fix a lot of problems, especially with other addons that apply filters and protections for decon AT the deconstuction UI (but not at refine or any other).

And there is a pretty easy way using the descriptor of the decon tab menu button to open that menu easily!
ZO_MenuBar_SelectDescriptor(self.tabs, descriptorNameOfDeconTab)
where self-tabs should be SMITHING.deconstructionPanel.tabs or similar and the descriptorNameOfDeconTab would be the SI_* string constant used for that tab button. Inspect the tab button with merTorchbug/zgoo e.g. and check for the data table or the descriptor table to see the text. Search for that text at merTorchbug Strings tab then to find the SI constant.

I've got items marked for sale at a guild store. Since that is a default icon it doesn't have the ability to block deconstruction. Can you enhance the FCOIS integration so I can block some of the default icons from being deconstructed?

Yes, absolutely. I'll get that added soon.

Hey! Could there be an option, when turned on the addon would warn when Meticulous Disassembly isn't slotted? Or something similar

Thanks for your work

I actually removed this option and made it use the in-game option, which more easily allows you to toggle it from within the deconstruction menu itself instead of needing to leave the decon panel and go find the addon settings.



The base game checkbox is plainly visible outside of using gamepad mode. I don't imagine I'll change this unless I get more feedback saying a change would be the best direction.

As I do not personally use FCOIS, I do not know. The options for it are from before I took over maintenance. Though all I can say is that the options for FCOIS and FilterIt are run before any of the other filters.

What other options do you have enabled/disabled? Do you have CraftStore, and the optional CraftStore compatibility for account-wide trait knowledge enabled?

So I have the setting set to where I can deconstruct items that have already been researched and it's not deconstructing items that I already have researched. Why is this? Bug?

also items that are flagged with a dynamic icon that are marked as no-deconstruct show up in the list of queued targets of deconstruction because I enabled their trait for deconstruction. Not sure that FCOIS is actually integrated.

I was wanting to use my FCOIS item icons, but there are no options for it in the list.
Am I missing something?

I love this addon must have

Requesting an option to remove ( Include Bank items ) and make it OFF by default account wide please

I just destroyed my bank using Mass Decon addon

hey so there is a new ally called the Ragpicker it can deconstruct all items in your inventory but its one by one peice is it possible to make this mod compatible with the ally to where all items get destructed at one time? the ally can salvage all the items at same time heavy,light,med armor wepons gylphs and such so it would be a mass inventory clean while being in an instance etc




Edit: i just read the bottom of the summary sorry!! but this would be a great mod with completed!

Auto-update was activated so I should have been on the correct version. But anyway, a reinstall fixed it.
Thx for the help and the nice addon!

This should already be fixed in the last version I uploaded. Try updating.

Hi, I use Keyboard. If I downgrade to an older version it appears again.

Thanks a lot. x)