Go to Page... |
Compatibility: | Dragon Bones (3.3) |
Updated: | 04/18/18 06:05 PM |
Created: | 04/05/18 03:59 AM |
Monthly downloads: | 62 |
Total downloads: | 3,414 |
Favorites: | 14 |
MD5: |
DescriptionWouldn't it be nice if you had a Lore Library, but for every book you encountered across your travels? Recorded, readable at any point, with a way to keep track of which books you have/haven't read, sortable by various factors (such as alphabetical, the time you found the book, et ceteara), and searchable for when you're seeking out that specific bit of lore? Welcome to Pocket Apocrypha, your own little slice of Hermorah's own realm right in your proverbial pocket!
FeaturesIn the hallowed words of our dear Commandant Lassard, Pocket Apocrypha can do many, many fine things for you.
FAQQ: Why port? What's wrong with Librarian?
CreditsMy ever patient beau who manages to sometimes raise my courage to the point where I can post things online.
Comment Options |
04/05/18, 06:58 AM | |
Forum posts: 2
File comments: 367
Uploads: 0
|
I just downloaded your addon. When I try to import from the journal database the game crashes.
|
|
hagermanj |
View Public Profile |
Send a private message to hagermanj |
Find More Posts by hagermanj |
Add hagermanj to Your Buddy List |
Phinix |
View Public Profile |
Send a private message to Phinix |
Visit Phinix's homepage! |
Find More Posts by Phinix |
Add Phinix to Your Buddy List |
votan |
View Public Profile |
Send a private message to votan |
Visit votan's homepage! |
Find More Posts by votan |
Add votan to Your Buddy List |
04/05/18, 11:43 AM | ||
|
Error upon reading a new book.
Maybe the conversion from Librarian screwed with it somehow? |
|
|
joshmiller83 |
View Public Profile |
Send a private message to joshmiller83 |
Send email to joshmiller83 |
Visit joshmiller83's homepage! |
Find More Posts by joshmiller83 |
Add joshmiller83 to Your Buddy List |
04/05/18, 01:06 PM | |
Fix for import crash...
EDIT: For great justice!
Last edited by Phinix : 04/06/18 at 08:14 AM.
|
|
|
Phinix |
View Public Profile |
Send a private message to Phinix |
Send email to Phinix |
Visit Phinix's homepage! |
Find More Posts by Phinix |
Add Phinix to Your Buddy List |
04/05/18, 01:34 PM | |
Unknown player...
Please delete, FML!
Last edited by Phinix : 04/05/18 at 01:38 PM.
|
|
|
Phinix |
View Public Profile |
Send a private message to Phinix |
Send email to Phinix |
Visit Phinix's homepage! |
Find More Posts by Phinix |
Add Phinix to Your Buddy List |
04/05/18, 01:35 PM | ||
|
Re: Unknown player...
Wrong addon maybe? lol
|
|
|
joshmiller83 |
View Public Profile |
Send a private message to joshmiller83 |
Send email to joshmiller83 |
Visit joshmiller83's homepage! |
Find More Posts by joshmiller83 |
Add joshmiller83 to Your Buddy List |
04/05/18, 01:42 PM | |
|
I was just about to ask what Phinix was on. >_>;
I was also going to ask: Did anyone else see josh's post? Anyone? Having a staggered import is a very bad idea. Pocket Apocrypha uses ESO's own lore library building code. So if the import is crashing, it's likely because a bug is happening somewhere outside of the import. The staggered import was already tried in Librarian and caused many and varied problems. If crashes are occurring, it's likely due to the bug josh is having compounded over and over by running the import. |
|
Werewolf Finds Dragon |
View Public Profile |
Send a private message to Werewolf Finds Dragon |
Send email to Werewolf Finds Dragon |
Visit Werewolf Finds Dragon's homepage! |
Find More Posts by Werewolf Finds Dragon |
Add Werewolf Finds Dragon to Your Buddy List |
04/05/18, 01:57 PM | ||
It is worth trying that code i posted. It is working without problems for me. Currently doing import on each of my characters to confirm total imported book count matches total known.
Last edited by Phinix : 04/05/18 at 02:03 PM.
|
||
|
Phinix |
View Public Profile |
Send a private message to Phinix |
Send email to Phinix |
Visit Phinix's homepage! |
Find More Posts by Phinix |
Add Phinix to Your Buddy List |
04/05/18, 02:19 PM | |
|
It's still not a great idea, though, Phinix. I'm sorry. I had a better one, I've already implemented it and it's working and even safer and quicker.
As I suspected, the problem was with how AddBook was being called. So I properly staggered that, instead. I'm pleased with how the import function is working, now. Edit: Running more tests now, just to be sure. Will upload soon. Edit: I think I know exactly what's up, thanks to testing! I think I have an even smarter idea!
Last edited by Werewolf Finds Dragon : 04/05/18 at 02:26 PM.
|
|
Werewolf Finds Dragon |
View Public Profile |
Send a private message to Werewolf Finds Dragon |
Send email to Werewolf Finds Dragon |
Visit Werewolf Finds Dragon's homepage! |
Find More Posts by Werewolf Finds Dragon |
Add Werewolf Finds Dragon to Your Buddy List |
04/05/18, 02:23 PM | |
Right on, I'll look forward to it then.
|
|
|
Phinix |
View Public Profile |
Send a private message to Phinix |
Send email to Phinix |
Visit Phinix's homepage! |
Find More Posts by Phinix |
Add Phinix to Your Buddy List |
04/05/18, 02:27 PM | ||
|
Crashing is one thing. Locking up one's computer is another entirely.
Last edited by Werewolf Finds Dragon : 04/05/18 at 02:27 PM.
|
|
|
Werewolf Finds Dragon |
View Public Profile |
Send a private message to Werewolf Finds Dragon |
Send email to Werewolf Finds Dragon |
Visit Werewolf Finds Dragon's homepage! |
Find More Posts by Werewolf Finds Dragon |
Add Werewolf Finds Dragon to Your Buddy List |
04/05/18, 02:32 PM | |
|
YES!
I was right! It's because it was calling RefreshData on every instance of AddBook. Derp. That's what was causing the issue. It was nothing to do with string handling at all! It's because ESO can't handle refreshing its UI that much, that fast. So by ensuring AddBook doesn't call RefreshData, and that RefreshData is actually called after the import, once, you don't need to stagger anything at all! dfsaghagsd SDAGHO EXCITED. HAPPY. Sorry. I had a feeling, though! This is why I wanted to test more. Uploading soon, testing more more. Edit: Repeated tests have revealed good, crash free results! And I didn't need to use staggering. AAAAAAAAAAAAAAAAAAAAAAA Too much adrenaline. Need to upload, then calm down. Edit: And no extra, extraneous functions needed, no extra function calls needed. In fact, less function calls needed. Same end result. No crash. Everything's good. Yeah, time to upload. Edit: Am I the only one who gets this excited about fixing things and writing good code?
Last edited by Werewolf Finds Dragon : 04/05/18 at 02:45 PM.
|
|
Werewolf Finds Dragon |
View Public Profile |
Send a private message to Werewolf Finds Dragon |
Send email to Werewolf Finds Dragon |
Visit Werewolf Finds Dragon's homepage! |
Find More Posts by Werewolf Finds Dragon |
Add Werewolf Finds Dragon to Your Buddy List |
04/05/18, 03:03 PM | |
|
New version up.
I knew the problem couldn't have been specifically with the import function. I benchmark lua a lot, so I understood that string manipulation happening that fast and on that scale was still efficient and wouldn't have caused any problems. I knew the issue had to lie elsewhere. I didn't know if I'd be able to figure out where else though. I wondered if I'd be stuck for a time and if I'd have to suck it up and allow a small amount of OnUpdate-ish staggering in order to actually make it work, at least until I found out where the real culprit was. I think the real culprit rests somewhere in C, if I'm honest. Outside of the realm of lua. There's something going on there and ESO just can't refresh its UI with that much data, that often, without crashing. The same thing happens with the search function if that's improperly handled (had that issue back when this was called Librarian, and fixed it). So, essentially, you have to be careful about how often you call RefreshData. By moving RefreshData out of AddBook and only calling it once after the import has finished, this removes the pressure from ESO's UI to update that fast and stops it from crashing. I don't know if anyone actually cares about any of this, but there you go. |
|
Werewolf Finds Dragon |
View Public Profile |
Send a private message to Werewolf Finds Dragon |
Send email to Werewolf Finds Dragon |
Visit Werewolf Finds Dragon's homepage! |
Find More Posts by Werewolf Finds Dragon |
Add Werewolf Finds Dragon to Your Buddy List |
04/05/18, 03:09 PM | |
|
I don't think Minion likes your versions or something? It is not recognizing an update!
|
|
joshmiller83 |
View Public Profile |
Send a private message to joshmiller83 |
Send email to joshmiller83 |
Visit joshmiller83's homepage! |
Find More Posts by joshmiller83 |
Add joshmiller83 to Your Buddy List |