Go to Page... |
Compatibility: | Elsweyr (5.0.5) Wrathstone (4.3) |
Updated: | 05/30/19 08:47 AM |
Created: | 03/05/19 11:22 AM |
Monthly downloads: | 34 |
Total downloads: | 3,537 |
Favorites: | 6 |
MD5: |
Comment Options |
boltyr |
View Public Profile |
Send a private message to boltyr |
Find More Posts by boltyr |
Add boltyr to Your Buddy List |
05/04/21, 11:07 AM | |
Forum posts: 0
File comments: 7
Uploads: 0
|
I realize the last post is almost a year old, but I thought I'd mention that the addon is working fine for me. I did edit CustomQualityColors.txt to update the API Version to the lastest (100034) and removed LibStub from the DependsOn line. With those changes and a current LibAddonMenu-2.0, this addon works.
|
|
Berun |
View Public Profile |
Send a private message to Berun |
Find More Posts by Berun |
Add Berun to Your Buddy List |
05/28/20, 02:10 AM | |
Forum posts: 0
File comments: 1
Uploads: 0
|
Update?
As I am color blind, I cant see the difference between the purple and blue items. I had this add on and it was working perfectly till the Greymoor update.
Is there plans to update or is anyone working on something similar? |
|
BnJbirds |
View Public Profile |
Send a private message to BnJbirds |
Find More Posts by BnJbirds |
Add BnJbirds to Your Buddy List |
05/31/19, 02:05 AM | ||
|
|
|
|
DonRomano |
View Public Profile |
Send a private message to DonRomano |
Find More Posts by DonRomano |
Add DonRomano to Your Buddy List |
05/30/19, 06:11 PM | ||
Forum posts: 0
File comments: 5
Uploads: 0
|
|
|
|
Farloc |
View Public Profile |
Send a private message to Farloc |
Find More Posts by Farloc |
Add Farloc to Your Buddy List |
05/30/19, 08:56 AM | |
|
It proved to be a little more difficult than I thought but I think I've finally found a solution.
It turned out that CQC needs to register tooltip hooks BEFORE TTC does so I had to move the call to HookTooltips function to main file level. It's not pretty but it should work. Please, let me know if version 1.12 works properly. |
|
DonRomano |
View Public Profile |
Send a private message to DonRomano |
Find More Posts by DonRomano |
Add DonRomano to Your Buddy List |
05/29/19, 04:01 AM | ||
|
Later in the day I'll prepare a new version of the addon and we'll see Thanks! |
|
|
DonRomano |
View Public Profile |
Send a private message to DonRomano |
Find More Posts by DonRomano |
Add DonRomano to Your Buddy List |
05/29/19, 03:40 AM | ||
Forum posts: 0
File comments: 5
Uploads: 0
|
Replaced: SafeAddString(SI_TOOLTIP_ITEM_NAME, CustomQualityColors.GetItemQualityC(item_quality):Colorize(CustomQualityColors.OriginalTooltipName), 2) with: zo_strformat(SI_TOOLTIP_ITEM_NAME, CustomQualityColors.GetItemQualityC(item_quality):Colorize(CustomQualityColors.OriginalTooltipName)) Edit: And I realized after I typed a reply you came to a similar conclusion. Thanks for digging into it!
Last edited by Farloc : 05/31/19 at 02:40 AM.
|
|
|
Farloc |
View Public Profile |
Send a private message to Farloc |
Find More Posts by Farloc |
Add Farloc to Your Buddy List |
05/29/19, 01:19 AM | |||
Forum posts: 9
File comments: 230
Uploads: 0
|
I remember having a similar problem with a previous addon "Enchanted Quality" that would add the quality of the enchantment of an item to its name in the tooltip. So Legendary Powered Lightning Staff would be displayed for a Powered Lightning staff that had a yellow enchantment. As an alternative it would colorize the name of the enchantment to indicate the quality of the enchantment visually. The renaming in the tooltip would also cause problems with TTC finding the name of the item, and some other addons too. So I turned that part of the naming addon off and went with the colorized description of the enchantment in the description of the item stats. It worked well after that.
|
||
|
Akopian Atrebates |
View Public Profile |
Send a private message to Akopian Atrebates |
Find More Posts by Akopian Atrebates |
Add Akopian Atrebates to Your Buddy List |
05/29/19, 12:44 AM | ||
|
I suspect I've found the source of the problem. To change the color, CQC changes a system string SI_TOOLTIP_ITEM_NAME using function called Colorize. TTC uses the same string (SI_TOOLTIP_ITEM_NAME) to find the name of the item and then checks if the item is in the TCC database. But if the SI_TOOLTIP_ITEM_NAME string is changed TTC will not find the item - simple. So if TTC hooks up before CQC everything should work just fine. I'll have to call my hookup functions a little later and it should solve the problem. Let me prepare a new version of the addon... |
|
|
DonRomano |
View Public Profile |
Send a private message to DonRomano |
Find More Posts by DonRomano |
Add DonRomano to Your Buddy List |
05/29/19, 12:15 AM | ||
|
I looked briefly at the code and it turns out that both TTC and CQC hijack the same function responsible for displaying item tooltip. TTC uses it to insert its information and CQC just changes the color of the item string. Both addons call the base function so it should work no matter which addon hooks to the function as the first one. It looks like TTC hookup is working because as you've noticed there is an empty section divider and the first thing TTC does is inserting it into tooltip. But then for some reason TTC hookup function doesn't find "PriceInfo". In TTC there's a long function called "GetPriceInfo" with a lot of ifs and I suspect one of the conditions is not met and the function returns nil. I will try to reproduce the problem and debug it. In the meantime could you do a little debugging? I can see that TTC has some debug messages that need to be turned on. To do it you have to change "TamrielTradeCentre.IsDebug = false" to true in "TamrielTradeCentreInit.lua". It's right at the beginning of the file. Could you do it and see if there are any debug messages that will help us find the source of the problem?
Last edited by DonRomano : 05/29/19 at 12:24 AM.
|
|
|
DonRomano |
View Public Profile |
Send a private message to DonRomano |
Find More Posts by DonRomano |
Add DonRomano to Your Buddy List |
05/28/19, 08:45 PM | ||
Forum posts: 0
File comments: 5
Uploads: 0
|
It should be noted that this was working fine before Elsweyr dropped but there has been a huge migration of addons to separate themselves from their libraries. Unsure if Lua has defined scoping. By the way... Thanks so much for making this. I am color blind and being able to change the colors helps immensely!!
Last edited by Farloc : 05/28/19 at 09:20 PM.
|
|
|
Farloc |
View Public Profile |
Send a private message to Farloc |
Find More Posts by Farloc |
Add Farloc to Your Buddy List |
05/28/19, 01:48 AM | |
|
Hello Farloc,
Thank you for the info and for narrowing it down to one function! I'll try to take a closer look and see what's going on. One more question: when the TTC tooltips are broken - are they missing on all of the items or is it that just only some of them lack the TTC tooltip? |
|
DonRomano |
View Public Profile |
Send a private message to DonRomano |
Find More Posts by DonRomano |
Add DonRomano to Your Buddy List |
05/28/19, 01:32 AM | |
Forum posts: 0
File comments: 5
Uploads: 0
|
Good evening!
I am running into a conflict between Custom Quality Colors and TTC. I am unsure where it could possible be coming from. With a binary search turning off addons it was narrowed to Custom Quality Colors. I commented out ```CustomQualityColors.HookTooltips()``` in OnAddOnLoaded and it looks to be working without issues. Working TCC with Custom Colors disabled - https://pasteboard.co/IgKTJnh.jpg Blank Tooltip section with Custom Colors enabled - https://pasteboard.co/IgKUicK.jpg
Last edited by Farloc : 05/28/19 at 01:33 AM.
|
|
Farloc |
View Public Profile |
Send a private message to Farloc |
Find More Posts by Farloc |
Add Farloc to Your Buddy List |
05/25/19, 02:46 AM | ||
Forum posts: 1
File comments: 402
Uploads: 0
|
Re: compatibility with other add-ons
|
|
|
Shadowshire |
View Public Profile |
Send a private message to Shadowshire |
Find More Posts by Shadowshire |
Add Shadowshire to Your Buddy List |