Go to Page... |
Compatibility: | Necrom (9.0.0) Scribes of Fate (8.3.5) Firesong (8.2.5) Lost Depths (8.1.5) High Isle (8.0.0) |
Updated: | 05/07/23 05:44 PM |
Created: | 12/11/20 03:03 AM |
Monthly downloads: | 1,072 |
Total downloads: | 95,913 |
Favorites: | 23 |
MD5: |
LibSkillBlocker.RegisterSkillBlock(addonName, abilityId, customBlockHandler, noErrorMessage) LibSkillBlocker.RegisterSkillBlock(addonName, abilityId)
LibSkillBlocker.UnregisterSkillBlock(addonName, abilityId)
LibSkillBlocker.GetRegisteredAbilityIds() -> {}[abilityId][addonName] = callback
LibSkillBlocker.GetRegisteredAbilityId(abilityId) -> {}[addonName] = callback
LibSkillBlocker.GetRegisteredAbilityIdsByAddon(addonName) -> {}[abilityIds] = callback
if (IsPlayerInAvAWorld() or IsActiveWorldBattleground()) then LibSkillBlocker.UnregisterSkillBlock("NoInnerLight", 40478) else LibSkillBlocker.RegisterSkillBlock("NoInnerLight", 40478) end
File Name |
Version |
Size |
Uploader |
Date |
1.0.7 |
2kB |
Baertram |
04/30/23 11:41 AM |
|
1.0.6 |
1kB |
Baertram |
04/14/23 03:40 AM |
|
1.0.5 |
2kB |
Baertram |
04/13/23 11:00 AM |
|
1.0.4 |
1kB |
Jarva |
12/20/21 08:04 PM |
|
1.0.3 |
1kB |
Jarva |
12/15/20 08:03 PM |
|
1.0.2 |
1kB |
Jarva |
12/14/20 01:01 AM |
|
1.0.1 |
1kB |
Jarva |
12/13/20 12:14 AM |
|
1.0.0 |
1kB |
12/11/20 03:03 AM |
Comment Options |
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
Jarva |
View Public Profile |
Send a private message to Jarva |
Find More Posts by Jarva |
Add Jarva to Your Buddy List |
12/12/20, 08:23 AM | |||
|
Whoops, my bad eyes
Thanks for the clarification.
|
||
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
02/10/22, 01:40 PM | |
|
Hey Jarva, is this library able to block skills without the abilityId, e.g. usage of quickslots too?
or would this be an addition you want to add? Quickslots also are action buttons like the skill ones, just handled a bit differently. But maybe it would be possible to define a callback function that is called as a quickslot is used, where we can check the quickslot's slot data for our needs and if we return "true" the call to teh quickslot will be blocked? it also uses ZO_ActionBar_CanUseActionSlots and fires the quickslot usage with ZO_ActionBar_OnActionButtonUp, so one shouldbe able to provide such a block feature for quickslots, right? You are able to detect the quickslot slot via the slotNum. It should be 9 (ACTION_BAR_FIRST_UTILITY_BAR_SLOT + 1) Lua Code:
Last edited by Baertram : 02/10/22 at 01:51 PM.
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
02/14/22, 02:34 PM | ||
|
|
|
|
Jarva |
View Public Profile |
Send a private message to Jarva |
Find More Posts by Jarva |
Add Jarva to Your Buddy List |
02/16/22, 09:13 AM | ||
|
Thank you very much!
|
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
09/26/22, 11:51 PM | |
Not sure why you have that second line on the section bellow, but removing that fixes the blocks not working on gamepad mode.
Removed it for a skill blocker I made, could need some more testing but haven't gotten any problems yet. Lua Code:
|
|
|
notnear |
View Public Profile |
Send a private message to notnear |
Find More Posts by notnear |
Add notnear to Your Buddy List |
03/26/23, 08:33 AM | |
|
I think you could improve this line to only one "match" check against the pattern:
Code:
local slotNum = tonumber(debug.traceback():match('keybind = "ACTION_BUTTON_(%d)')) or tonumber(debug.traceback():match('keybind = "GAMEPAD_ACTION_BUTTON_(%d)')) Lua Code:
This will find the occurrence of " (escaped: \") followed by any text and then ACTION_BUTTON. So it should find "GAMEPAD_ACTION_BUTTON or ACTION_BUTTON or any other *ACTION_BUTTON that ZOs will implement As the function LibSkillBlocker.IsSlotBlocked is called very often you shluld also add a local isSlotBlocked = LibSkillBlocker.IsSlotBlocked after the function and use tha local "speed up reference" isSlotBlocked instead of LibSkillBlocker.IsSlotBlocked each time in your functions then! Also: If no skill block is registered, you should strip the call to your function LibSkillBlocker.CanUseActionSlots() in total! E.g. check with a local variable if ANY skill block is registered at the start of LibSkillBlocker.CanUseActionSlots() and if nothing is registered skip the performance expensive stack.traceback calls! You only need to update the local for "is ANY skill block registered" as a new skill block register was done, and that's all. Saves a lot of performance that way! Thanks for considering this. I've created such a performance optimized version, also checking with assert if the API function are used properly, else shows an error message. It also removes the gamepad mode check so that gamepad mode officially will work properly. If you are interested, here is the link: LibSkillBlocker 1.0.5 changed by Baertram
Last edited by Baertram : 03/26/23 at 09:19 AM.
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/13/23, 06:00 AM | |
|
Hi Jarva,
as you said you are not playing ESO any longer and offered other devs to be added to the teams of addons , or to take over: Could youz please add me to the team of this library so I can update it, thanks. |
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/13/23, 11:52 AM | ||
Forum posts: 0
File comments: 11
Uploads: 0
|
FPS drop
Hello,
I've been noticing severe performance drops mainly in the form of FPS loss ever since the latest update. It took me a while to pinpoint which update was causing the issue but I managed to pinpoint it to this one.
|
|
|
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
04/13/23, 12:28 PM | ||
|
Re: FPS drop
This library was updated today, 1h ago (~7pm). So are you sure this is the issue for your FPS drops? Not if "since last update" means since lsat ESO patches I did not realize any drops within 2 weeks of testing and usage so far? If this took "a while for you to pinpoint it" your while would have been 10 minutes or less, as the update 1.5 was done today as I said! -> And I'd especially know "how did you manage" to pinpoint it to this library with version 1.0.5? What did you test, and when did you test this, so that you came to this conclusion? Could you do me the favor and provide me any proof for that, so I can work on it. What addons do you use that use this lirary here? Try to use SAME addons and libraries and ONLY replace version 1.0.5 with 1.0.4 from here, and do the same things, and check your FPS then. For me it never had any noticably difference at all, but maybe it depends on the addons used in combination with this library. Maybe it was version 1.0.4 which dropped the FPS. Could happen as EACH action button usage was trying to check if a skill needs a block with version 1.0.4. With version 1.0.5 it will only do this now IF any block was registered. But still, if the library is loaded it hacks into the actin buttons and always does some performance hungry tasks there.... So either version 1.0.5 speeds it up for you now, or the lib in total is slowing the game down. And I cannot change that without breaking the "block feature", so well, you need to live with it or disable it then (if version 1.0.5 does not fix it somehow for you already).
Last edited by Baertram : 04/13/23 at 12:34 PM.
|
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/14/23, 02:32 AM | ||
Forum posts: 0
File comments: 32
Uploads: 0
|
Re: FPS drop
I disabled all my addons and spent the last 4 hours re-enabling them one-by-one, and everything was smooth until I turned notnear's Skill Blocker back on. I verified it once more by turning off all addons except for Skill Blocker, and the frame drops are just as noticeable (there's a stutter about once every 1.5 seconds). I can observe this just by standing in my house and watching my Pearlescent orbs stutter as they go around The frame drops are more apparent (but always at regular 1.5s intervals) once I start running around. Finally, I downgraded LibSkillBlocker back to 1.0.4 and that resolved the frame drops immediately. PS - my fps technically never dipped below the usual level -- it just looks like frames are being dropped.
Last edited by hurry143 : 04/14/23 at 02:46 AM.
|
|
|
hurry143 |
View Public Profile |
Send a private message to hurry143 |
Send email to hurry143 |
Find More Posts by hurry143 |
Add hurry143 to Your Buddy List |
04/14/23, 03:38 AM | |||
|
Re: Re: FPS drop
Okay, thanks for the report.
This is weird, I'll downgrade the lib to 1.0.4 then and see what may cause this. To reproduce this I need some more details please: Do you need to cast any skills / press actin bar buttons as the frame drop happens or is it happening automatically without pressing any action bar button? Is it noticable with only the library enabled or do you need to enable the Skill Blocker addon too? As the frame drop happens: Do you have any blocked skill equipped on your action bar and which skill is blocked then in the Skill Blocker addon settings at your side? Could you maybe send me your SkillBlock addon settings file (logout and then check in folder live/SavedVariables/ ) via email to [email protected] Thank you!
|
||
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/14/23, 07:40 AM | |
Forum posts: 0
File comments: 32
Uploads: 0
|
I'll try sending you my saved variables in a bit. Thanks! |
|
hurry143 |
View Public Profile |
Send a private message to hurry143 |
Send email to hurry143 |
Find More Posts by hurry143 |
Add hurry143 to Your Buddy List |
04/14/23, 08:01 AM | ||
|
Thank you, that helps a lot to hopefully rebuild it on my side too.
Wondering why he frame drop could happen even withut any skill registered. I know there is code that does something to get the skill Id upon pressing any of the 5 action butons, or the ultimate one. But if you do not press anything, why should this drop frames then. Very weird, I think it's because of the addon Skill Blocker then which does something that is not really compatible with my version 1.0.5. Version 1.0.5 added even checks if ANY skill is blocked at all and does not do anything (it just should work as normal in that case) if you press any action button. I'll use your same settings to test this this weekend, thanks again.
|
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |