Go to Page... |
Compatibility: | Necrom (9.0.0) Scribes of Fate (8.3.5) Firesong (8.2.5) Lost Depths (8.1.5) High Isle (8.0.0) |
Updated: | 05/07/23 05:44 PM |
Created: | 12/11/20 03:03 AM |
Monthly downloads: | 1,066 |
Total downloads: | 95,725 |
Favorites: | 23 |
MD5: |
LibSkillBlocker.RegisterSkillBlock(addonName, abilityId, customBlockHandler, noErrorMessage) LibSkillBlocker.RegisterSkillBlock(addonName, abilityId)
LibSkillBlocker.UnregisterSkillBlock(addonName, abilityId)
LibSkillBlocker.GetRegisteredAbilityIds() -> {}[abilityId][addonName] = callback
LibSkillBlocker.GetRegisteredAbilityId(abilityId) -> {}[addonName] = callback
LibSkillBlocker.GetRegisteredAbilityIdsByAddon(addonName) -> {}[abilityIds] = callback
if (IsPlayerInAvAWorld() or IsActiveWorldBattleground()) then LibSkillBlocker.UnregisterSkillBlock("NoInnerLight", 40478) else LibSkillBlocker.RegisterSkillBlock("NoInnerLight", 40478) end
File Name |
Version |
Size |
Uploader |
Date |
1.0.7 |
2kB |
Baertram |
04/30/23 11:41 AM |
|
1.0.6 |
1kB |
Baertram |
04/14/23 03:40 AM |
|
1.0.5 |
2kB |
Baertram |
04/13/23 11:00 AM |
|
1.0.4 |
1kB |
Jarva |
12/20/21 08:04 PM |
|
1.0.3 |
1kB |
Jarva |
12/15/20 08:03 PM |
|
1.0.2 |
1kB |
Jarva |
12/14/20 01:01 AM |
|
1.0.1 |
1kB |
Jarva |
12/13/20 12:14 AM |
|
1.0.0 |
1kB |
12/11/20 03:03 AM |
Comment Options |
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
04/14/23, 10:04 AM | |
|
Yep, thanks guys.
I've checked the code of Skill Blocker and pin pointed this to the "blockRecast" feature. Do you have that one enabled too silentseashore, hurry143 got it enabled? Could you both disable this please and do a /reloadui and check if this fixes it? Notnear does some stuff in his code that ALWAYS was there and was wrong imo. He registeres and unresgsters ALL blocked skill every time each effect changes on you, nearby player, pets, companions, group mates. Even if buffs/effects update it will be done again. He did not add any filetrs to ONLY do this for "player" own casted buffs. That's why it always was laggy and performance wise a bad code, but with my recent changed and addition of extra checks like adding an assert that checks if the LibSkilBlocker.RegisterBock provides the correct values, it got even slower and now you notice it most probably because of that. I've written a "book" :-) to Notnear and showed him some ideas, also provided example coding. Maybe we can fix this somehow or at least imrpove it. For now use 1.0.6 please (which is the same as 1.0.4 version) and I might remove the assert or other coding if I find more reasons of slow downs. If you want to you can download this test version of "Skill Blocker" which I've prepared and see if it fixes the lags with LibSkillBlocker 1.0.5 for you, if "blockRecast" is enabled or disabled. Please also check if the features are still working properly, as the added filters on the player buffs might have added other problems. Skill Blocker Baertramwith event filters and LAM panel close callback And here is an updated version 1.0.7 of LibSkillBlocker with some more performance improvements. Hopefully it will fix the issues too somehow: LibSkillBlocker 1.0.7
Last edited by Baertram : 04/15/23 at 10:28 AM.
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/14/23, 10:47 AM | ||
Forum posts: 0
File comments: 11
Uploads: 0
|
I tried to download the test version but the dropbox URL gave me an Error 400. I'll try disabling the block-recast feature with 1.0.5 and test that out in the meantime.
Last edited by silentseashore : 04/14/23 at 10:48 AM.
|
|
|
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
04/14/23, 10:54 AM | |
|
I've updated the links below, seems (my) Dropbox got issues....
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/14/23, 11:57 AM | ||
Forum posts: 0
File comments: 11
Uploads: 0
|
Thanks! Updated links worked just fine
First of all, let me preface by saying that I confirmed and my SkillBlocker 'Toggle Block Recast' setting (found at the top of the addon menu) was always set to 'on' and I never changed it before. Here's a result of my testing: 1.0.6 (same as 1.0.4) ===================== Toggle block recast ON: No FPS drops, no stuttering Toggle block recast OFF: No FPS drops, no stuttering 1.0.5 ===================== Toggle block recast ON: Immediate stuttering. Character would freeze periodically. I cast flames of oblivion on my DK and saw the fireball floating and stuttering near my character. My FPS would also tank during this time (going from 80 to 10 in an instant) but this could be a separate issue since hurry143 didn't seem to encounter actual frames dropping. It could also be related to the stuttering wherein my system is not optimized to not cause frame drops when stuttering happens. But regardless, performance drop was immediate and noticeable. Toggle block recast OFF: Didn't encounter FPS drop after running around and zoning in and out for ~10 min. I believe this could be the culprit as you suggested. 1.0.7 ===================== Toggle block recast ON: I was actually encountering stuttering on this version as well. I roamed around a bit and confirmed this just to be sure that it's not being caused by something else. Toggle block recast OFF: No FPS drops, no stuttering As it stands right now, 1.0.6/1.0.4 seems to be the only version where stuttering is not seen on EITHER toggles of 'Block Recast'. I'll be using THIS version for the meantime. I hope hurry143 could provide his own insights so you have more data to compare Let me know if I can do any further testing. Thanks for all the help and effort!
Last edited by silentseashore : 04/14/23 at 11:58 AM.
|
|
|
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
04/14/23, 01:14 PM | |||
|
Thanks for the Feedback.
Was the stuttering on 1.0.7 less than with 1.0.5 at least? I wonder why that's such a "big" thing, as I did not change too much. But still, the stuff updates on EACH player buff and that's quite often, if the cast block is enabled. In my jhonest opinion this was implemented somehow wrong/not optimized in "Skill Block" addon so far. for me it looks like it will try to add blocks and remove, and add again, and remove way too often. And that adds the stutter then. One did just not notice it that hard before. I'll need to restest it myself and remove some fixes I had added. Hopefully it's only the assert stuff I added which causes this "visible/noticable stutter" now.
|
||
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/14/23, 04:50 PM | ||||
Forum posts: 0
File comments: 11
Uploads: 0
|
So I did a bit more testing with 1.0.7. The stuttering on 1.0.7 seems very periodic but very very noticeable. I remember hurry143 saying that the interval he experienced was 1.5 seconds. Though I couldn't time it that exactly, it seems to be the same for me as well.
With 1.0.7 - it was like this: fine..fine...STUTTER..fine...fine...STUTTER... Does that help?
|
|||
|
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
04/14/23, 05:16 PM | |||||
|
I actually don't know yet. Have not noticed it so far :-(
Maybe it's my GSYNC monitor preventing me to see the stutters. But I'v talked to the author of Skill Blocker and found a lot of palces where we could imporve the overall performance of this addon, and I bet I need to improve the library too. I think best will be that I prepare you guys 2 beta versions of the lib, one with only a few lines removed and another with some other lines removed (for both, which I had addded after version 1.0.4). So I can better track down which lines cause that stutter for you.
|
||||
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
04/28/23, 07:39 PM | |
Hi folks,
I see between notnear's Skill Blocker and this LibSkillBlocker that you are working out how to optimize this capability. I hope you don't mind if I ask is there a functioning version of this addon at the moment? Or are kinks still being worked out? Thanks! |
|
|
julivity |
View Public Profile |
Send a private message to julivity |
Send email to julivity |
Find More Posts by julivity |
Add julivity to Your Buddy List |
04/29/23, 02:43 AM | |
|
Yes, it should function well now.
Notnear did update Skill Blocker to version 2.0.3 as I can see and LibSkillBlocker was tested with it with version 1.0.6 (which basically is the older 1.0.4) and 1.0.7 (not released yet). Feel free to use the lib and the addon. If you experience any performance loss or problems please reach out to me and notnear so we can work on further updates. |
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |