Go to Page... |
Compatibility: | Necrom (9.0.0) Scribes of Fate (8.3.5) Firesong (8.2.5) Lost Depths (8.1.5) High Isle (8.0.0) |
Updated: | 05/07/23 05:44 PM |
Created: | 12/11/20 03:03 AM |
Monthly downloads: | 1,018 |
Total downloads: | 94,356 |
Favorites: | 23 |
MD5: |
LibSkillBlocker.RegisterSkillBlock(addonName, abilityId, customBlockHandler, noErrorMessage) LibSkillBlocker.RegisterSkillBlock(addonName, abilityId)
LibSkillBlocker.UnregisterSkillBlock(addonName, abilityId)
LibSkillBlocker.GetRegisteredAbilityIds() -> {}[abilityId][addonName] = callback
LibSkillBlocker.GetRegisteredAbilityId(abilityId) -> {}[addonName] = callback
LibSkillBlocker.GetRegisteredAbilityIdsByAddon(addonName) -> {}[abilityIds] = callback
if (IsPlayerInAvAWorld() or IsActiveWorldBattleground()) then LibSkillBlocker.UnregisterSkillBlock("NoInnerLight", 40478) else LibSkillBlocker.RegisterSkillBlock("NoInnerLight", 40478) end
File Name |
Version |
Size |
Uploader |
Date |
1.0.7 |
2kB |
Baertram |
04/30/23 11:41 AM |
|
1.0.6 |
1kB |
Baertram |
04/14/23 03:40 AM |
|
1.0.5 |
2kB |
Baertram |
04/13/23 11:00 AM |
|
1.0.4 |
1kB |
Jarva |
12/20/21 08:04 PM |
|
1.0.3 |
1kB |
Jarva |
12/15/20 08:03 PM |
|
1.0.2 |
1kB |
Jarva |
12/14/20 01:01 AM |
|
1.0.1 |
1kB |
Jarva |
12/13/20 12:14 AM |
|
1.0.0 |
1kB |
12/11/20 03:03 AM |
![]() |
Comment Options |
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
julivity |
View Public Profile |
Send a private message to julivity |
Find More Posts by julivity |
Add julivity to Your Buddy List |
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
||||
Forum posts: 0
File comments: 11
Uploads: 0
|
So I did a bit more testing with 1.0.7. The stuttering on 1.0.7 seems very periodic but very very noticeable. I remember hurry143 saying that the interval he experienced was 1.5 seconds. Though I couldn't time it that exactly, it seems to be the same for me as well.
With 1.0.7 - it was like this: fine..fine...STUTTER..fine...fine...STUTTER... Does that help?
|
|||
![]() |
![]() |
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
![]() |
|||
|
Thanks for the Feedback.
Was the stuttering on 1.0.7 less than with 1.0.5 at least? I wonder why that's such a "big" thing, as I did not change too much. But still, the stuff updates on EACH player buff and that's quite often, if the cast block is enabled. In my jhonest opinion this was implemented somehow wrong/not optimized in "Skill Block" addon so far. for me it looks like it will try to add blocks and remove, and add again, and remove way too often. And that adds the stutter then. One did just not notice it that hard before. I'll need to restest it myself and remove some fixes I had added. Hopefully it's only the assert stuff I added which causes this "visible/noticable stutter" now.
|
||
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
||
Forum posts: 0
File comments: 11
Uploads: 0
|
Thanks! Updated links worked just fine
![]() First of all, let me preface by saying that I confirmed and my SkillBlocker 'Toggle Block Recast' setting (found at the top of the addon menu) was always set to 'on' and I never changed it before. Here's a result of my testing: 1.0.6 (same as 1.0.4) ===================== Toggle block recast ON: No FPS drops, no stuttering Toggle block recast OFF: No FPS drops, no stuttering 1.0.5 ===================== Toggle block recast ON: Immediate stuttering. Character would freeze periodically. I cast flames of oblivion on my DK and saw the fireball floating and stuttering near my character. My FPS would also tank during this time (going from 80 to 10 in an instant) but this could be a separate issue since hurry143 didn't seem to encounter actual frames dropping. It could also be related to the stuttering wherein my system is not optimized to not cause frame drops when stuttering happens. But regardless, performance drop was immediate and noticeable. Toggle block recast OFF: Didn't encounter FPS drop after running around and zoning in and out for ~10 min. I believe this could be the culprit as you suggested. 1.0.7 ===================== Toggle block recast ON: I was actually encountering stuttering on this version as well. I roamed around a bit and confirmed this just to be sure that it's not being caused by something else. Toggle block recast OFF: No FPS drops, no stuttering As it stands right now, 1.0.6/1.0.4 seems to be the only version where stuttering is not seen on EITHER toggles of 'Block Recast'. I'll be using THIS version for the meantime. I hope hurry143 could provide his own insights so you have more data to compare ![]() Let me know if I can do any further testing. Thanks for all the help and effort!
Last edited by silentseashore : 04/14/23 at 11:58 AM.
|
|
![]() |
![]() |
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
![]() |
|
|
I've updated the links below, seems (my) Dropbox got issues....
|
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
||
Forum posts: 0
File comments: 11
Uploads: 0
|
I tried to download the test version but the dropbox URL gave me an Error 400. I'll try disabling the block-recast feature with 1.0.5 and test that out in the meantime.
Last edited by silentseashore : 04/14/23 at 10:48 AM.
|
|
![]() |
![]() |
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
![]() |
|
|
Yep, thanks guys.
I've checked the code of Skill Blocker and pin pointed this to the "blockRecast" feature. Do you have that one enabled too silentseashore, hurry143 got it enabled? Could you both disable this please and do a /reloadui and check if this fixes it? Notnear does some stuff in his code that ALWAYS was there and was wrong imo. He registeres and unresgsters ALL blocked skill every time each effect changes on you, nearby player, pets, companions, group mates. Even if buffs/effects update it will be done again. He did not add any filetrs to ONLY do this for "player" own casted buffs. That's why it always was laggy and performance wise a bad code, but with my recent changed and addition of extra checks like adding an assert that checks if the LibSkilBlocker.RegisterBock provides the correct values, it got even slower and now you notice it most probably because of that. I've written a "book" :-) to Notnear and showed him some ideas, also provided example coding. Maybe we can fix this somehow or at least imrpove it. For now use 1.0.6 please (which is the same as 1.0.4 version) and I might remove the assert or other coding if I find more reasons of slow downs. If you want to you can download this test version of "Skill Blocker" which I've prepared and see if it fixes the lags with LibSkillBlocker 1.0.5 for you, if "blockRecast" is enabled or disabled. Please also check if the features are still working properly, as the added filters on the player buffs might have added other problems. Skill Blocker Baertramwith event filters and LAM panel close callback And here is an updated version 1.0.7 of LibSkillBlocker with some more performance improvements. Hopefully it will fix the issues too somehow: LibSkillBlocker 1.0.7
Last edited by Baertram : 04/15/23 at 10:28 AM.
|
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
|||
Forum posts: 0
File comments: 11
Uploads: 0
|
Re: Re: FPS drop
My apologies, I wasn't able to reply to this yesterday, and wanted to get as many details as possible to you today, but looks like hurry143 beat me to it
![]() The reason why the 'while' was so short is that, since I play with high latency and that too from a gaming laptop, I keep a close eye on my addons and libraries. So if I notice something awry, I can pinpoint it pretty quickly (~5 min). Anyway, looks like hurry143 provided all the added info I could have provided! I can second everything he listed out. I hope you're able to figure out the issue!
|
||
![]() |
![]() |
silentseashore |
View Public Profile |
Send a private message to silentseashore |
Send email to silentseashore |
Find More Posts by silentseashore |
Add silentseashore to Your Buddy List |
![]() |
||
|
Thank you, that helps a lot to hopefully rebuild it on my side too.
Wondering why he frame drop could happen even withut any skill registered. I know there is code that does something to get the skill Id upon pressing any of the 5 action butons, or the ultimate one. But if you do not press anything, why should this drop frames then. Very weird, I think it's because of the addon Skill Blocker then which does something that is not really compatible with my version 1.0.5. Version 1.0.5 added even checks if ANY skill is blocked at all and does not do anything (it just should work as normal in that case) if you press any action button. I'll use your same settings to test this this weekend, thanks again.
|
|
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
|
Forum posts: 0
File comments: 32
Uploads: 0
|
I'll try sending you my saved variables in a bit. Thanks! |
![]() |
![]() |
hurry143 |
View Public Profile |
Send a private message to hurry143 |
Send email to hurry143 |
Find More Posts by hurry143 |
Add hurry143 to Your Buddy List |
![]() |
|||
|
Re: Re: FPS drop
Okay, thanks for the report.
This is weird, I'll downgrade the lib to 1.0.4 then and see what may cause this. To reproduce this I need some more details please: Do you need to cast any skills / press actin bar buttons as the frame drop happens or is it happening automatically without pressing any action bar button? Is it noticable with only the library enabled or do you need to enable the Skill Blocker addon too? As the frame drop happens: Do you have any blocked skill equipped on your action bar and which skill is blocked then in the Skill Blocker addon settings at your side? Could you maybe send me your SkillBlock addon settings file (logout and then check in folder live/SavedVariables/ ) via email to [email protected] Thank you!
|
||
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
||
Forum posts: 0
File comments: 32
Uploads: 0
|
Re: FPS drop
I disabled all my addons and spent the last 4 hours re-enabling them one-by-one, and everything was smooth until I turned notnear's Skill Blocker back on. I verified it once more by turning off all addons except for Skill Blocker, and the frame drops are just as noticeable (there's a stutter about once every 1.5 seconds). I can observe this just by standing in my house and watching my Pearlescent orbs stutter as they go around ![]() Finally, I downgraded LibSkillBlocker back to 1.0.4 and that resolved the frame drops immediately. PS - my fps technically never dipped below the usual level -- it just looks like frames are being dropped.
Last edited by hurry143 : 04/14/23 at 02:46 AM.
|
|
![]() |
![]() |
hurry143 |
View Public Profile |
Send a private message to hurry143 |
Send email to hurry143 |
Find More Posts by hurry143 |
Add hurry143 to Your Buddy List |
![]() |
||
|
Re: FPS drop
This library was updated today, 1h ago (~7pm). So are you sure this is the issue for your FPS drops? Not if "since last update" means since lsat ESO patches ![]() I did not realize any drops within 2 weeks of testing and usage so far? If this took "a while for you to pinpoint it" your while would have been 10 minutes or less, as the update 1.5 was done today as I said! ![]() -> And I'd especially know "how did you manage" to pinpoint it to this library with version 1.0.5? What did you test, and when did you test this, so that you came to this conclusion? Could you do me the favor and provide me any proof for that, so I can work on it. What addons do you use that use this lirary here? Try to use SAME addons and libraries and ONLY replace version 1.0.5 with 1.0.4 from here, and do the same things, and check your FPS then. For me it never had any noticably difference at all, but maybe it depends on the addons used in combination with this library. Maybe it was version 1.0.4 which dropped the FPS. Could happen as EACH action button usage was trying to check if a skill needs a block with version 1.0.4. With version 1.0.5 it will only do this now IF any block was registered. But still, if the library is loaded it hacks into the actin buttons and always does some performance hungry tasks there.... So either version 1.0.5 speeds it up for you now, or the lib in total is slowing the game down. And I cannot change that without breaking the "block feature", so well, you need to live with it or disable it then (if version 1.0.5 does not fix it somehow for you already).
Last edited by Baertram : 04/13/23 at 12:34 PM.
|
|
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |