Download
(11 Kb)
Download
Updated: 05/04/14 08:50 PM
Pictures
File Info
Compatibility:
Live (1.0)
Updated:05/04/14 08:50 PM
Created:04/22/14 05:38 AM
Monthly downloads:22
Total downloads:11,446
Favorites:59
MD5:
FatStacks  Popular! (More than 5000 hits)
Version: 0.1.6
by: snare [More]
FatStacks is an add-on for re-stacking items in your guild bank that are inefficiently stacked.

If items are deposited into the guild bank that already exist in the guild bank, they will not be automatically stacked. This results in multiple small stacks of things like runes and alchemy mats, of which there are many different kinds that are often only encountered in small numbers and deposited into the guild bank one at a time. FatStacks addresses this problem by finding items that are using more slots than necessary, withdrawing them into your backpack, re-stacking them to take up fewer slots, and then depositing them back into the guild bank.

This is a beta release of FatStacks. At the moment it only supports some slash commands and has no real UI to speak of. Output is printed to the chat window.

To get help on running FatStacks, use the following command:

/fs

To get info on what is inefficiently stacked in the guild bank, open the guild bank and then run:

/fs info

To re-stack items in the guild bank that are inefficiently stacked, open the guild bank and then run:

/fs restack

To reset FatStacks in the event of an error, run:

/fs reset

FatStacks is hosted on Github and issues and feature requests can be raised here. Feel free to fork it and submit a pull request!

The changelog for the current version is located here.

If anyone wants to donate some ESO gold, mail it to Drangus on the US servers or feel free to send some Bitcoin to 12S7fFpku5TCTLmqfMh9R5Mn5Vu5rzNCux
Archived Files (6)
File Name
Version
Size
Uploader
Date
0.1.5
11kB
snare
05/01/14 09:55 PM
0.1.4
11kB
snare
05/01/14 03:41 AM
0.1.3
11kB
snare
05/01/14 02:08 AM
0.1.2
6kB
snare
04/24/14 10:39 AM
0.1.1
6kB
snare
04/24/14 04:29 AM
0.1
4kB
04/22/14 05:38 AM


Post A Reply Comment Options
Unread 05/05/14, 06:56 AM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Re: Re: Re: Re: Re: Re: Re: Re: Breaks on alts.

Yeah I only discovered that was a thing when someone looked at my code and told me I was doing bad things. Hence all the functions in my code now being prefixed with a table "SN_FS.Whatever()". You can also declare them as locals so they're file-scoped. So used to default module scope in python I guess that's the kind of sacrifice you make for a tiny embedded language.
Last edited by snare : 05/05/14 at 06:57 AM.
Report comment to moderator  
Reply With Quote
Unread 05/05/14, 04:56 AM  
Commenter

Forum posts: 2
File comments: 6
Uploads: 0
Re: Re: Re: Re: Re: Re: Re: Re: Breaks on alts.

Originally Posted by snare
Yeah basically all the functions and globals from each lib are loaded into the global namespace,
Brrh, what a design - I can already see the maintenance nightmare once people start to have differing versions of helper libraries in different addon folders, everything loading in random (?) order... Or someone writing their own functions with the same names... yeah, good times will follow. :P
Report comment to moderator  
Reply With Quote
Unread 05/04/14, 08:52 PM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Re: Re: Re: Re: Re: Re: Re: Breaks on alts.

OK new version (0.1.6) should fix this, and I also changed the stacking behaviour so that items that are already in your bag are not deposited into the guild bank (ie. if you have pots and you restack the same pots from the GB, the pots in your backpack don't get stacked in with the rest).
Report comment to moderator  
Reply With Quote
Unread 05/04/14, 08:31 PM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Re: Re: Re: Re: Re: Re: Breaks on alts.

Yeah basically all the functions and globals from each lib are loaded into the global namespace, so it was just working for everyone because they already had other copies of LibStub already loaded :|

Thanks!
Report comment to moderator  
Reply With Quote
Unread 05/04/14, 08:30 AM  
Commenter

Forum posts: 2
File comments: 6
Uploads: 0
Re: Re: Re: Re: Re: Re: Breaks on alts.

Originally Posted by snare
Can you try something for me? Open FatStacks.txt inside the addon and switch the loading order of:

lib/LibAddonMenu-1.0.lua
lib/LibStub.lua

to:

lib/LibStub.lua
lib/LibAddonMenu-1.0.lua

And try again.
I actually managed to reproduce the bug on the other dummy characters too - I hadn't realized that other addons got automatically enabled on them - disabling everything else made all of the characters throw the same errors. Looking into it further, I saw that enabling another addon with the same libraries (libstub and libaddonmenu) allowed FatStacks to also load without error - so I guess libraries are somehow SHARED between addons :O Feels a bit weird, like global namespace taints or sth. [The other addon I tested this with was Roomba.)

Then I checked changing those lines you mentioned around, and everything works for all characters. So the order of the called libraries needs to be stub -> addonmenu, looks like.
Report comment to moderator  
Reply With Quote
Unread 05/03/14, 08:21 PM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Re: Re: Re: Re: Breaks on alts.

Can you try something for me? Open FatStacks.txt inside the addon and switch the loading order of:

lib/LibAddonMenu-1.0.lua
lib/LibStub.lua

to:

lib/LibStub.lua
lib/LibAddonMenu-1.0.lua

And try again.
Report comment to moderator  
Reply With Quote
Unread 05/03/14, 08:48 AM  
Commenter

Forum posts: 2
File comments: 6
Uploads: 0
Re: Re: Re: Re: Breaks on alts.

Originally Posted by snare
That is very strange. 0.1.3 is also when I added the settings menu with LibAddOnMenu and LibStub - looks like it's failing initialising LibStub for some reason (which explains why 0.1.2 still works). It could be related to your character name as you suggest - maybe try creating a new toon with a dummy (but plain ASCII) name and see if it still fails?
I did a few test chars, both with simple characters and one with hyphens of the same format as the problem character (XXXX-XXXX-XXX) and NEITHER of these have the issue. Logged back on the original culprit - error messages again. The savedvariables grows in identical blocks for each character, except on this one character, always failing to load. No other addons enabled.

I can't think of what the difference between the characters could be. The bugging char is just a lvl 3 straight-out-of-creation into bank, and some extracting experience gathered.
Report comment to moderator  
Reply With Quote
Unread 05/02/14, 09:53 PM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Re: Re: Breaks on alts.

That is very strange. 0.1.3 is also when I added the settings menu with LibAddOnMenu and LibStub - looks like it's failing initialising LibStub for some reason (which explains why 0.1.2 still works). It could be related to your character name as you suggest - maybe try creating a new toon with a dummy (but plain ASCII) name and see if it still fails?
Last edited by snare : 05/02/14 at 09:54 PM.
Report comment to moderator  
Reply With Quote
Unread 05/02/14, 09:26 AM  
Commenter

Forum posts: 2
File comments: 6
Uploads: 0
Re: Re: Breaks on alts.

Originally Posted by snare
Originally Posted by Commenter
The latest update stopped FatStacks working on alts, getting indexing nil on addon init, I tried to fix it by editing the savedvariables but it resets to the data of one character only (leaving alts with disabled addon.).
0.1.3 was broken but I updated it to 0.1.4 straight after. I suspect you are on 0.1.3.
Negative. The same problem persists in 0.1.5, and disappears when downgrading to 0.1.2.

Works perfectly on main, when switching to an alt it fails to load with the error messages:

2014-05-02T18:07:29.040+02:00 |cff0000Lua Error: user:/AddOns/FatStacks/lib/LibAddonMenu-1.0.lua:2: attempt to index a nil value
stack traceback:
user:/AddOns/FatStacks/lib/LibAddonMenu-1.0.lua:2: in function '(main chunk)'|r
2014-05-02T18:07:29.042+02:00 |cff0000Lua Error: user:/AddOns/FatStacks/lib/LibStub.lua:27: function expected instead of nil
stack traceback:
user:/AddOns/FatStacks/lib/LibStub.lua:27: in function 'LibStub:GetLibrary'
user:/AddOns/FatStacks/FatStacks_Config.lua:9: in function '(main chunk)'|r
2014-05-02T18:07:29.115+02:00 |cff0000Lua Error: user:/AddOns/FatStacks/FatStacks.lua:458: function expected instead of nil
stack traceback:
user:/AddOns/FatStacks/FatStacks.lua:458: in function 'SN_FS.OnAddOnLoaded'|r
No other addons enabled.

SavedVariables file contains (with account and char name cleaned)

Code:
SN_FS_SavedVariables =
{
    ["Default"] = 
    {
        ["@account"] = 
        {
            ["charname"] = 
            {
                ["SN_FS"] = 
                {
                    ["debug"] = false,
                    ["version"] = 1,
                    ["stack_on_insert"] = false,
                    ["configVersion"] = 1,
                },
            },
        },
    },
}
More info: ok this got weird. I deleted the savedvariable file, deleted all FatStacks files and reinstalled, and tried logging to my alt 1st - same errors occurred! Whereas then logging to my main - no errors again. Can it be a case of something getting mungled with character name handling? My alt has several hyphens in her name, argonian style - does that break something?

Again, downgrading to 0.1.2 makes everything work correctly. 0.1.4 and 0.1.5 fail to load with those same errors.
Report comment to moderator  
Reply With Quote
Unread 05/02/14, 07:38 AM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Excellent I've still had a few instances of the timing issue occur since then, but they've been very rare. Hopefully the slight delay after stacking and before depositing will take care of those.
Report comment to moderator  
Reply With Quote
Unread 05/02/14, 07:21 AM  
Fakrae

Forum posts: 0
File comments: 4
Uploads: 0
This timing-issue was fixed for me the moment you stopped taking full stacks already!
stacked a full bank with about 60 mis-stacked items yesterday without a single failure.

Great work! I really like it and it works like a charm now.
Report comment to moderator  
Reply With Quote
Unread 05/02/14, 05:19 AM  
Possum63

Forum posts: 0
File comments: 2
Uploads: 0
Thumbs up Love this!

My wife and I can't thank you enough! We spent WAY too much time re-stacking the guild bank. Great addon! Keep it up!
Report comment to moderator  
Reply With Quote
Unread 05/01/14, 10:00 PM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Re: Breaks on alts.

In 0.1.5 I may have fixed the timing issue (though I don't like the fix, and it slows the addon down slightly). I borrowed it from Wobin's new Roomba addon - basically putting a slight delay before the first item deposit each time. I guess maybe stacking isn't an issue and it's just that first deposit that fails.
Report comment to moderator  
Reply With Quote
Unread 05/01/14, 09:03 PM  
snare
AddOn Author - Click to view AddOns

Forum posts: 14
File comments: 35
Uploads: 1
Re: Breaks on alts.

Originally Posted by Commenter
The latest update stopped FatStacks working on alts, getting indexing nil on addon init, I tried to fix it by editing the savedvariables but it resets to the data of one character only (leaving alts with disabled addon.).
0.1.3 was broken but I updated it to 0.1.4 straight after. I suspect you are on 0.1.3.
Report comment to moderator  
Reply With Quote
Unread 05/01/14, 10:44 AM  
Commenter

Forum posts: 2
File comments: 6
Uploads: 0
Breaks on alts.

The latest update stopped FatStacks working on alts, getting indexing nil on addon init, I tried to fix it by editing the savedvariables but it resets to the data of one character only (leaving alts with disabled addon.).
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: