My personal addon for quest sharing, alt account functionality, and others.
1.5
Added feature in 01_DIALOGUE/00_DialogueSkipper.lua to allow saving names and locations to the skip list. You can now specify an NPC in a particular location to skip. If you see the NPC anywhere else, they won't be skipped.
Daily Quest givers will be automatically added to this list whenever the player accepts a daily quest from them for the first time.
1.4
Added check 02_QUESTING/DailyQuestHandler.lua CompleteDailyQuest() to ensure only zones that exist in MAIN.accountVariables.dailyQuests were being looked at.
Added "/alttrade" command into alt system. Can now type into chat instead of searching for alt.
Added automatic trade accept when alt invites you to trade.
1.3
Added in-game command for Quest ID search based on quest name in 02_QUESTING/QuestHandler.lua
1.2
Updated 02_QUESTING/DailyQuestHandler.lua to only display uncompleted daily quests when a daily quest has just been completed instead of whenever any quest is completed
if you release an addon to the public at esoui we need to know what it does, features etc.
Please describe more at the description page or remove the addon if it's only a local addon for yourself.
Thanks for your understanding.
Also:
Please do NOT name your SavedVariables table "SavedVariables" !!!
Add your addon name as a prefix or similar but do not use any simple non.unique name here else other addons might get into trouble as they define a same name for a local variable, and your global overwrites it then.
e.g. LMPAdventurerToolkit_SV or LMPAdventurerToolkit_SavedVariables will do
Additionaly do NOT create global variables called "MAIN", "DAILY_RESET" or similar, please!
They are non.unique and predestinated to break other addons
CRITICAL PROBLEM:
Code:
SOUNDS = {}
SOUNDS is a global variable that ESO uses already and it contans all sounds needed so you are overwriting it here destroying other addons AND the ESO game that way
Best practice:
Add 1 global variable e.g.
Lua Code:
LMPAdventurerToolkit ={}
--Add a local at the top of your file to speed up the reference to the global table as else the global table _G will be searched in total each time you need to find the subtable LMPAdventurerToolkit
local lmp = LMPAdventurerToolkit
--and then add subtales like
lmp.MAIN ={}
lmp.DAILY_RESET ={}
lmp.SOUNDS ={}
...
and then reference these subtables in your files and not any global for each file, especially not a global like MAIN or similar.
At the top of each of your files add:
Lua Code:
local LMP = LMPAdventurerToolkit
And then use and work with lmp and lmp.MAIN etc.
Other issues:
Your files leak a lot of variables to the global mainspace :-(
Example: Main.lua
Code:
counter = 0
-> Here is missing the local in front of counter so it is defined global and thus _G["counter"] exists and will overwrite ALL other addons locals with the same name ->
You even destroy your own file DailyResetCalculator as you use counter in that file too within function ResetSystems...
It's also missing the local
Please check all your files for missing local definitions and fix that too.
You can use an IDE to control that e.g. and support you there, or the addon of Votan here: https://www.esoui.com/downloads/info...pollution.html