Go to Page... |
Compatibility: | Firesong (8.2.5) Lost Depths (8.1.5) High Isle (8.0.0) Ascending Tide (7.3.5) Deadlands (7.2.5) Waking Flame (7.1.5) Blackwood (7.0.5) Greymoor (6.0.5) |
Updated: | 11/28/22 03:26 PM |
Created: | 11/16/22 10:52 PM |
Monthly downloads: | 73 |
Total downloads: | 3,235 |
Favorites: | 2 |
MD5: | |
Categories: | PvP, Combat Mods |
Comment Options |
11/17/22, 11:23 AM | |
|
https://www.esoui.com/downloads/info...Alchemist.html
-> https://www.esoui.com/downloads/info...istHelper.html I've connected your addon to the other files of the original addon, please keep an eye on that in the future so users will find addons more easily if they base on each other, or are patches of other addons. Hello Xorzoo, I just noticed your new addon is based on an existing addon. But you did not tell in the description if the author allowed you to create a new addon "with a new name", based on his addon? Did he allow you to do so? Having a GitHub repo does not automatically allow you to release the same code, even if you add fixes, under a totally new name! Check if licensing prohibits this AND if the author is okay with that. Else ask him if you can take over or if he allows to add you to the original addon's team so you can fix it officially (but keeping the original name). If you only fixed the old addon please release it with the "same name", just add "Updated" or "Fixed" behind so one can find it more easily in Minion AND release it as a patch of the original addon please (if the author enabled that at the "Other files" of that addon: -> I've connected them for you now. Else , if you have not asked the author yet, please read here: https://www.esoui.com/forums/showthread.php?t=9865 e.g. ask the author for permission to copy his addon with a new name and wait for at least a few weeks to get a response from the original authors. Thanks for respecting this, clarify this with the author and if he is okay provide me the okay from him please. If he is not okay with that please remove your addon and release it as a patch to the original addon, without changing the addon's folder and filenames, as described above! Feel free to add your name to the author tag inside the addon's txt/lua files, but keep the old devs in there too please! BR Baertram |
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
11/17/22, 09:23 PM | ||
|
I have sent the original author a message as requested, but I don't change a line and release it as a new addon, do a diff and see what is actually going on. For example: Fixed one hand/shield not working Fixed potion detection failed due to API changes, Fixed gear detection failed likely due to API changes as well, Fixed pvp only mode New Feature: added in-combat only mode, New Feature: added reticle toggle New Feature: added profile management A good potion of the code has been rewritten/refac There is no working clever alchemist helper working with the current version, that is why I made this one based on a two years old broken addon, but I have zero issue take it down and enjoy it just for myself. |
|
|
Xorzoo |
View Public Profile |
Send a private message to Xorzoo |
Send email to Xorzoo |
Find More Posts by Xorzoo |
Add Xorzoo to Your Buddy List |
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
11/18/22, 10:50 AM | ||||
|
But rule are rules.
I saw you wrote addon yourself so you probably know this already, all those addons are pretty much using the same code at core. Is that because they copy each other with new name or because this is exactly how ZOS allows to interact with game client?
|
|||
|
Xorzoo |
View Public Profile |
Send a private message to Xorzoo |
Send email to Xorzoo |
Find More Posts by Xorzoo |
Add Xorzoo to Your Buddy List |
11/18/22, 01:24 PM | ||
|
But the addon code that will be created is personal property of the respective persons. You cannot just copy anything and provide a new name, even though you might have fixed or added stuff yourself. It does not matter if you think/know the code was broken and you fixed it. You need to keep the names, and provide credit if you copy something. And you need to ask for permissions as this is "intellectual property" (unless the developer has explicitly allowed up in advance by writing this to the addon files, comments, documentation, wiki, github repo etc.). Just beause something is globally accessible it does not mean you have the right to touch and use it. Would you open the door of a parked car, if it was forgotten to be locked, and change the settings of that car, maybe even remove some parts and add your own cosy seat pad, and afterwards drive around with it as you "say it is yours now"? Maybe not the best example but it should explain what one would/should not do Let's wait for the addon dev feedback and if there is none just keep it. For the next time please just respect this in advance OR just keep the name and add soemthing like "Updated" / "Fixed" to the end, if you cannot contact the original dev and ask for maintenance/addition to the original addon team. This always is easier as it keeps the users and unstresses updates.
Last edited by Baertram : 11/18/22 at 01:27 PM.
|
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
11/18/22, 03:58 PM | |||||
|
it is not intended to be backward compatible with old addon, it is never meant to be a fix/patch. I have no intention migrating whatever the data struct or saved vars from previous addon. If I ever want to publish it I have no desire to investigate and communicate whatever you might need to do to make it work if you have an old addon installed. No disrespect to anyone, it was for my convenience. I am used to how it works in github: when I fork, I fork and give credits and such, I do whatever makes sense to me in my own fork, since no license says I cannot. If I am trying to take over the ownership of existing github repo, I ask the owner of course.
|
||||
|
Xorzoo |
View Public Profile |
Send a private message to Xorzoo |
Send email to Xorzoo |
Find More Posts by Xorzoo |
Add Xorzoo to Your Buddy List |
02/24/23, 07:46 AM | |
Forum posts: 0
File comments: 22
Uploads: 0
|
Arkasis
Hey, im currently using your addon to block potions for arkasis genius in some trashsetups.
it works like a charm. i was wondering if you would like to integrate arkasis support in the future. if so ids are as follows. Arkasis Setid 518 Arkasis Abilityid 142660 30 sec cooldown and thank you a lot for making the potionblocker work again. have a nice weekend. |
|
Busygeezus |
View Public Profile |
Send a private message to Busygeezus |
Send email to Busygeezus |
Find More Posts by Busygeezus |
Add Busygeezus to Your Buddy List |
06/17/23, 03:47 PM | |
|
Hi, I'm the author of the OG potion blocker add-on. Just logged in for the first time since 2020 and I'm delighted to see someone picked it up and people still using it. Just in case, consider my addon to be licensed under WTFPL , anyone's permitted to do whatever with that code.
|
|
adjutant |
View Public Profile |
Send a private message to adjutant |
Send email to adjutant |
Find More Posts by adjutant |
Add adjutant to Your Buddy List |