Go to Page... |
Compatibility: | Scribes of Fate (8.3.5) Firesong (8.2.5) |
Updated: | 02/07/23 02:57 PM |
Created: | 12/15/22 11:26 AM |
Monthly downloads: | 45 |
Total downloads: | 2,390 |
Favorites: | 1 |
MD5: |
File Name |
Version |
Size |
Uploader |
Date |
v0.69420 |
3kB |
SimpsForBreda |
12/20/22 09:12 PM |
|
v0.69 |
3kB |
12/15/22 11:26 AM |
![]() |
Comment Options |
![]() |
|||
|
No problem, thanks for considering this.
If you need help write me a pm and send me a link to your changed files before upload, and I'll gladly check them and help you.
|
||
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |
||
|
OK, thank you for the constructive feedback, it's much appreciated! ![]() I'll try my best to implement these changes to be a good add-on citizen, but as you may have inferred, I'm not a great coder and have minimal experience with Lua. |
|
![]() |
![]() |
SimpsForBreda |
View Public Profile |
Send a private message to SimpsForBreda |
Find More Posts by SimpsForBreda |
Add SimpsForBreda to Your Buddy List |
![]() |
|
|
Hello and welcome to addon creation.
Your addon's txt file is using an outdated APIversion and thus shows outdated from the start. Code:
## APIVersion: 100035 https://wiki.esoui.com/APIVersion#live_API_version or ingame via chat script: Code:
/script d(GetAPIVersion()) Thank you. And in your addon's EVENT_ADD_ON_LOADED callback function you should always unregister the same event after it was run for your addon, as else the same code will be executed for EACH other enabled addon too! Lua Code:
Also very important: Your addon is leaking variables to the global namespace, e.g. zethText Please define that local at the start of your file OR even better: Add it to your global table BredaExp instead! BredaExp.zethText = "" And then always use BredaExp.zethText in your code instead of only zethText Else it will be added to the global table _G and pollute this, where it is not needed anywhere else as in your 1 file BredaExp.lua and could be locally defned thus. Also a best practice would be to NOT define the function name BredaExpTimeRemaining but instead add it to BredaExp.TimeRemaining so it's all connected to your 1 global table BredaExp, and not creating "unconnected" functions and variables here and there.
Last edited by Baertram : 12/21/22 at 02:46 AM.
|
![]() |
![]() |
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |
![]() |