Download
(39 Kb)
Download
Updated: 10/31/23 07:27 AM
Patch for:
No, thank you!.
Compatibility:
Endless Archive (9.2.5)
base-game patch (9.1.5)
Updated:10/31/23 07:27 AM
Created:06/28/23 11:01 AM
Monthly downloads:806
Total downloads:14,365
Favorites:49
MD5:
No, thank you! - Endless Archive  Popular! (More than 5000 hits)
Version: 11.3a
by: ZaiZah [More]
This is an updated version of No, thank you! and more specifically updated version from uta.karas update

I'm still quite new to this, but i'll do my best to keep it maintained

You'll also need these libraries, so you need install them individually if not yet.
Please make sure your libraries are up-to-date

Feel free to also update/maintain this wonderful addon if you would like to
11.3a - ZaiZah
- Added check for ingame leaderboard settings. (No, Thank You should no longer send rogue leaderboard messages if you have it turned off from the ingame settings)
- Added option to show/hide Endless Archive leaderboard notifications
- Added option to disable/enable notification sound (This applies to all notifications and disabled by default)
- Added some space to the bottom of the settings menu to fix the clipping dropdown menu for LUA Errors section

11.3 - ZaiZah
- Api bump to Endless Archive (u40)
- Fixed the Leaderboard Score functionality no more errors \o/ (Thank you Complicative for your help)
- Your saved vars will reset, this should avoid any potential issues with settings

11.2 - ZaiZah
- Added the option to hide guild application notifications (Useful if you're in a large guild that gets frequent applications) - thank you @schrodingerscatgirls

11.1 - ZaiZah
- Fixed the "Jump to Leader" functionality, it should now hide or show the jump dialog depending on your selection

11 - ZaiZah
- Compatible with update 38 (Necrom)
- Fixed an issue that caused books to flash open/closed when read
- Added all city wayshrines to date for the "Hide Wayshrine" Option
- Disabled the "Hide Crown Store" option as its currently not working as intended

No, Thank You - Blackwood Change Log - uta.karas
No thank you - Blackwood#ChangeLog

Original No, Thank you Change Log
No thank you#ChangeLog
Archived Files (4)
File Name
Version
Size
Uploader
Date
11.3
39kB
ZaiZah
10/30/23 05:08 PM
11.2
39kB
ZaiZah
08/04/23 05:41 AM
11.1
39kB
ZaiZah
07/18/23 07:50 AM
11
39kB
ZaiZah
06/28/23 11:01 AM


Post A Reply Comment Options
Unread 10/31/23, 12:27 AM  
ApoAlaia

Forum posts: 6
File comments: 145
Uploads: 0
The very last setting is 'wonky'

You can either leave it at the default setting or select 'none', can't really scroll the options.

Report comment to moderator  
Reply With Quote
Unread 10/31/23, 12:04 AM  
Masteroshi430
 
Masteroshi430's Avatar
AddOn Author - Click to view AddOns

Forum posts: 185
File comments: 737
Uploads: 20
Originally Posted by NeuroticPixels
Is this addon somehow keeping me from turning off Settings > Social > Leaderboard Notifications?
Multiple people told me that's the setting that needs to be turned off to stop receiving notifications in chat about Endless Archive scores, but it was off already. So I turned it on, turned it back off, and reloaded. I'm still getting the score messages in chat.

Any advice?

I figured it was this or Synced Account Settings.
I have both addons and have the same problem, the way Synced Account Settings works (I'm the mainteneer dev) I doubt it comes from it.
Does No, Thank you! check if this Leaderboard Notifications setting is on before moving the notifications to chat?
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 08:54 PM  
NeuroticPixels
Addon Addict
 
NeuroticPixels's Avatar
Premium Member

Forum posts: 211
File comments: 869
Uploads: 0
Is this addon somehow keeping me from turning off Settings > Social > Leaderboard Notifications?
Multiple people told me that's the setting that needs to be turned off to stop receiving notifications in chat about Endless Archive scores, but it was off already. So I turned it on, turned it back off, and reloaded. I'm still getting the score messages in chat.

Any advice?

I figured it was this or Synced Account Settings.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 06:52 PM  
NeuroticPixels
Addon Addict
 
NeuroticPixels's Avatar
Premium Member

Forum posts: 211
File comments: 869
Uploads: 0
Error:

/EsoUI/Libraries/Utility/ZO_PlatformUtils.lua:123: Attempt to access a private function 'IsInUI' from insecure code. The callstack became untrusted 5 stack frame(s) from the top.
stack traceback:
/EsoUI/Libraries/Utility/ZO_PlatformUtils.lua:123: in function 'ZO_IsPregameUI'
/EsoUI/Common/ZO_UIErrors/ErrorFrame.lua:411: in function 'ZO_ErrorFrame:RefreshButtons'
|caaaaaa<Locals> self = [table:1]{coloredFullError = "/EsoUI/Libraries/ZO_Templates/...", moreInfo = T, displayingError = T, advancedMode = T, titleText = "UI Error: |cffffff|r", errorHexCode = "", simpleError = "/EsoUI/Libraries/ZO_Templates/...", currentErrorIndex = 1, copyError = "/EsoUI/Libraries/ZO_Templates/...", suppressErrorDialog = F} </Locals>|r
/EsoUI/Common/ZO_UIErrors/ErrorFrame.lua:358: in function 'ZO_ErrorFrame:SetCurrentError'
|caaaaaa<Locals> self = [table:1], errorIndex = 1, errorData = [table:2]{errorString = "/EsoUI/Libraries/ZO_Templates/...", count = 1}, fullError = "/EsoUI/Libraries/ZO_Templates/..." </Locals>|r
/EsoUI/Common/ZO_UIErrors/ErrorFrame.lua:374: in function 'ZO_ErrorFrame:OnUIError'
|caaaaaa<Locals> self = [table:1], errorString = "/EsoUI/Libraries/ZO_Templates/..." </Locals>|r
user:/AddOns/NoThankYou/NoThankYou.lua:1258: in function 'keyboardAcceptCallback'
|caaaaaa<Locals> data = [table:3]{note = "/EsoUI/Libraries/ZO_Templates/...", acceptText = "Accept", declineText = "Decline", texture = "/esoui/art/miscellaneous/eso_i...", dataType = 1, message = "Lua Error triggered", controlsOwnSounds = T, shortDisplayText = "Lua Error", secsSinceRequest = 47.41641998291, sortIndex = 6, heading = "Lua Error"} </Locals>|r
user:/AddOns/LibNotification/LibNotification.lua:91: in function 'libNotificationKeyboardProvider:Accept'
|caaaaaa<Locals> self = [table:4]{canShowGamerCard = F, hasTimer = F}, data = [table:3] </Locals>|r
/EsoUI/Ingame/Contacts/Notifications_Common.lua:1810: in function 'ZO_NotificationManager:AcceptRequest'
|caaaaaa<Locals> self = [table:5]{totalNumNotifications = 6, allowUpdate = F, eventNamespace = "KeyboardNotifications"}, data = [table:3] </Locals>|r
/EsoUI/Ingame/Contacts/Keyboard/Notifications_Keyboard.lua:620: in function 'ZO_KeyboardNotificationManager:Accept_OnClicked'
|caaaaaa<Locals> self = [table:5], control = ud, data = [table:3] </Locals>|r
/EsoUI/Ingame/Contacts/Keyboard/Notifications_Keyboard.lua:701: in function 'ZO_NotificationsTwoButtonAccept_OnClicked'
|caaaaaa<Locals> control = ud </Locals>|r
ZO_NotificationsList1Row1Accept_Clicked:3: in function '(main chunk)'
|caaaaaa<Locals> self = ud, button = 1, ctrl = F, alt = F, shift = F, command = F </Locals>|r
Last edited by NeuroticPixels : 10/30/23 at 06:53 PM.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 06:27 PM  
jnikolay

Forum posts: 0
File comments: 5
Uploads: 0
Re: Updated to Endless Archive

Originally Posted by ZaiZah
It's now been updated to this patch, the raid leaderboard functionality problem should be fixed i hope
If there's anything off with it or any other problems let me know and i'll try to get them sorted as soon as i can

Your saved variables will be reset with this patch, this should avoid any potential problems i've seen with invisible settings menu's some had in the past

Thanks to the people that reported the problem and helped offer a solution
thanks so much!
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 05:25 PM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Updated to Endless Archive

It's now been updated to this patch, the raid leaderboard functionality problem should be fixed i hope
If there's anything off with it or any other problems let me know and i'll try to get them sorted as soon as i can

Your saved variables will be reset with this patch, this should avoid any potential problems i've seen with invisible settings menu's some had in the past

Thanks to the people that reported the problem and helped offer a solution
Last edited by ZaiZah : 10/30/23 at 05:25 PM.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 02:15 PM  
tweva
Premium Member

Forum posts: 4
File comments: 52
Uploads: 0
Thanks.
You're the second best thing that happened to me so far today.




Originally Posted by Gamer1986PAN
Thank you for posting that error because i did not get that one but that helped me fix it so i can at least supress the UI errors again.

Just open the "NoThankYou.lua" and go to line 583 and change it from:
ZO_PreHook(ZO_LeaderboardRaidProvider, "BuildNotificationList", BuildNotificationList_Hook)
to:
--ZO_PreHook(ZO_LeaderboardRaidProvider, "BuildNotificationList", BuildNotificationList_Hook)


Then go to Line 2157 and change it from:
HookRaidNotifications()
to:
--HookRaidNotifications()

This does deactivate the leaderboard functions to a degree but it makes the rest of the addon work again until it got fixed properly.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 02:13 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 653
Uploads: 2
Re: Broken Feature: Don't rotate game camera...

Originally Posted by Nukluk
After Update 40 went live, the following feature no longer works.
  • Don't rotate game camera when you open map, inventory or other scenes - same as in No Spin.

I even tried removing every other addon I have and relaunching the game with only "No, thank you!" and its supporting libraries.

Hopefully this will be a quick/easy fix for you.
Thanks.
The No-Spin Feature in Inventory works just fine for me if you do this:

For now if you comment out the HookRaidNotifications()
On Line 2157 and change it to:
--HookRaidNotifications()
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 01:49 PM  
ZaiZah
AddOn Author - Click to view AddOns

Forum posts: 1
File comments: 19
Uploads: 2
Fix in the works

Thank you all for bringing this to my attention, I don't usually play on the PTS so wouldn't of been able to fix it before it got put on live

It seems that ZoS has reworked the scoreprovider to integrate the endless archive, hopefully the fix shouldn't take overly long. Just a few changes and testing to ensure its working correctly and i'll push the update out as soon as i'm able

For now if you comment out the HookRaidNotifications()
On Line 2157 and change it to:
--HookRaidNotifications()

That was posted below should save you the headache of errors until then
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 01:12 PM  
Honestaly

Forum posts: 3
File comments: 59
Uploads: 0
Originally Posted by Gamer1986PAN
Thank you for posting that error because i did not get that one but that helped me fix it so i can at least supress the UI errors again.

Just open the "NoThankYou.lua" and go to line 583 and change it from:
ZO_PreHook(ZO_LeaderboardRaidProvider, "BuildNotificationList", BuildNotificationList_Hook)
to:
--ZO_PreHook(ZO_LeaderboardRaidProvider, "BuildNotificationList", BuildNotificationList_Hook)


Then go to Line 2157 and change it from:
HookRaidNotifications()
to:
--HookRaidNotifications()

This does deactivate the leaderboard functions to a degree but it makes the rest of the addon work again until it got fixed properly.
Blah all we need is the ID for EA and we're probably fine.
I assume EA is technically an arena.
Code:
	local isArena = {
		[250] = true, -- Maelstrom Arena
		[270] = true, -- DragonStar Arena
		[378] = true, -- Blackrose Prison
		[457] = true, -- Vateshran Hallows
	}
Line 1224 of NoThankYou.lua
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 01:07 PM  
Nukluk
 
Nukluk's Avatar

Forum posts: 0
File comments: 30
Uploads: 0
Broken Feature: Don't rotate game camera...

My 'No Spin' issue is resolved with a fresh install of the newest "No, thank you! - Endless Archive, 9.2.5"

The issue I posted earlier today:

_____________

After Update 40 went live, the following feature no longer works.
  • Don't rotate game camera when you open map, inventory or other scenes - same as in No Spin.

I even tried removing every other addon I have and relaunching the game with only "No, thank you!" and its supporting libraries.

Hopefully this will be a quick/easy fix for you.


Thanks!
Last edited by Nukluk : 10/30/23 at 05:54 PM.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 12:47 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 653
Uploads: 2
Originally Posted by jnikolay
Originally Posted by tweva
::sigh::
Yeah, took me a few minutes find this thread.
I hope something can be done to salvage this addon.

Originally Posted by Honestaly
Originally Posted by Marazota
error on PTS

/EsoUI/Libraries/Utility/ZO_Hook.lua:15: attempt to index a nil value
stack traceback:
/EsoUI/Libraries/Utility/ZO_Hook.lua:15: in function 'ZO_PreHook'
user:/AddOns/NoThankYou/NoThankYou.lua:583: in function 'HookRaidNotifications'
user:/AddOns/NoThankYou/NoThankYou.lua:2157: in function 'OnAddonLoaded'
And now it's an error on public
It's an issue with this - ZO_LeaderboardRaidProvider - in the prehook line of the LUA. removing that gets rid of the error, but not sure the other ramifications of removing it. I'm guessing the syntax of that particular line of code changed, but also not sure how to figure out what it changed to.

those are the removed ones:

*************************
*** Functions Removed ***
*************************

* GetNumRaidScoreNotifications()
** _Returns:_ *integer* _numNotifications_


* GetRaidScoreNotificationId(*luaindex* _notificationIndex_)
** _Returns:_ *integer* _notificationId_


* GetRaidScoreNotificationInfo(*integer* _notificationId_)
** _Returns:_ *integer* _raidId_, *integer* _raidScore_, *integer* _millisecondsSinceRequest_


* GetNumRaidScoreNotificationMembers(*integer* _notificationId_)
** _Returns:_ *integer* _numMembers_


* GetRaidScoreNotificationMemberInfo(*integer* _notificationId_, *luaindex* _memberIndex_)
** _Returns:_ *string* _displayName_, *string* _characterName_, *bool* _isFriend_, *bool* _isGuildMember_, *bool* _isPlayer_


* RemoveRaidScoreNotification(*integer* _notificationId_)


* GetJournalQuestInstanceDisplayType(*luaindex* _journalQuestIndex_)
** _Returns:_ *[InstanceDisplayType|#InstanceDisplayType]* _instanceDisplayType_

Most of them are changed to something like "GetLeaderboardScoreNotificationInfo" instead if i am not wrong...

You can find this here: https://www.esoui.com/forums/showthread.php?t=10696
Last edited by Gamer1986PAN : 10/30/23 at 12:53 PM.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 12:30 PM  
ApoAlaia

Forum posts: 6
File comments: 145
Uploads: 0
Just a wild guess but it might be due to the fact that now there is one more leaderboard (Endless Archive) and they might have changed things around in the API?
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 12:05 PM  
jnikolay

Forum posts: 0
File comments: 5
Uploads: 0
Originally Posted by tweva
::sigh::
Yeah, took me a few minutes find this thread.
I hope something can be done to salvage this addon.

Originally Posted by Honestaly
Originally Posted by Marazota
error on PTS

/EsoUI/Libraries/Utility/ZO_Hook.lua:15: attempt to index a nil value
stack traceback:
/EsoUI/Libraries/Utility/ZO_Hook.lua:15: in function 'ZO_PreHook'
user:/AddOns/NoThankYou/NoThankYou.lua:583: in function 'HookRaidNotifications'
user:/AddOns/NoThankYou/NoThankYou.lua:2157: in function 'OnAddonLoaded'
And now it's an error on public
It's an issue with this - ZO_LeaderboardRaidProvider - in the prehook line of the LUA. removing that gets rid of the error, but not sure the other ramifications of removing it. I'm guessing the syntax of that particular line of code changed, but also not sure how to figure out what it changed to.
Report comment to moderator  
Reply With Quote
Unread 10/30/23, 12:03 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 653
Uploads: 2
Thank you for posting that error because i did not get that one but that helped me fix it so i can at least supress the UI errors again.

Just open the "NoThankYou.lua" and go to line 583 and change it from:
ZO_PreHook(ZO_LeaderboardRaidProvider, "BuildNotificationList", BuildNotificationList_Hook)
to:
--ZO_PreHook(ZO_LeaderboardRaidProvider, "BuildNotificationList", BuildNotificationList_Hook)


Then go to Line 2157 and change it from:
HookRaidNotifications()
to:
--HookRaidNotifications()

This does deactivate the leaderboard functions to a degree but it makes the rest of the addon work again until it got fixed properly.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: