Go to Page... |
Compatibility: | Gold Road (10.0.0) Scions of Ithelia (9.3.0) Endless Archive (9.2.5) |
Updated: | 05/17/24 08:36 PM |
Created: | 01/21/24 06:53 PM |
Monthly downloads: | 387 |
Total downloads: | 1,505 |
Favorites: | 5 |
MD5: |
File Name |
Version |
Size |
Uploader |
Date |
240424j |
56kB |
Vilkasmanga |
04/24/24 05:31 PM |
|
240329i |
54kB |
Vilkasmanga |
03/29/24 02:57 PM |
|
240229h |
51kB |
Vilkasmanga |
02/29/24 02:35 PM |
|
240219g |
46kB |
Vilkasmanga |
02/19/24 01:43 AM |
|
240219g |
38kB |
Vilkasmanga |
02/07/24 11:56 PM |
|
240130d |
29kB |
Vilkasmanga |
02/01/24 04:44 PM |
|
240129b |
25kB |
Vilkasmanga |
01/29/24 01:05 AM |
Comment Options |
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
02/12/24, 08:05 PM | ||
|
Re: bug on lockpick success ?
I think this error message is more about FarmersToolkit.Lootable more than interactionData.name but will dig into it. -V |
|
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
02/11/24, 12:37 PM | |||
Re: bug on lockpick success ?
quick and dirty fix, it removes the error for me:
adding this before line 1910:
|
|||
|
Azhdeen |
View Public Profile |
Send a private message to Azhdeen |
Send email to Azhdeen |
Find More Posts by Azhdeen |
Add Azhdeen to Your Buddy List |
02/11/24, 12:25 PM | ||
bug on lockpick success ?
Hi,
I get an error message when I finish lock picking treasure chests or doors. For example:
in the event data, "Déverrouiller" is "Unlock" in French, and "Coffre" is Chest. but I don't know if the error could come from using a transleted value. |
||
|
Azhdeen |
View Public Profile |
Send a private message to Azhdeen |
Send email to Azhdeen |
Find More Posts by Azhdeen |
Add Azhdeen to Your Buddy List |
02/08/24, 07:28 PM | |||
|
|
||
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
02/08/24, 11:48 AM | ||
|
|
|
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
02/08/24, 03:32 AM | |
|
Patiently waiting for some screenshots to show the addon in action.
|
|
NeuroticPixels |
View Public Profile |
Send a private message to NeuroticPixels |
Send email to NeuroticPixels |
Visit NeuroticPixels's homepage! |
Find More Posts by NeuroticPixels |
Add NeuroticPixels to Your Buddy List |
02/01/24, 04:47 PM | |||||||
|
Re: Re: Re: Re: Re: Re: Leaking globals no more
|
||||||
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Visit Vilkasmanga's homepage! |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
01/30/24, 08:38 AM | ||||||
|
Re: Re: Re: Re: Re: Leaking globals no more
-V |
|||||
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Visit Vilkasmanga's homepage! |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
01/29/24, 10:49 PM | |||||
Re: Re: Re: Re: Leaking globals no more
From what I can see with a quick check, you did seem to get everything. Thanks for making the changes! Few notes: local FarmersToolkit = {} -> This actually doesn't need to be local, as the addon table is an exception to the 'don't make globals' rule. There's nothing wrong with it being local; but if you split up the addon into multiple files, then this should be global. That will allow you to 'communicate' between different files. I actually do highly suggest splitting up the addon into multiple more modular files. It makes it a lot easier to navigate files, especially when they start getting very large. You kind of noticed it was weird already But you don't need local DailyClaimed = "N" at line 400. (or line 1906) You're only using a 'DailyClaimed' in another function, where it is separately initialized and declared as local, and thus different from the other two DailyClaimed. So the local variable created on those two lines are never actually used anywhere. Code:
local exampleVar = 1 local function exampleFun() local exampleVar = 2 d(exampleVar) -> outputs 2, the exampleVar outside of the function is hidden end local function exampleFun2(exampleVar) d(exampleVar) -> outputs whatever is passed to the function as a parameter, the exampleVar outside of the function is hidden here too end d(exampleVar) -> outputs 1, the exampleVar inside of the function does not exist outside of the function
Last edited by Dolgubon : 01/29/24 at 10:51 PM.
|
|||||
|
Dolgubon |
View Public Profile |
Send a private message to Dolgubon |
Send email to Dolgubon |
Visit Dolgubon's homepage! |
Find More Posts by Dolgubon |
Add Dolgubon to Your Buddy List |
01/29/24, 11:17 AM | |||
|
Re: Re: Re: Leaking globals galore
The next major task, assuming this version is more palatable, will likely be to broach some form of GUI interface for settings. There are tons of examples, I'm just at the starting point / flat end of the learning curve. Thanks again for all your help and feedback, always welcome and appreciated. -V |
||
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Visit Vilkasmanga's homepage! |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
01/23/24, 09:45 PM | ||
Re: Re: Leaking globals galore
You can also always throw the leaking variables into your addon's main table. That makes them non global, but also means you don't need to worry about where it is declared. Also, you can modify the addon name from the addon management page, no need to take it down. |
||
|
Dolgubon |
View Public Profile |
Send a private message to Dolgubon |
Send email to Dolgubon |
Visit Dolgubon's homepage! |
Find More Posts by Dolgubon |
Add Dolgubon to Your Buddy List |
01/23/24, 09:44 PM | ||
|
Baertram - Thanks for your feedback and suggestions- these look like great references. I'll review these links as well as Dolgubon's email and take another swing at it. It is probably easiest if I pull the (misnamed/typo'd) submission down in the meantime, yes?
-V
|
|
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Visit Vilkasmanga's homepage! |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
01/23/24, 09:38 PM | ||
|
Re: Leaking globals galore
Awesome feedback, really appreciate it - will make take down the mis-named version and make the necessary corrections. As you can probably tell, this is my first attempt and there's a fair amount of learning-along-the-way code (and, so, a lot of commented out code and things like zo_callater...)
I'll work on the local / scoping issues. Every time I tried to do it "the right way", it bit me but I may be smarter now, we shall see. Thanks also for tricks like Lootable = {["Chest"] = 0}, those are extremely helpful. I spend way too much time testing whether a variable exists before referring to it (part of the reason I got wrapped around the axle on remindercount, I suspect) Anyway - thanks again, your feedback is really helpful. -V
|
|
|
Vilkasmanga |
View Public Profile |
Send a private message to Vilkasmanga |
Send email to Vilkasmanga |
Visit Vilkasmanga's homepage! |
Find More Posts by Vilkasmanga |
Add Vilkasmanga to Your Buddy List |
01/22/24, 01:34 AM | |
|
Hi and welcome to ESO addon development.
As Dolgubon already said please make variables local where global ones are not needed. Please read this e.g. about lua https://www.esoui.com/forums/forumdisplay.php?f=172 -> and this about new ESO addons https://www.esoui.com/forums/forumdisplay.php?f=170
Last edited by Baertram : 01/22/24 at 09:00 AM.
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Send email to Baertram |
Visit Baertram's homepage! |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |