Go to Page... |
Compatibility: | Gold Road (10.0.0) |
Updated: | 06/23/24 11:52 AM |
Created: | 05/21/24 04:32 AM |
Monthly downloads: | 194 |
Total downloads: | 2,598 |
Favorites: | 3 |
MD5: | |
Categories: | Miscellaneous, Data Mods, Group, Guild & Friends, Info, Plug-in Bars, UI Media |
File Name |
Version |
Size |
Uploader |
Date |
1.0.5 |
6kB |
oInsideOut |
05/27/24 10:17 AM |
Comment Options |
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
06/23/24, 01:35 PM | |
|
As a general dev tip, it's usually a good idea to separate the actual data and the "presentation" of that data.
So, instead of working with and storing the names of dungeons, you could instead work with and store their zone IDs, translating those IDs to human-readable names only as the final "presentation" step of displaying info to the user, thus keeping much of your code language-neutral and reducing the footprint of code that needs to deal with the thorny issues of internationalization and localization. |
|
code65536 |
View Public Profile |
Send a private message to code65536 |
Find More Posts by code65536 |
Add code65536 to Your Buddy List |
06/23/24, 12:10 PM | ||
|
The reason for the error message is an edge case in the handling of the translation of dungeon names. In the last update, I fixed the translation issue by removing the article of the dungeon names. The dungeon "The Cauldron" is an exception since it is stored with its article in the SavedVariables file/table. I have released an update that addresses this issue. If you encounter any other bugs/error messages, please let me know.
Last edited by oInsideOut : 06/23/24 at 12:33 PM.
|
|
|
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
06/23/24, 04:23 AM | |
Forum posts: 2
File comments: 69
Uploads: 0
|
Code:
user:/AddOns/DungeonHistory/DungeonHistory.lua:131: attempt to index a nil value stack traceback: user:/AddOns/DungeonHistory/DungeonHistory.lua:131: in function 'DungeonHistory.StartDungeon' |caaaaaa<Locals> event = 131177, ActivityFinderStatus = 3 </Locals>|r |
|
crysis992 |
View Public Profile |
Send a private message to crysis992 |
Find More Posts by crysis992 |
Add crysis992 to Your Buddy List |
06/12/24, 11:21 AM | ||||
|
I was already thinking about adding and tracking more information. Sounds like a good idea to get some extra information when hovering an entry. Like last time someone suggested an idea, I'll keep it in mind and eventually add it when I find the time and motivation. |
|||
|
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
06/12/24, 04:15 AM | |||
Forum posts: 2
File comments: 69
Uploads: 0
|
Any chance to add group members in a future update? Like the Raidificator addon for raids, that shows all group members with their @userid and class icon for that run when hovering over an entry. |
||
|
crysis992 |
View Public Profile |
Send a private message to crysis992 |
Find More Posts by crysis992 |
Add crysis992 to Your Buddy List |
06/08/24, 06:08 PM | ||
|
I assume you are not playing ESO in English, because I was able to reconstruct this error message by changing the language in ESO from English US to German. The error occurs because ESO adds an article to the front of some dungeon names when translating it into German. By calling the GetUnitZone() function the dungeon name is output with a "translation" suffix of control characters (e.g. ^fd,in). The problem now is that the dungeon names are saved without their definitive article or control character suffix in the SavedVariables file/table but are searched for with the control character suffix. I will release an update that should fix this issue, however I have only tested it for the German language as it is very time consuming to test it for every other language myself. I know there are better ways to address this issue which I might implement in the future. If you still get the error, please let me know and also tell me which language you are playing in. |
|
|
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
06/08/24, 05:40 AM | |
Forum posts: 2
File comments: 69
Uploads: 0
|
Can't get this to work, every time I finish a random vet dungeon following error pops up:
Code:
user:/AddOns/DungeonHistory/DungeonHistory.lua:131: attempt to index a nil value stack traceback: user:/AddOns/DungeonHistory/DungeonHistory.lua:131: in function 'DungeonHistory.StartDungeon' |
|
crysis992 |
View Public Profile |
Send a private message to crysis992 |
Find More Posts by crysis992 |
Add crysis992 to Your Buddy List |
05/27/24, 07:45 AM | ||
|
Re: Awesome!
I'm glad that the AddOn is of help to you. |
|
|
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
05/27/24, 07:22 AM | |
Forum posts: 0
File comments: 177
Uploads: 0
|
Awesome!
Thanks for sharing your Addon, oInsideOut! It's really useful - especially the duration column.
|
|
ChrisK |
View Public Profile |
Send a private message to ChrisK |
Find More Posts by ChrisK |
Add ChrisK to Your Buddy List |
05/23/24, 12:23 PM | ||
|
Thank you for the suggestion. Actually the purpose and reason I started developing this AddOn is to keep track of how many Dungeons I've completed before I drop a mask. Sounds like a good idea to add more stats or something like a tracker. I'll keep that in mind and eventually add it when I find the time and motivation. |
|
|
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
05/23/24, 10:35 AM | |
Forum posts: 1
File comments: 18
Uploads: 0
|
Hi, I have an idea, how about adding stats on how many times cleared dungeon? For example, you are farming style mask and already lost count.... and then it finally drops and you want to know how many times you have completed this dungeon
|
|
Cheshire |
View Public Profile |
Send a private message to Cheshire |
Find More Posts by Cheshire |
Add Cheshire to Your Buddy List |
05/21/24, 05:49 AM | ||
|
That makes a lot of sense. I will adapt my code to your suggestion.
Last edited by oInsideOut : 05/21/24 at 06:28 AM.
|
|
|
oInsideOut |
View Public Profile |
Send a private message to oInsideOut |
Find More Posts by oInsideOut |
Add oInsideOut to Your Buddy List |
05/21/24, 04:57 AM | |
|
Welcome to ESO addon development.
A hint: All variables you declare in lua are global (accessible by other addons and overwriting existing variables), unless you add a local up in front. To minimize compatibilty issues and pollution of the global namespace (table _G): If you create an addon with an UI (like your scrolllist in XML, using variable DungeonHistoryXML as a global container), but you already got a global table (DungeonHistory) you could simply add a sub-table DungeonHistory.XML= {} (adding all variables and UI related functions to that) instead of defining another 2nd global DungeonHistoryXML. To speed-up the reference and make it easy to access them in your code you can add a local reference like local DungeonHistoryXML = DungeonHistory.XML at the top, below defining DungeonHistory.XML = {} This will make your code below (in the same lua file) work the same as of before, only using the local reference, pointing to the global table DungeonHistory.XML (instead of a 2nd global variable DungeonHistoryXML). -> Only in your XML files you'd need to change DungeonHistoryXML to DungeonHistory.XML as the variable DungeonHistoryXML would be local now, and not global anymore. It's no "Must do it like that" but a best practice.
Last edited by Baertram : 05/21/24 at 05:02 AM.
|
|
Baertram |
View Public Profile |
Send a private message to Baertram |
Find More Posts by Baertram |
Add Baertram to Your Buddy List |