Fish Log : ESO Tools & Utilities : Elder Scrolls Online AddOns

(7 Kb)

Download

Updated: 07/14/24 03:45 AM

Add Favorite

Install Help

Pictures

File Info

Compatibility:	Gold Road (10.0.0)
Updated:	07/14/24 03:45 AM
Created:	07/14/24 03:45 AM
Monthly downloads:	24
Total downloads:	31
Favorites:	1
MD5:

10.0.0

Fish Log

Version: 1.1

by: Adeptus333 [More]

A fish tracking add-on that displays metrics:

- Announces catches in the chat log.
- Shows how many fish have been caught since install, over sessions.
- Shows how many fish have been caught in the current session.
- How long you've been fishing.
- Etc.

Commands include:

- '/fishlog'
- '/fishlogglobal'
- '/fishstats'

Optional Files (0)

Comment Options

Yesterday, 05:06 AM
Baertram Super Moderator Forum posts: 5098 File comments: 6181 Uploads: 78	Hi welcome to ESO addon development. Please remove any hidden files and folders from your zip file prior to uploading it: .idea/ IntelliJ IDEA project files You can upload the same version and cleaned zip again by enabling the checkbox "ignore version" and unchecking the checkbox "archive file" Edit: This is wrong! Lua Code: FishLog_SavedVariables = FishLog_SavedVariables or { globalFishCounts = {}, -- Global fish counts across sessions totalFishCaught = 0 -- Total fish caught across sessions } 1st FishLog_SavedVariables is not available prior to your addon's EVENT_ADD_ON_LOADED so this will always be nil and create the table with your contents there. 2nd If you want to set default values to the table do that after EVENT_ADD_ON_LOADED either via ZO_SavedVars wrapper or manually as you do not seem to be using ZO_SavedVars warapper e.g. Lua Code: --Somewhere at the top e.g. replace the line FishLog_SavedVariables = FishLog_SavedVariables or { with local defaultSV = { globalFishCounts = {}, -- Global fish counts across sessions totalFishCaught = 0 -- Total fish caught across sessions } --At your EVENT_ADD_ON_LOADED: function FishLog.OnAddOnLoaded(event, addonName) if addonName == FishLog.name then EVENT_MANAGER:UnregisterForEvent(FishLog.name, EVENT_ADD_ON_LOADED) if ZO_IsTableEmpty(FishLog_SavedVariables) then FishLog_SavedVariables = defaultSV end EVENT_MANAGER:RegisterForEvent(FishLog.name, EVENT_PLAYER_ACTIVATED, FishLog.StartNewSession) EVENT_MANAGER:RegisterForEvent(FishLog.name, EVENT_INVENTORY_SINGLE_SLOT_UPDATE, FishLog.OnInventoryUpdate) EVENT_MANAGER:RegisterForEvent(FishLog.name, EVENT_FISHING_LURE_SET, FishLog.OnBaitSet) SLASH_COMMANDS["/fishlog"] = FishLog.ShowFishLog SLASH_COMMANDS["/fishlogglobal"] = FishLog.ShowFishLogGlobal SLASH_COMMANDS["/fishstats"] = FishLog.ShowStats end end Also PLEASE do not create global functions like dee (too short and non unique name!) Make them local OR add your addon name in front like FishLog_dee or better add it to your table FishLog like function FishLog.dee() ... end local dee = FishLog.dee As your addon only seems to support English language please add that to your description so ppl do not install it if they think it supports any other ESO official language like German, French, Spanish, Russian or Chinese too. btw: Your SavedVariables currently will be the same on EU and NA and PTS server! So beware, you will be overwriting them... And you do not track ANY @accountname in your savedvars!!! So any accountwill overwrite the other :-( You really should use ZO_SavedVars:NewAccountWide wrapper to make the SV account and maybe even server dependent via GetWorldName() function like explained here: https://wiki.esoui.com/Storing_data_and_accessing_files Thank you Last edited by Baertram : 07/14/24 at 06:29 AM.

Report this File