Personally, I'd be perfectly happy with an either/or option. I'm generally aiming for the higher crit rating. I appreciate whatever you put in place though. Thanks for the response!

I'd still like a global profile to save the numbers for the alerts, as I use the same values on every character.

Perhaps I just don't understand the functionality of the addon but after combat I expect the total to zero out but it does not. Is this proper behavior? Is there a reset function or action?

Thanks!

I'd like to also see my current spell/weapon crit chance.

Thanks! That makes perfect sense!

@ghostbane

First, thx for the addon. Great deal, great work mate!

Second, any option to make borders/edges/bg like default esoui ?

For example

Addon wont work without constant error message. SOS.

user:/AddOns/Greyskull/greyskull.lua:168: operator < is not supported for nil < number
stack traceback:
user:/AddOns/Greyskull/greyskull.lua:168: in function 'Greyskull.Render'
|caaaaaa<Locals> inital = T, self = [table:1]{isLoaded = T, name = "greyskull"}, color = [table:2]{1 = 1}, powerLevel = 3929, powerGroup = [table:3]{}, i = 1 </Locals>|r
user:/AddOns/Greyskull/greyskull.lua:115: in function 'Greyskull.Initialize'
|caaaaaa<Locals> self = [table:1] </Locals>|r
user:/AddOns/Greyskull/greyskull.lua:374: in function 'OnPlayerActivated'
|caaaaaa<Locals> eventCode = 589824 </Locals>|r

Please remove the libraries LibStub and LiBAddonMenu from your libs subfolder!
They should not be included anymore to addons, especially not LibStub which is obsolete since Summerset!

Your addon is leaking the variable hasAPM to global!
Please add local up in front or add it to your already global variable Greyskull
Btw, GREYSKULL_HEIGHT and width should be moved to Greyskull table as well. It's easier to see they belong to each other than defining global variables more and more, if you already got 1 global table where all your addon data could be stored.

+ Please use either GetWorldName() in the SavedVariables (e.g. as 3rd parameter "namespace" or as last "profile", or use ZO_SavedVars:NewCharacterIdSettings so it uses the unique (per server at least) character IDs instead of the names, so we are able to differ the
settings properly per server.
Beware that changing the namespace or profile parameter will have the users loose their savedvariables if you do not migrate them to the new subtables!
Changing the ZO_SavedVars:New to NewCharacterIdSettings could automatically migrate to the charIds though (if :New will use charcter names).
Names are not rename safe! So ALWAYS use the characterIds now (since Summerset already).

And please unregister the EVENT_ADD_ON_LOADED once your addon was found as else it will rerun your code checks for every addon activated!
Add at if addOnName == Greyskull.name then

Thank you.

Edit:
I'm working on an updated version with these changes, and will post my file here as a link. Also trying to fix the error message that was posted below.
Greyskull v0.4.4 beta by Baertram

Changelog:
-Updated API version for current live and next patch
-Removed embedded libraries LibSub (obsolote! Do not install anymore!) and LibAddonMenu-2.0 (please download and install the newest version manually from www.esoui.com)
-Fixed error message nil > number
-Added right click on UI to switch between weapon damage or spell damage view
-Recoded some passages to be more performant
-Removed self where not needed, and directly used Greyskull instead
-Fixed global leaking variables hasAPM
-Fixed non-used variables GREYSKULL_WIDTH and GREYSKULL_HEIGHT -> Moved to global Greyskull.width and Greyskull.height
-Fixed SavedVariables to use characterIds instead of names + the servername. Your SV will reset so you have to reconfigure them. But the old data is still kept for the future so you could still create a kind of migration rouine to copy old data to new server dependent ones
-Fixed optional dependency to addon APMeter
-Fixed EVENT_ADD_ON_LOADED to unregister (as the optional dependency to APMeter handles the call to APMeter addon before Greyskull)

Sadly its not working with U34. Its not showing itself on my screen. TY!

i don't see a version 4.4 hosted with below mentioned updates.

Hi, would really like an option in this add-on that would make its settings account wide