Download
(118 Kb)
Download
Updated: 06/05/22 11:03 PM
Patch for:
Bank Manager Revived.
Pictures
File Info
Compatibility:
Lost Depths (8.1.5)
High Isle (8.0.0)
Updated:06/05/22 11:03 PM
Created:04/23/19 05:03 PM
Monthly downloads:279
Total downloads:40,116
Favorites:54
MD5:
Categories:Plug-Ins & Patches, Bags, Bank, Inventory
Bank Manager Revived - Slim Edition  Popular! (More than 5000 hits)
Version: 14.90
by: Gamer1986PAN, @DeadSoon
Bank Manager Revived - Slim Edition

Depends on this Librarys:
LibResearch
LibAddonMenu2.0

Make sure to install this librarys for a working addon

The new Version can be used as Slim and as Full version with the "Global Addon Profile" feature. This is especially to help the non ESO+ Users. But keep in mind with this slim versions you only got 10 profiles in total (for now) - instead of 10 profiles for each char like in the non slim versions.


I only commented some features of the orignal "Bank Manager Revived" or rather from the "Jewelry Crafting Fix of Bank Manager Revived" out in order to have less features but smaller saved variables and related to this smaller saved varibles -better performance.

To benefit from the smaller saved variables, the original ones must be deleted/renamed and new files + profiles must be created. (don't forget to backup your saved variables, so you are able to go back to the original version if you are not satisfied with the slim edition. If you want to reactivate one special option you had in the last version but missing here - i can try to help you make it work again (minor code tweaks and leads again to bigger saved variables)

All credits goes to the original Authors. Ayantir, SnowmanDK, Eldrni and (not original team, but he also did some bugfixes that version depends on) Lexynide


If you found a bug you have here but not in the "Jewelry Crafting Fix Version" let me know and i try to find a solution. If the bug also exists in "Jewelry Crafting Fix Version" i can not guarantee that i can fix that, because i don't master LUA and i only be able to modify small things. If there is a real bug i just can hope some real author is willing to help me out there.


*Notice*: I know that some items - e.g. trophys don't work 100% properly - like they also don't work in original version. When i have some time i try to find a fix for that problem.


If you want to help with this addon just let me know in the comment section and i add you to the team. If you master LUA and want to get some practice in finding and removing bugs you are very welcome.


Bank Manager Revived will help you manage your bank & your guild bank (at guild bank - deposit only)

BMR will automatically deposit the preset items from your current character inventory to the bank or withdraw them from your bank to your inventory.


Features:

Global features
  • bank & guild bank support
  • auto move when opening bank (item/currencies)
  • display a detail of each move and/or summary
  • don't move items protected by ItemSaver / FCO Item Filter addon
  • don't move items moved by other addons while interacting
  • import setting between characters
  • auto restack bank / bag /guild bank after completion
  • fully localized (English, French, Deutsch and Russian)
  • pull your writs items needed for quests

Global Addon Profile

There are 4 global addon profiles predefined:
  1. ESO+ no crafting
  2. ESO+ with crafting
  3. no ESO+ no crafting
  4. no ESO+ with crafting
with the "ESO+" profiles material that can be deposited in the crafting bag can no longer be selected in the options
"with crafting" profiles also shows e.g. intricate armor/weapons as options


Profile support

You can have 9 accountwide profiles defined with their own rules. If 2+ profiles are defined or the current profile is not set to automatically transfer items, an UI will appear at bank to let you switch between profiles. You can easily set a name, and reset a profile. For more profiles there is a posting in the comments how to use up to 39 profiles with manual edit

Currencies (Gold / Tel Var Stones / Alliance Points / Writ Vouchers)

2 individual sliders to choose how much to keep in bag (e.g enough to feed your horse the next 10 days) or how much to grab from bank if you don't have enough. (0 to disable the 2nd function). Gold sliders are 0 up to 200K, Tel Var up to 10K, Alliance Points up to 200k and Writ Vouchers up to 5k.
You can also use the option "Don't keep any ..." to deposit the full amount of this currency to the bank or activate additional to that the option "Keep in Bank instead of Bag" to withdraw everything of that specific currency.



Provisioning
  • Choose to push/pull known recipes
  • Choose to push/pull unknown recipes

Enchanting (up to 50) of the same type
  • Choose to push/pull glyphs

Trophies (up to 50 stacks) of the same type
  • Choose to push/pull treasure maps
  • Choose to push/pull survey maps
  • Choose to push/pull style motif fragments
  • Choose to push/pull recipe fragments
  • Choose to push/pull imperial city trophies

Housing
  • Choose to push/pull known recipes
  • Choose to push/pull unknown recipes
  • Choose to push/pull Furnishing

Misc
  • Choose to push/pull AvA repair
  • Choose to push/pull disguises
  • Choose to push/pull lockpics
  • Choose to push/pull potions
  • Choose to push/pull racial motif books
  • Choose to push/pull containers (does not work with containers you also can not move manually)
  • Choose to push/pull (crown) repair kits
  • Choose to push/pull soul gems, empty or charged

Crafting
  • Choose to push/pull 1 or + (up to 50) stacks of any material <- had to bundle potency runes at all levels with the changes from 14.2
  • Choose to push/pull weapons/armor/jewelry (sets excluded)
  • Choose to push/pull intricate weapons/armor/jewelry (sets excluded)
  • Choose to push/pull researchable weapons/armor/jewelry (sets excluded) <- CraftStore addon support inside

Known Bugs
  • Runes not working (only Ta and Glyphs) Fixed with 14.2
  • Identical Intricate (Jewelry) Items can not be moved together to target (if you have e.g. 4 identical rings BMR will only move 1 of them - no matter what settings you made) - fixed with 14.4
  • Intricate Items can not be pushed to guildbank - working for Jewelry and Woodworking with 14.4
  • If you interact with a storage box (furnishing item) all items you push automatically to bank will be deposited in the bank (even if you do not have the banker NPC), if you want to place that items in the storage box, you have to change your profile or change the options in your current profile to not auto push in bank in order to keep them in your inventory and deposit them manually


Upcoming changes
  • Choose to push/pull intricate jewelry items Done with 14.3 - provided by LordKor -> thank you
  • Change to global saved varibles instead of different profiles for every character - Done with 13.0
  • Optional Setting to switch back to Full Version (if you are not ESO+) - Done with 14.0
  • Find a way that invisible options are also not performing any action
  • Find a way to move intricate items into guildbank - working for Jewelry and Woodworking with 14.4
Information only for non slim users!
since 13.0:
- Change to use accountwide profiles
Please Backup your data first if you want to keep them especially if you are new to the slim version and maybe want to switch back to the non slim version


___________________________________________________________________________
___________________________________________________________________________


Start of most recent changelog:

14.90:
- Optional additional profiles (sadly you have to edit it manually because i can't find a dynamic way and its a huge memory waste if you don't need them)

here is how to use more profiles:
To use more profiles you have to open the Bank Manager.lua file with a notepad app (i prefer notepad++ but any notepad will do)
Lets say you want to change it from 9 to 19 profiles, here are the steps:

First you go to line 217 and delete the "--[["
then you switch to line 367 and add the "--[[" part before the [20]
Then you go to line 1611 and switch the 9 with 19
same with line 1671, 1749, 2800, 3101 and 3172.
you save the file and make a reload. Now you should be able to choose between 19 profiles.

I am not really satisfied with this but it does at least work for now until someone comes up with a dynamic option and you can make up to 39 profiles this way right now (do not recommed it because of the memory waste)

14.86:
- API Bump to 101034


14.85:
- API Bump for next DLC (not yet announced)
- bugfix with FCO Itemsaver provided from Baertram (big thanks as always)


14.84:
- API Bump
- raised max transfered gold from 200000 to 1000000 (request from Lexynide)
- raised max transfered alliance points from 200000 to 1000000
- raised max transfered telvar stones from 10000 to 100000

14.83:
- API Bump to 100034 to work with Flames of Ambition


14.82:
- API Bump to 100033 to work with Markarth

14.81:
- changed max stack to 500 from 50 (you could now deposit e.g. 500 identical glyphs in your guild bank if you want to)

14.8:
- only API Bump to 100032 to work with Stonethorn
- more changes and fixes are on the to-do-list but we did not find the time yet

14.7:
- API Bump to 100031 to work with Greymoor

14.6:
- removed libs from the bundle, please make sure to install them seperatly:
https://www.esoui.com/downloads/info517-LibResearch.html
https://www.esoui.com/downloads/info7-LibAddonMenu.html
to be honest i let them remove by Baertram, because he knows how to do it without breaking the addon, thanks for it

14.5:
- moved MasterWrits to it's final destination tab "Quests: Crafting"

14.4:
- you can now move identical intricate jewelry and woodworking items into the bank AND/OR guildbank by using its own max stack slider - coming for smithing and clothier in later updates hopefully
- temporary moved MasterWrits to trophys and forgot to move it where i really wanted it -> will be moved in 14.5 again (Quest Tab)

14.3:
- Added changes to Jewelry handling provided by LordKor -> thank you
-> you can now move intricate jewelry to/from bank not working for guild banks for now


14.2:
- Added changes to Poison/Poison Solvent handling provided by LordKor -> thank you
- Reworked Runes and Glyphs handling and sorting (works now for guild bank as well)
- API Bump to 100030 for the upcoming DLC
- minor changes i can't remember


14.1:
- Associated Guild Bank for smith, clothier and woodworker reactivated (still no movement for intricate items into guildbank)
- API bump to 100029 Dragonhold (its working with both Live and PTS)


14.0:
- API bump to 100028 Scalebreaker
- Global Addon Profiles added (this hides some options but if you did not deactivate one option before you change the profile - BMR will still perform an action - i am trying to fix this in future updates)
- saved variables will grow a bit, but it should not affect your performance really bad - however i will try to reduce it even more or at least back to the size you had with 13.0


13.0:
- Change to use accountwide profiles
Please Backup your data first if you want to keep them - because the first reload/logout with the new version will reset the current char. Because of that login/logout trough the chars for the first time, the size of the saved variables will be smaller with every character logging out.

If you want to make extra space delete the saved variables and create them new from the scratch (highly recommended)
- Some Minor Changes (outcommenting of some unneeded elements)

- in the comment section is a zip-archive with all functions of BMR Jewelry Crafting version reactivated but with accountwide profiles. This is especially to help the non ESO+ Users - but we will have a look if we can combine them into one version and switch between slimmed ESO+ and non ESO+ version. But first we want to take a look for remake of "intricate items".



12.2:
- Commented the furnishing material out (e.g. Bast, Regulus, Heartwood)

Next steps will be:
- change the saved variables to global/accountwide
(should reduce the size again for better performance, if needed i can think about implementing more profiles instead - let me know in the comments if you would need them but i don't really think they are needed) and you have to make future changes in one profile on one character only instead of importing the same profile to every other char or make the same changes)

- bring back the intricate item movement back - goal is for each individual profession and intricate items in general - all optional



12.1:
- Release
Archived Files (17)
File Name
Version
Size
Uploader
Date
14.90
117kB
Gamer1986PAN
06/05/22 09:47 PM
14.85
117kB
Gamer1986PAN
12/05/21 09:39 AM
14.84
117kB
Gamer1986PAN
09/19/21 09:22 AM
14.83
117kB
Gamer1986PAN
02/22/21 09:12 AM
14.82
117kB
Gamer1986PAN
11/01/20 05:50 PM
14.81
117kB
Gamer1986PAN
08/12/20 01:38 PM
14.8
117kB
Gamer1986PAN
05/17/20 05:34 AM
14.6
117kB
Gamer1986PAN
02/09/20 03:56 PM
14.5
170kB
Gamer1986PAN
01/18/20 11:49 PM
14.4
170kB
Gamer1986PAN
01/18/20 10:20 PM
14.3
170kB
Gamer1986PAN
01/07/20 05:33 PM
14.2
169kB
Gamer1986PAN
01/06/20 06:00 PM
14.1
169kB
Gamer1986PAN
08/14/19 12:29 PM
14.0
169kB
Gamer1986PAN
08/13/19 02:50 PM
13.0
169kB
Gamer1986PAN
05/18/19 10:59 AM
12.2
169kB
Gamer1986PAN
05/17/19 12:22 PM
12.1
169kB
Gamer1986PAN
04/23/19 05:03 PM


Post A Reply Comment Options
Unread 01/07/20, 06:13 AM  
LordKor

Forum posts: 0
File comments: 7
Uploads: 0
Re: Re: Re: Re: Alchemy

Glad to help a bit with this great addon. Thank you for working on it!

Originally Posted by Gamer1986PAN
Thank you for saving me a lot of research. I was able to implement it and make glyphs and runes work like its working with smithing and stuff. Have not found how to move intricate jewelry so far but i will have a look into it hopefully in january.
Well, I did it for jewelry - it seems to work with intricate as well.
But I still couldn't figure how "Researchable" is working...

Rules for Jewelry in BankManagerRules.lua:

Code:
function BankManagerRules.addFilters()

...

-- Inserting Jewelry anywhere here

	-- Jewelry
	ruleName = "jewelry"
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING}},
		},
		name = EsoStrings[1673], -- there's no ItemType for Jewelry
		tooltip = EsoStrings[1673],
	}

	-- Intricate Jewelry
	ruleName = "jewelryIntricate"
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING}},
			{func = GetItemLinkSetInfo, funcArgs = BMR_ITEMLINK, values = {false}},
			{func = IsItemJunk, funcArgs = BMR_BAG_AND_SLOT, values = {false}},
			{func = GetItemLinkTraitInfo, funcArgs = BMR_ITEMLINK, values = {ITEM_TRAIT_TYPE_JEWELRY_INTRICATE}},
		},
		name = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString("SI_ITEMTRAITTYPE", ITEM_TRAIT_TYPE_JEWELRY_INTRICATE)),
		tooltip = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString("SI_ITEMTRAITTYPE", ITEM_TRAIT_TYPE_JEWELRY_INTRICATE)),
	}

	-- Researchable Jewelry
	ruleName = "jewelryResearchable"
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING}},
			{func = GetItemLinkSetInfo, funcArgs = BMR_ITEMLINK, values = {false}},
			{func = IsItemJunk, funcArgs = BMR_BAG_AND_SLOT, values = {false}},
			{func = IsItemNeededForResearch, funcArgs = BMR_ITEMLINK, values = {true}},
		},
		name = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
		tooltip = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
	}

Jewelry panels in BankManager.lua:

Code:
-- Build a LAM SubMenu with a list of filters
local function LAMSubmenu(subMenu)

	local submenuControls = {}
	
	if subMenu == "currencies" then

...

	-- Jewelrycrafting
--	elseif subMenu == "jewelrycrafting" and db.globalAddonProfile >= 3 then - Old line
	elseif subMenu == "jewelrycrafting" and db.globalAddonProfile >= 2 then -- New line for all nonESO+ profiles
--		if db.globalAddonProfile >= 3 then -- don't need it here
		table.insert(submenuControls, panelOnlyIfNotFullStack("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
		table.insert(submenuControls, panelGuildBank("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementGBank" .. CRAFTING_TYPE_JEWELRYCRAFTING))
		table.insert(submenuControls, panelMaxStacks("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementAll" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementStacks" .. CRAFTING_TYPE_JEWELRYCRAFTING))
		
-- Inserting jewelry
		table.insert(submenuControls, {type = "texture", image="EsoUI/Art/Miscellaneous/horizontalDivider.dds", imageWidth=510, imageHeight=4})
		
		if db.globalAddonProfile == 2 or db.globalAddonProfile == 4 then
		table.insert(submenuControls, panelRule("jewelry"))
		table.insert(submenuControls, panelRule("jewelryIntricate"))
		table.insert(submenuControls, panelRule("jewelryResearchable"))
		end
-- End of new Jewelry block
		
		if db.globalAddonProfile >= 3 then -- relocating nonESO+ Crafting profile here
		
		for improvementItemIndex = 1, GetNumSmithingImprovementItems() do
			table.insert(submenuControls, panelRule("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING .. improvementItemIndex))
		end
	
		table.insert(submenuControls, panelOnlyIfNotFullStack("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementAll" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100)))
		table.insert(submenuControls, panelGuildBank("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementGBank" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100)))
		table.insert(submenuControls, panelMaxStacks("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementAll" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementStacks" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100)))
		for improvementItemIndex = 1, GetNumSmithingImprovementItems() do
			table.insert(submenuControls, panelRule("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100) .. improvementItemIndex))
		end
		
			table.insert(submenuControls, {type = "texture", image="EsoUI/Art/Miscellaneous/horizontalDivider.dds", imageWidth=510, imageHeight=4})
			
			table.insert(submenuControls, panelOnlyIfNotFullStack("Material[A]?[l]?[l]?" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelGuildBank("Material[A]?[l]?[l]?" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialGBank" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelMaxStacks("Material[A]?[l]?[l]?" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialStacks" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelRule("MaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelRule("refinedMaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelRule("rawMaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			
			for materialIndex = 1, #BankManagerRules.static.refinedMaterial[CRAFTING_TYPE_JEWELRYCRAFTING] do
				if BankManagerRules.static.refinedMaterial[CRAFTING_TYPE_JEWELRYCRAFTING][materialIndex] ~= "" then
					table.insert(submenuControls, panelRule("refinedMaterial" .. CRAFTING_TYPE_JEWELRYCRAFTING .. materialIndex))
				end
				if BankManagerRules.static.rawMaterial[CRAFTING_TYPE_JEWELRYCRAFTING][materialIndex] ~= "" then
					table.insert(submenuControls, panelRule("rawMaterial" .. CRAFTING_TYPE_JEWELRYCRAFTING .. materialIndex))
				end
			end
		end
Report comment to moderator  
Reply With Quote
Unread 01/07/20, 05:28 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Re: Re: Re: Re: Re: Alchemy

Thank you very much again. Only had to make minor adjustments to make jewelrycrafting show up in profile 2 but it was a great pioneering work from you again.

Sadly that does not fix the problem, that you are not able to move any of the intricate items to guildbank, hopefully we can find a workaround for that as well.

To move researchable items you need to have CraftStore - will add that in the description

but with the upcoming update you can push/pull intricate jewelry to/from bank.



Originally Posted by LordKor
Glad to help a bit with this great addon. Thank you for working on it!

Originally Posted by Gamer1986PAN
Thank you for saving me a lot of research. I was able to implement it and make glyphs and runes work like its working with smithing and stuff. Have not found how to move intricate jewelry so far but i will have a look into it hopefully in january.
Well, I did it for jewelry - it seems to work with intricate as well.
But I still couldn't figure how "Researchable" is working...

Rules for Jewelry in BankManagerRules.lua:

Code:
function BankManagerRules.addFilters()

...

-- Inserting Jewelry anywhere here

	-- Jewelry
	ruleName = "jewelry"
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING}},
		},
		name = EsoStrings[1673], -- there's no ItemType for Jewelry
		tooltip = EsoStrings[1673],
	}

	-- Intricate Jewelry
	ruleName = "jewelryIntricate"
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING}},
			{func = GetItemLinkSetInfo, funcArgs = BMR_ITEMLINK, values = {false}},
			{func = IsItemJunk, funcArgs = BMR_BAG_AND_SLOT, values = {false}},
			{func = GetItemLinkTraitInfo, funcArgs = BMR_ITEMLINK, values = {ITEM_TRAIT_TYPE_JEWELRY_INTRICATE}},
		},
		name = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString("SI_ITEMTRAITTYPE", ITEM_TRAIT_TYPE_JEWELRY_INTRICATE)),
		tooltip = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString("SI_ITEMTRAITTYPE", ITEM_TRAIT_TYPE_JEWELRY_INTRICATE)),
	}

	-- Researchable Jewelry
	ruleName = "jewelryResearchable"
	BankManagerRules.data[ruleName] = {
		params = {
			{func = GetItemLinkItemType, funcArgs = BMR_ITEMLINK, values = {EQUIP_TYPE_NECK, EQUIP_TYPE_RING}},
			{func = GetItemLinkSetInfo, funcArgs = BMR_ITEMLINK, values = {false}},
			{func = IsItemJunk, funcArgs = BMR_BAG_AND_SLOT, values = {false}},
			{func = IsItemNeededForResearch, funcArgs = BMR_ITEMLINK, values = {true}},
		},
		name = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
		tooltip = zo_strformat("<<1>> (<<2>>)", EsoStrings[1673], GetString(SI_SMITHING_RESEARCH_RESEARCHABLE)),
	}

Jewelry panels in BankManager.lua:

Code:
-- Build a LAM SubMenu with a list of filters
local function LAMSubmenu(subMenu)

	local submenuControls = {}
	
	if subMenu == "currencies" then

...

	-- Jewelrycrafting
--	elseif subMenu == "jewelrycrafting" and db.globalAddonProfile >= 3 then - Old line
	elseif subMenu == "jewelrycrafting" and db.globalAddonProfile >= 2 then -- New line for all nonESO+ profiles
--		if db.globalAddonProfile >= 3 then -- don't need it here
		table.insert(submenuControls, panelOnlyIfNotFullStack("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
		table.insert(submenuControls, panelGuildBank("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementGBank" .. CRAFTING_TYPE_JEWELRYCRAFTING))
		table.insert(submenuControls, panelMaxStacks("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementAll" .. CRAFTING_TYPE_JEWELRYCRAFTING, "improvementStacks" .. CRAFTING_TYPE_JEWELRYCRAFTING))
		
-- Inserting jewelry
		table.insert(submenuControls, {type = "texture", image="EsoUI/Art/Miscellaneous/horizontalDivider.dds", imageWidth=510, imageHeight=4})
		
		if db.globalAddonProfile == 2 or db.globalAddonProfile == 4 then
		table.insert(submenuControls, panelRule("jewelry"))
		table.insert(submenuControls, panelRule("jewelryIntricate"))
		table.insert(submenuControls, panelRule("jewelryResearchable"))
		end
-- End of new Jewelry block
		
		if db.globalAddonProfile >= 3 then -- relocating nonESO+ Crafting profile here
		
		for improvementItemIndex = 1, GetNumSmithingImprovementItems() do
			table.insert(submenuControls, panelRule("improvement" .. CRAFTING_TYPE_JEWELRYCRAFTING .. improvementItemIndex))
		end
	
		table.insert(submenuControls, panelOnlyIfNotFullStack("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementAll" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100)))
		table.insert(submenuControls, panelGuildBank("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementGBank" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100)))
		table.insert(submenuControls, panelMaxStacks("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementAll" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100), "improvementStacks" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100)))
		for improvementItemIndex = 1, GetNumSmithingImprovementItems() do
			table.insert(submenuControls, panelRule("improvement" .. (CRAFTING_TYPE_JEWELRYCRAFTING * 100) .. improvementItemIndex))
		end
		
			table.insert(submenuControls, {type = "texture", image="EsoUI/Art/Miscellaneous/horizontalDivider.dds", imageWidth=510, imageHeight=4})
			
			table.insert(submenuControls, panelOnlyIfNotFullStack("Material[A]?[l]?[l]?" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelGuildBank("Material[A]?[l]?[l]?" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialGBank" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelMaxStacks("Material[A]?[l]?[l]?" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING, "MaterialStacks" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelRule("MaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelRule("refinedMaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			table.insert(submenuControls, panelRule("rawMaterialAll" .. CRAFTING_TYPE_JEWELRYCRAFTING))
			
			for materialIndex = 1, #BankManagerRules.static.refinedMaterial[CRAFTING_TYPE_JEWELRYCRAFTING] do
				if BankManagerRules.static.refinedMaterial[CRAFTING_TYPE_JEWELRYCRAFTING][materialIndex] ~= "" then
					table.insert(submenuControls, panelRule("refinedMaterial" .. CRAFTING_TYPE_JEWELRYCRAFTING .. materialIndex))
				end
				if BankManagerRules.static.rawMaterial[CRAFTING_TYPE_JEWELRYCRAFTING][materialIndex] ~= "" then
					table.insert(submenuControls, panelRule("rawMaterial" .. CRAFTING_TYPE_JEWELRYCRAFTING .. materialIndex))
				end
			end
		end
Last edited by Gamer1986PAN : 01/07/20 at 05:43 PM.
Report comment to moderator  
Reply With Quote
Unread 01/08/20, 06:03 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Bug with the current version:

Identical Intricate Items can not be moved together to target (if you have e.g. 4 identical rings BMR will only move 1 of them - no matter what settings you made)

At least for jewelry this bug is confirmed
Report comment to moderator  
Reply With Quote
Unread 01/17/20, 12:38 AM  
Brettelectric

Forum posts: 0
File comments: 26
Uploads: 0
Is this a bug or an exploit?

I have BMR set to deposit all furnishings in my bank.

I was in my small home, and picked a piece of furniture up from the home, and then saw it was in my bag. Then looked in one of my storage chests, and BMR put that piece of furniture into my BANK while I was looking in the STORAGE CHEST.

I don't own a bank assistant. There should be no way that I can access my bank from my house. Yet BMR put a piece of furniture into my bank while I was looking in my storage chest.

Is this some sort of bug or exploit?
Report comment to moderator  
Reply With Quote
Unread 01/17/20, 08:27 AM  
Dolgubon
 
Dolgubon's Avatar
AddOn Author - Click to view AddOns

Forum posts: 409
File comments: 892
Uploads: 21
Re: Is this a bug or an exploit?

Originally Posted by Brettelectric
I have BMR set to deposit all furnishings in my bank.

I was in my small home, and picked a piece of furniture up from the home, and then saw it was in my bag. Then looked in one of my storage chests, and BMR put that piece of furniture into my BANK while I was looking in the STORAGE CHEST.

I don't own a bank assistant. There should be no way that I can access my bank from my house. Yet BMR put a piece of furniture into my bank while I was looking in my storage chest.

Is this some sort of bug or exploit?
If you visit a house with a writ, and stuff in your bank for it, you'll notice that it actually withdraws the items as soon as you step into the house!


While inside your house, the bank is usable by add-ons at all times. Back when housing came out, I asked zos_chiphipselberg about it, and his answer was (paraphrased)' not intended, but it's something that we can allow.' So, bug in ESO were allowed to use.
Report comment to moderator  
Reply With Quote
Unread 01/17/20, 12:30 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Re: Is this a bug or an exploit?

Originally Posted by Brettelectric
I have BMR set to deposit all furnishings in my bank.

I was in my small home, and picked a piece of furniture up from the home, and then saw it was in my bag. Then looked in one of my storage chests, and BMR put that piece of furniture into my BANK while I was looking in the STORAGE CHEST.

I don't own a bank assistant. There should be no way that I can access my bank from my house. Yet BMR put a piece of furniture into my bank while I was looking in my storage chest.

Is this some sort of bug or exploit?
Like mentioned in the bugs its a bug we already knew and might be able to add at least an option to enable/disable this behavior in the future but its not priority right now. Thank you for your report anyway.

Known Bugs
  • Runes not working (only Ta and Glyphs) Fixed with 14.2
  • Identical Intricate (Jewelry) Items can not be moved together to target (if you have e.g. 4 identical rings BMR will only move 1 of them - no matter what settings you made)
  • Intricate Items can not be pushed to guildbank
  • If you interact with a storage box (furnishing item) all items you push automatically to bank will be deposited in the bank (even if you do not have the banker NPC), if you want to place that items in the storage box, you have to change your profile or change the options in your current profile to not auto push in bank in order to keep them in your inventory and deposit them manually
Report comment to moderator  
Reply With Quote
Unread 01/31/20, 05:35 PM  
CooLow

Forum posts: 0
File comments: 24
Uploads: 0
Items that are part of a set are not transfering to the bank. Is there any config to fix this out?
Report comment to moderator  
Reply With Quote
Unread 02/02/20, 06:36 AM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Originally Posted by CooLow
Items that are part of a set are not transfering to the bank. Is there any config to fix this out?

Not now. This would cause problems with gear-defined sets that are in your inventory.
What sets do you want to transfer? Could you explain to me so i can figure out if its possible?
Report comment to moderator  
Reply With Quote
Unread 02/05/20, 09:56 AM  
Gandamir

Forum posts: 12
File comments: 43
Uploads: 0
Pulling from bank when accessing storage

Hello,

The addon treats storage chests (housing) the same as the bank. This causes some issues such as depositing things in the wrong place as well as withdrawing from the bank when you shouldn't have access to it.

As I suspect the second one is an API issue, I have filed this bug report to ZOS:
https://forums.elderscrollsonline.co...omment/6579428

With that said, could we get behavior updates for storage vs. bank?

And... I just saw the prior posts regarding this below...
Last edited by Gandamir : 02/05/20 at 09:57 AM.
Report comment to moderator  
Reply With Quote
Unread 02/05/20, 03:09 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Re: Pulling from bank when accessing storage

Originally Posted by Gandamir
Hello,

The addon treats storage chests (housing) the same as the bank. This causes some issues such as depositing things in the wrong place as well as withdrawing from the bank when you shouldn't have access to it.

As I suspect the second one is an API issue, I have filed this bug report to ZOS:
https://forums.elderscrollsonline.co...omment/6579428

With that said, could we get behavior updates for storage vs. bank?

And... I just saw the prior posts regarding this below...
You should also check Dolgubons post about this issue:

Originally Posted by Dolgubon
Originally Posted by Brettelectric
I have BMR set to deposit all furnishings in my bank.

I was in my small home, and picked a piece of furniture up from the home, and then saw it was in my bag. Then looked in one of my storage chests, and BMR put that piece of furniture into my BANK while I was looking in the STORAGE CHEST.

I don't own a bank assistant. There should be no way that I can access my bank from my house. Yet BMR put a piece of furniture into my bank while I was looking in my storage chest.

Is this some sort of bug or exploit?
If you visit a house with a writ, and stuff in your bank for it, you'll notice that it actually withdraws the items as soon as you step into the house!


While inside your house, the bank is usable by add-ons at all times. Back when housing came out, I asked zos_chiphipselberg about it, and his answer was (paraphrased)' not intended, but it's something that we can allow.' So, bug in ESO were allowed to use.
Report comment to moderator  
Reply With Quote
Unread 02/09/20, 01:40 PM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4991
File comments: 6046
Uploads: 78
Please remove ALL libraries from the libs subfolder!
They need to be installed as standalone versions, or if you include them make sure to include them ALWAYS with their own txt files in order to let the ingame addon manager find the newest version properly automatically.

Your current versions of LibAddonMenu, LibResearch and others wil lbe always loaded and thus might destroy other addons as the code is always run, even if it ages too old and raises lua errors.

Use your BankmanagerRevived.txt file with the tags
## OptionalDependsOn:
and
## DependsOn:

to add dependencies to LibAddonMenu-2.0 and LibResearch and the other libraries of this addon, and remove the hardcoded lines like
/libs/LibStub/LibStub.lua
please!
Last edited by Baertram : 02/09/20 at 01:49 PM.
Report comment to moderator  
Reply With Quote
Unread 02/09/20, 04:08 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Originally Posted by Baertram
Please remove ALL libraries from the libs subfolder!
They need to be installed as standalone versions, or if you include them make sure to include them ALWAYS with their own txt files in order to let the ingame addon manager find the newest version properly automatically.

Your current versions of LibAddonMenu, LibResearch and others wil lbe always loaded and thus might destroy other addons as the code is always run, even if it ages too old and raises lua errors.

Use your BankmanagerRevived.txt file with the tags
## OptionalDependsOn:
and
## DependsOn:

to add dependencies to LibAddonMenu-2.0 and LibResearch and the other libraries of this addon, and remove the hardcoded lines like
/libs/LibStub/LibStub.lua
please!
Thanks for your help Baertram. You are a hero ^^
Report comment to moderator  
Reply With Quote
Unread 02/10/20, 02:48 AM  
Baertram
Super Moderator
 
Baertram's Avatar
ESOUI Super Moderator
AddOn Author - Click to view AddOns

Forum posts: 4991
File comments: 6046
Uploads: 78
I hope you have tested it after I had changed the files, I haven't as I said as I'm not using the addon anymore
Originally Posted by Gamer1986PAN
Originally Posted by Baertram
Please remove ALL libraries from the libs subfolder!
They need to be installed as standalone versions, or if you include them make sure to include them ALWAYS with their own txt files in order to let the ingame addon manager find the newest version properly automatically.

Your current versions of LibAddonMenu, LibResearch and others wil lbe always loaded and thus might destroy other addons as the code is always run, even if it ages too old and raises lua errors.

Use your BankmanagerRevived.txt file with the tags
## OptionalDependsOn:
and
## DependsOn:

to add dependencies to LibAddonMenu-2.0 and LibResearch and the other libraries of this addon, and remove the hardcoded lines like
/libs/LibStub/LibStub.lua
please!
Thanks for your help Baertram. You are a hero ^^
Last edited by Baertram : 02/10/20 at 02:48 AM.
Report comment to moderator  
Reply With Quote
Unread 02/10/20, 12:15 PM  
Gamer1986PAN
AddOn Author - Click to view AddOns

Forum posts: 87
File comments: 652
Uploads: 2
Did not test everything but it did move items into bank without LUA-Errors, so i am quite sure that all is working as it did before. (no additional bugs to the previous release)

Originally Posted by Baertram
I hope you have tested it after I had changed the files, I haven't as I said as I'm not using the addon anymore
Originally Posted by Gamer1986PAN
Originally Posted by Baertram
Please remove ALL libraries from the libs subfolder!
They need to be installed as standalone versions, or if you include them make sure to include them ALWAYS with their own txt files in order to let the ingame addon manager find the newest version properly automatically.

Your current versions of LibAddonMenu, LibResearch and others wil lbe always loaded and thus might destroy other addons as the code is always run, even if it ages too old and raises lua errors.

Use your BankmanagerRevived.txt file with the tags
## OptionalDependsOn:
and
## DependsOn:

to add dependencies to LibAddonMenu-2.0 and LibResearch and the other libraries of this addon, and remove the hardcoded lines like
/libs/LibStub/LibStub.lua
please!
Thanks for your help Baertram. You are a hero ^^
Report comment to moderator  
Reply With Quote
Unread 02/12/20, 05:56 PM  
CooLow

Forum posts: 0
File comments: 24
Uploads: 0
Originally Posted by Gamer1986PAN
Originally Posted by CooLow
Items that are part of a set are not transfering to the bank. Is there any config to fix this out?

Not now. This would cause problems with gear-defined sets that are in your inventory.
What sets do you want to transfer? Could you explain to me so i can figure out if its possible?
Parts of a set, that can be researched. Some items that are droped on lower levels, that can be researched should be transfered to bank, for latter use. But it keeps in my inv.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: