Download
(231 Kb)
Download
Updated: 03/14/24 11:05 PM
Pictures
File Info
Compatibility:
Scions of Ithelia (9.3.0)
Updated:03/14/24 11:05 PM
Created:06/30/17 11:08 AM
Monthly downloads:7,557
Total downloads:781,274
Favorites:413
MD5:
9.3.0
Arkadius' Trade Tools  Popular! (More than 5000 hits)
Version: 2.0.0
by: Arkadius, Aldanga, Verbalinkontinenz
Arkadius' Trade Tools is a modular framework with the goal to provide traders with useful trading tools and information and to help trade guild masters managing their guilds. Each added module will extend the functionality of ATT in some way. Modules come as their own addons and can therefore simply be deactivated via the addons menu if not needed.

Currently there are the following modules:
  • Sales
    • Visual: Tabbed window
    • Functionality: Collects sales from the player's guilds and displays them as a list which can be filtered in various ways. The information gained from these sales is used in multiple ways:
      • Guild rosters are extended by two additional columns, Purchases and Sales, which display the particular volume per guild member and selected time frame
      • Item tooltips are extended by the average price and a graph displaying the price development. The time frame for these calculations (1-30 days) can manually be selected.
      • Item price statistics can be inserted into chat. For non-English clients there is an option to post the statistics in English.
      • When browsing guild stores, listings also display the average price of the given item, so the player can see if it's over or underpriced

      Sales are stored for up to 30 days, depending on per-guild user settings. Most features can be enabled or disabled in the user settings.

  • Purchases
    • Visual: Tabbed window
    • Functionality: Saves purchases the player makes from guild traders and displays them as a list. This module may especially be useful for resellers to remember what they paid for a particular item. Purchases can be saved for up to 30 days.

  • Statistics
    • Visual: Tabbed window
    • Functionality: Allows other modules to send in statistic information which is then displayed as an assembled list. (currently only used by Sales)

  • Exports
    • Visual: Tabbed window
    • Functionality: Allows saving of guild-level sales data for export to CSV.

The community is free to write additional modules. Currently following external modules are known:
  • My Donation:
    • Adds a tabbed window which tracks your own deposits into guildbanks (up to 365 days) and enhances your overview, whether you met a guilds requirement not only on the sales side.

Currently supported languages:
  • English
  • German
  • French
  • Russian

Slash commands:
  • /att
    Toggle the visiblity of the main window

Addtional notes:
  • All data is stored per megaserver

Current Todo List/Feature Requests:
  • Adding craft cost support for more master writ types.
  • More customization for Deal Finder (margin, total sales, etc.)
  • Review of how writs are priced. Currently this is done by type and quality, but certain event writs don't really price well using that model. Traits and style mats can significantly impact craft cost, which can also affect price.
  • Review and rework of the sales window checkboxes as they provide information of limited value since the guild history API changes.
  • Investigate removing outliers from visible sales data. This could severely impact performance negatively, so no promises on this one.

Many thanks to my NA alpha testers, who catch way too many bugs and provide great feedback and feature suggestions:
  • @AislinAb
  • @autocatalyst
  • @paianjenul
  • @rdhdkc
  • @sozo108
  • @Spotlightstar
  • @sueblue
  • @Troub_S
  • @Wolvnn
v2.0.0
  • [NEW] Required dependencies: LibHistoire, LibDebugLogger
  • [NEW] Support for Update 41 via LibHistoire
  • [NEW] "Search for item" option to tooltips. This wasn't supposed to be included in the release, but let's see what happens...
  • [NEW] Unknown bugs. Please report issues found!
  • [UPDATE] Jewelry crafting links for master writs
  • [UPDATE] Sales window status icons (integration with LibHistoire)

The new guild history changes are not compatible with old ATT data. I recommended deleting your ATT saved variables before upgrading to v2.0.0. If you keep old data around, expect weird things to happen, including duplicate sales data!

In the interest of a quick release, v2.0.0 is missing translations for some new string values. Please let me know if you can help with translations!

v1.13.6
  • [FIX] Removed resizeToFitDescendents from Label elements

v1.13.5
  • [FIX] Issue with exports paths

v1.13.4
  • [FIX] Issue with tooltip graph where sales points no longer displayed

v1.13.3
  • [FIX] Compatibility issues with PerfectPixel - Thanks, Baertram!
  • [FIX] Issue where AGS price selector was hard to click
  • [UPDATE] Moved addon and library folders into single parent directory during deployment

v1.13.2
  • [FIX] Issue with sales events where new data could fail to save

v1.13.1
  • [FIX] Incompatibility with AutoCategory causing UI errors when inventory pricing is enabled - Thanks, GuilleW!
  • [UPDATE] Added compatibility for ESO update 34 "High Isle"

v1.13.0
  • [NEW] Item count sorting in Statistics tab
  • [NEW] Brazilian Portuguese translations (thanks, Telmatoscopus!)
  • [NEW] Support for companion gear tooltips
  • [UPDATE] Added compatibility for ESO update 30 "Blackwood"
  • [UPDATE] Disabled Unit Price sorting toggle in Purchases and Sales tabs
  • [UPDATE] Updated master writ craft cost calculation to use the API for style stones instead of a local lookup table

v1.12.2
  • [FIX] Issue in gamepad mode where searching in a guild trader could cause a UI error (Thanks, Friday_The13_rus!)

v1.12.1
  • [FIX] Rare issue with deal filtering that could cause an index to be nil (Thanks to sirinsidiator for his help!)
  • [UPDATE] Changed some spacing and alignment for AGS deal integration

v1.12.0
  • [NEW] Added option for auto pricing in vanilla trader UI
  • [NEW] Added option for hiding crafting table on tooltips
  • [NEW] Added new CLI options for exports creation (check the Exports README for more info)
  • [NEW] Added checkbox for exporting only member data
  • [FIX] Issue with writs auto pricing being calculated incorrectly
  • [FIX] Added delay to purchases window refresh to help alleviate some purchases not showing up in a timely manner (there are sometimes still issues)
  • [FIX] Trading house margins sometimes not being calculated correctly
  • [FIX] Trading house listing margins sometimes not being calculated correctly
  • [UPDATE] Added compatibility for ESO update 29 "Flames of Ambition"
  • [UPDATE] Removed deprecated AGS icons from filter
  • [UPDATE] Data addons are now marked as libraries to reduce noise in the addons list
  • [UPDATE] Chat logging now uses the chat router instead of the d function

v1.11.2
  • [FIX] Added export scripts to bundle

v1.11.1
  • [UPDATE] Removed some test code.

v1.11.0
  • [NEW] Added Exports module. Check the README in the Exports folder for details on converting export data to CSV.
  • [NEW] Added Exports tab for historical exports
  • [NEW] Added script for exporting to CSV
More features are to come, but please share your experiences with (and feature requests for) Exports!

v1.10.0
  • [NEW] Added missing motif styles
  • [UPDATE] Removed dead code for impossible special cases
  • [UPDATE] Added compatibility for ESO update 28 "Markarth"

v1.9.2
  • [FIX] Updating AGS filter to be compatible with AGS v1.5 (when released)

v1.9.1
  • [FIX] Errant double initialization for external modules (bad merges are bad, m'kay?)

v1.9.0
  • [NEW] Keybinds for toggling the tooltip graph and extensions
  • [NEW] Optional support for LibGuildRoster

v1.8.0
  • [NEW] Added auto-price button to AGS integration
  • [NEW] Performance improvements for writ voucher calculations
  • [FIX] Inventory prices not always rounding the correct direction
  • [FIX] Some inventory items not showing prices
  • [UPDATE] Long scan (Interval 1) minimum to 60s

v1.7.2
  • [FIX] Load times for sales data have been significantly reduced (by 40%+ for large data sets, based upon my testing)
  • [FIX] Third-party modules can now initialize properly

v1.7.1
  • [FIX] Issue where Cyrillic characters were not rendering within certain UI elements

v1.7.0
  • [FIX] Issue where custom popup tooltip additions from other addons wouldn't close correctly
  • [NEW] Text filters applied to the statistics window will now be restored upon reload or relog

v1.6.3
  • [FIX] Issue where using inventory market values would throw errors when using addons that heavily customize the inventory list. NOTE: Sorting by value may still break with some inventory addons, so proceed with caution.

v1.6.2
  • [FIX] Issue where trading weeks don't return the correct value under specific circumstances

v1.6.1
  • [FIX] Issue where the donate button was showing up on servers other than NA

v1.6.0
  • [UPDATE] Added support for new trader flip times. The first week (Sunday - Tuesday) will be 9 days to match server kiosk times, and the following weeks will shift to Tuesday - Tuesday
  • [NEW] Added a setting to use the traditional Sunday - Sunday trader week instead of the new server week
  • [NEW] Added the price graph to the provisioning and furniture crafting interfaces
  • [NEW] Added an option to enable displaying market value in inventory lists in place of base game value (this is a preview feature and is disabled by default)
  • [UPDATE] Added new crafting styles for master writ craft costs
  • [UPDATE] Reenabled the Donate button within the ATT window for NA players
  • [UPDATE] Added compatibility for ESO update 27 "Stonethorn"

v1.5.6
  • [FIX] Issue where menus would have invalid draw levels when ATT was enabled

v1.5.5
  • [FIX] Issue where Night Mother's Embrace and Night Mother's Gaze items would incorrectly share and report sales data from both sets
  • [UPDATE] Added compatibility for ESO update 26 "Greymoor"

v1.5.4
  • [FIX] Incorrect style material link for Shield of Senchal master writs

v1.5.3
  • [FIX] Trade tooltips not updating properly (Thanks, @Wickerman666!)

v1.5.2
  • [FIX] UI error that could occur when visiting a guild store via the bank with AGS enabled, but without interacting with the search window

v1.5.1
  • [FIX] Disabled unit price sorting until performance edge cases can be fixed

v1.5.0
  • [NEW] Added an AwesomeGuildStore filter to find good deals. (Items with no sales data default to OK; this can be modified in settings.)
  • [NEW] Added market price margin support to the item listings screen
  • [FIX] Typo in Purchases settings menu (Thanks, @Spotlightstar!)
  • [UPDATE] Enabled sorting by unit price within sales and purchases tabs
  • [UPDATE] Added new crafting styles for master writ craft costs

v1.4.0
  • [NEW] Added tooltip support for player-to-player trade windows
  • [NEW] Added keybind for opening the popup tooltip from inventory items
  • [UPDATE] Added compatibility for ESO update 25 "Harrowstorm"

v1.3.0
  • [UPDATE] Added new jewelry crafting writs and crafting styles for master writ craft costs

v1.2.0
  • [NEW] Added tooltip support for looting and NPC vendors

v1.1.3
  • [FIX] Updated AGS integration to show margin information in the guild trader UI
  • [UPDATE] Added compatibility for ESO update 24 "Dragonhold"
  • [REMOVED] Embedded LibAddonMenu (this must be installed as a separate dependency)

v1.1.2
  • [FIX] Updated guild scanning to use new guild history APIs
  • [UPDATE] Added compatibility for ESO update 23 "Scalebreaker"

v1.1.1
  • [FIX] Fixed an issue with master writs tooltips throwing a Lua error because of undefined numbers
  • [FIX] Disabled guild store extensions for Awesome Guild Store users again. They were accidentally enabled in the previous patch. A real fix still has to be found.


v1.1.0
  • [FIX] Tooltips won't show statistical information about BOP items anymore
  • [FIX] Fixed an issue with localization of decimal numbers
  • [NEW] This patch introduces the flrst step to display the average crafting costs for items required by master writs. This information is shown on the writ's tooltips.

    Note that not all writs are supported yet. Writs that should work:
    • [-] Blacksmithing
      [-] Clothier
      [-] Woodworking
      [-] Jewelry

    Others may be added at a later point.

    This feature is enabled by default and can be disabled through the addon's settings.

v1.0.15
  • [FIX] Tooltips should now show correct price information for jewelry materials
  • [FIX] Fixed a pattern matching issue for Russian clients
  • [Update] Guild store extensions have been visually adjusted to the new user interface introduced with Wrathstone
    Note: This feature is currently disabled for Awesome Guild Store users, as there is a incompatibility that has to get resolved first

v1.0.14
  • [FIX] Fixed an issue that caused Purchases module to display/store wrong data in combination with Awesome Guild Store

v1.0.13
  • [FIX] Fixed a bug that caused a LUA error when localizing decimal numbers
  • [NEW] Added Russian localization (special thanks to @Petrakon)
  • [NEW] Added French localization (special thanks to @Kerthas)

v1.0.12
  • [FIX] Fixed a bug that caused a LUA error when buying from a guild store

v1.0.11
  • [FIX] Fixed UI-Error caused by guild store changes
  • [NEW] Added single item price column to sales and purchases tabs - sorting that column by price will stay deactivated for now
  • [UPDATE] Added compatibility for ESO update 21 "Wrathstone"

v1.0.10
  • [UPDATE] Added compatibility for ESO update 19 "Wolfhunter"

v1.0.9
  • [UPDATE] Added compatibility for ESO update 18 "Summerset“

v1.0.8
  • [UPDATE] Added compatibility for ESO update 17 "Dragon Bones“

v1.0.7
  • [FIX] Reverted Shissu's patch
  • [UPDATE] Removed donation button
  • [UPDATE] Added compatibility for ESO update 16 "Clockwork City“

v1.0.6
  • [FIX] Fixed an issue that caused a LUA error when using a client language other than German or English
  • [FIX] Fixed an issue where filtering for account names that contain a '-' character would return no results
  • [UPDATE] Added compatibility for ESO update 15 "Horns of the Reach“

v1.0.5
  • [FIX] Fixed an issue with missing default settings

v1.0.4
  • [FIX] Last week time selection on statistics tab is back on English clients
  • [NEW] Added a new toggle button to the top-right corner of the main window. This lets you select if the window is drawn above or below other ui elements
  • [NEW] When shopping at guild stores, ATT will now prevent the search result list to reset to the top each time you buy something
  • [NEW] Added a key binding to toggle the main window
  • Some code restructure

v1.0.3
  • [FIX] ATT won't handle non-item links anymore
  • [FIX] Fixed an issue, where you couldn't correctly post a price check on some crafted items
  • [FIX] Fixed an issue, that caused a LUA error when handling custom item links
  • [NEW] Added "Prior week" to time filters for Sales/Purchases/Statistics modules
  • [NEW] Added an option to disable the graph in item tooltips
  • [FIX] Fixed a few typos
  • Some code restructure

v1.0.2
  • [FIX] Added missing LibStub to the package

v1.0.1
  • [FIX] Fixed an issue with English localisation

v1.0.0
  • First release
Optional Files (1)
File Name
Version
Size
Author
Date
Type
1.0.3
1kB
05/25/19 06:03 AM
Patch


Archived Files (55)
File Name
Version
Size
Uploader
Date
2.0.0
231kB
Aldanga
03/14/24 07:07 PM
1.13.6
228kB
Aldanga
03/13/23 07:43 PM
1.13.5
229kB
Aldanga
07/01/22 02:41 PM
1.13.4
229kB
Aldanga
07/01/22 10:46 AM
1.13.3
229kB
Aldanga
06/29/22 12:19 PM
1.13.2
225kB
Aldanga
06/28/22 09:40 AM
1.13.1
224kB
Aldanga
06/28/22 09:38 AM
1.13.1
224kB
Aldanga
06/27/22 08:24 AM
1.13.0
224kB
Aldanga
05/31/21 06:21 PM
1.12.2
222kB
Aldanga
04/12/21 06:47 PM
1.12.1
222kB
Aldanga
04/01/21 03:14 PM
1.12.0
222kB
Aldanga
02/25/21 07:38 PM
1.11.2
205kB
Aldanga
12/20/20 08:00 AM
1.11.1
204kB
Aldanga
12/18/20 07:57 PM
1.10.0
130kB
Aldanga
11/17/20 07:38 PM
1.9.2
130kB
Aldanga
11/09/20 05:25 PM
1.9.1
130kB
Aldanga
10/13/20 04:22 PM
1.9.0
130kB
Aldanga
10/10/20 10:31 AM
1.8.0
130kB
Aldanga
10/05/20 05:29 PM
1.7.2
128kB
Verbalinkontinenz
08/29/20 11:32 AM
1.7.1
128kB
Aldanga
08/28/20 06:59 PM
1.7.0
129kB
Aldanga
08/14/20 04:52 PM
1.6.3
128kB
Aldanga
08/13/20 12:29 PM
1.6.2
128kB
Aldanga
08/11/20 03:12 PM
1.6.1
129kB
Aldanga
08/07/20 05:07 PM
1.6.0
128kB
Aldanga
08/06/20 08:06 PM
1.5.6
125kB
Aldanga
07/01/20 07:21 PM
1.5.5
125kB
Aldanga
05/25/20 07:52 PM
1.5.4
125kB
Aldanga
04/20/20 07:55 AM
1.5.3
126kB
Aldanga
04/15/20 07:25 PM
1.5.2
126kB
Aldanga
04/07/20 11:47 AM
1.5.1
126kB
Aldanga
03/31/20 05:39 PM
1.5.0
126kB
Aldanga
03/30/20 06:29 PM
1.4.0
120kB
Aldanga
02/24/20 10:26 AM
1.3.0
119kB
Aldanga
11/01/19 02:02 PM
1.2.0
118kB
Aldanga
10/28/19 08:37 PM
1.1.3
121kB
Aldanga
10/20/19 03:39 PM
1.1.2
164kB
Aldanga
08/18/19 01:53 PM
1.1.1
162kB
Arkadius
03/29/19 11:34 AM
1.1.0
162kB
Arkadius
03/24/19 12:34 PM
1.0.15
155kB
Arkadius
03/11/19 01:08 PM
1.0.14
152kB
Arkadius
03/05/19 03:36 PM
1.0.13
152kB
Verbalinkontinenz
03/03/19 02:04 PM
1.0.12
144kB
Arkadius
02/26/19 11:04 AM
1.0.11
147kB
Verbalinkontinenz
02/25/19 01:58 PM
1.0.10
147kB
Arkadius
08/31/18 02:26 PM
1.0.9
143kB
Verbalinkontinenz
06/26/18 12:28 PM
1.0.8
143kB
Arkadius
03/04/18 08:31 AM
1.0.7
148kB
Arkadius
11/09/17 11:29 AM
1.0.6
148kB
Arkadius
08/14/17 08:55 AM
1.0.5
148kB
Arkadius
07/08/17 11:46 AM
1.0.4
147kB
Arkadius
07/08/17 07:15 AM
1.0.3
146kB
Arkadius
07/04/17 11:29 AM
1.0.2
146kB
Arkadius
06/30/17 01:26 PM
1.0.1
146kB
Arkadius
06/30/17 11:34 AM


Post A Reply Comment Options
Unread 07/01/17, 12:12 PM  
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1578
File comments: 1131
Uploads: 41
Originally Posted by Arkadius
Originally Posted by sirinsidiator
I installed this addon today and it looks very promising. Compared to MM it still lacks a few features, but I am sure they will be added over time.

There is however one major issue: It always request and scans the whole history of my guilds, which causes micro freezes every few seconds and makes it perform worse than MM while I have my other addons active. Can't play like this.
Yes, for now the complete history is requested. This is because I haven't found a reliable way yet to avoid missing sales without doing it. Actually, ATT doesn't miss any sales, but for some strange reason, sometimes a sale isn't stored into the saved vars tables, although it should be. I first saw this happening with the release of Morrowind so I expect it has something to do with the new built-in automatic lua memory management.

However, it's surprising you get micro freezes once the sales have been stored, as they aren't replaced. Neither me nor my testers have experienced this.
They probably do not use as many addons (115 right now). :P
I haven't looked into your code, but for me it looks like you are scanning the whole sales list every time which can amount to quite a lot of data. Maybe you could limit it to only the newly added data? Newly requested guild events are always added to the end of the list, so it should be enough to remember the last index and start scanning from there.
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 12:18 PM  
Arkadius
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 45
Uploads: 3
Originally Posted by sirinsidiator
Originally Posted by Arkadius
Originally Posted by sirinsidiator
I installed this addon today and it looks very promising. Compared to MM it still lacks a few features, but I am sure they will be added over time.

There is however one major issue: It always request and scans the whole history of my guilds, which causes micro freezes every few seconds and makes it perform worse than MM while I have my other addons active. Can't play like this.
Yes, for now the complete history is requested. This is because I haven't found a reliable way yet to avoid missing sales without doing it. Actually, ATT doesn't miss any sales, but for some strange reason, sometimes a sale isn't stored into the saved vars tables, although it should be. I first saw this happening with the release of Morrowind so I expect it has something to do with the new built-in automatic lua memory management.

However, it's surprising you get micro freezes once the sales have been stored, as they aren't replaced. Neither me nor my testers have experienced this.
They probably do not use as many addons (115 right now). :P
I haven't looked into your code, but for me it looks like you are scanning the whole sales list every time which can amount to quite a lot of data. Maybe you could limit it to only the newly added data? Newly requested guild events are always added to the end of the list, so it should be enough to remember the last index and start scanning from there.
This is what I do already.

And for reference:
On my not very up to date machine it takes 1 ms (measured with GetGameTimeMilliseconds()) to process one page (max 100 events) if they're already stored. Can't imagine how this could lead to micro stutters.
Last edited by Arkadius : 07/01/17 at 12:19 PM.
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 12:21 PM  
Shinni
AddOn Author - Click to view AddOns

Forum posts: 167
File comments: 550
Uploads: 22
Originally Posted by Arkadius
[ Actually, ATT doesn't miss any sales, but for some strange reason, sometimes a sale isn't stored into the saved vars tables, although it should be. I first saw this happening with the release of Morrowind so I expect it has something to do with the new built-in automatic lua memory management.
They only removed the memory warning message. LUA memory was always unlimited (besides of OS/Hardware limitations). It simply used to throw a warning when some arbitrary threshold was passed.

I suspect your missing sales to instead be a result from this line (ArkadiusTradeToolsSales.lua, line 483):
Lua Code:
  1. local eventIdNum = tonumber(Id64ToString(eventId))
You save your sales with eventIdNum as index, but LUA numbers are only 32 bit. So you will have sales with different eventId values (64 bit), which are converted to the same eventIdNum (32 bit) LUA number.
I.e. when such a conversion conflict happens, you only save one of the sales.

edit: Hm, at least on EU the sale ids are all small enough to fit as a 32 bit number. So that should not cause the issues.
Last edited by Shinni : 07/01/17 at 12:49 PM.
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 01:07 PM  
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1578
File comments: 1131
Uploads: 41
Originally Posted by Arkadius
And for reference:
On my not very up to date machine it takes 1 ms (measured with GetGameTimeMilliseconds()) to process one page (max 100 events) if they're already stored. Can't imagine how this could lead to micro stutters.
1ms is actually pretty slow.
A frame has ~16ms. Let's say half of that is used by the game itself. Leaves 8ms for addons. I have 115 addons. If every addon used that much time, 1 frame would require 115ms to complete. So worst case you'd only have 0.07ms per frame to do your stuff. Of course that's not how it really works, but you should try to optimize your code if it really takes 1ms per page. 100 events is not a lot and should be processed in less than 0.01ms.
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 01:12 PM  
Arkadius
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 45
Uploads: 3
Originally Posted by sirinsidiator
Originally Posted by Arkadius
And for reference:
On my not very up to date machine it takes 1 ms (measured with GetGameTimeMilliseconds()) to process one page (max 100 events) if they're already stored. Can't imagine how this could lead to micro stutters.
1ms is actually pretty slow.
A frame has ~16ms. Let's say half of that is used by the game itself. Leaves 8ms for addons. I have 115 addons. If every addon used that much time, 1 frame would require 115ms to complete. So worst case you'd only have 0.07ms per frame to do your stuff. Of course that's not how it really works, but you should try to optimize your code if it really takes 1ms per page. 100 events is not a lot and should be processed in less than 0.01ms.
Actually it's 0 to 1 ms and 1 ms max. But there is no higher resolution timer to measure it more exactly
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 01:23 PM  
Arkadius
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 45
Uploads: 3
Originally Posted by Shinni
Originally Posted by Arkadius
[ Actually, ATT doesn't miss any sales, but for some strange reason, sometimes a sale isn't stored into the saved vars tables, although it should be. I first saw this happening with the release of Morrowind so I expect it has something to do with the new built-in automatic lua memory management.
They only removed the memory warning message. LUA memory was always unlimited (besides of OS/Hardware limitations). It simply used to throw a warning when some arbitrary threshold was passed.

I suspect your missing sales to instead be a result from this line (ArkadiusTradeToolsSales.lua, line 483):
Lua Code:
  1. local eventIdNum = tonumber(Id64ToString(eventId))
You save your sales with eventIdNum as index, but LUA numbers are only 32 bit. So you will have sales with different eventId values (64 bit), which are converted to the same eventIdNum (32 bit) LUA number.
I.e. when such a conversion conflict happens, you only save one of the sales.

edit: Hm, at least on EU the sale ids are all small enough to fit as a 32 bit number. So that should not cause the issues.
I know what you mean, but that's not the issue.

The problem is, I get the announcement that I've sold an item (line 520). At that point, the sale should already have been added to the saved var table (line 490+), but sometimes it isn't. After a reloadui it will get added properly, even though the unique id hasn't changed.

Considering the lua warning:
They're not only removing the error message.
Originally Posted by ZOS_ChipHilseberg View Post
The error and the memory limit setting will be removed from the game when Morrowind launches.
Removing the memory limit implies (for me) that it's now automatically handled by the client. That's why Shissu discontinued Shissu's Lua Memory
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 01:45 PM  
Shinni
AddOn Author - Click to view AddOns

Forum posts: 167
File comments: 550
Uploads: 22
The limit was just a threshold for throwing a warning. Shissu's Memory addon just increased the warning threshold dynamically.
Originally Posted by ZOS_ChipHilseberg
The error is purely informative. Lua will keep growing its memory until the system runs out.
http://www.esoui.com/forums/showthre...t=memory+limit
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 01:53 PM  
Arkadius
AddOn Author - Click to view AddOns

Forum posts: 4
File comments: 45
Uploads: 3
Originally Posted by Shinni
The limit was just a threshold for throwing a warning. Shissu's Memory addon just increased the warning threshold dynamically.
Originally Posted by ZOS_ChipHilseberg
The error is purely informative. Lua will keep growing its memory until the system runs out.
http://www.esoui.com/forums/showthre...t=memory+limit
Yep, that's what I mean. And I wonder if this works properly....
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 01:53 PM  
Verbalinkontinenz
 
Verbalinkontinenz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 247
Uploads: 2
Well Siri, i dont know wether wether it makes sense, adjusting it for someone who uses 115 addons. O,O
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 02:01 PM  
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view AddOns

Forum posts: 1578
File comments: 1131
Uploads: 41
Originally Posted by Verbalinkontinenz
Well Siri, i dont know wether wether it makes sense, adjusting it for someone who uses 115 addons. O,O
Well Verbales, if MM is working fine for me, why should ATT - which is supposed to offer better performance - produce freezes for me?
I'll see if I can find what is causing the freezes.
Report comment to moderator  
Reply With Quote
Unread 07/01/17, 02:19 PM  
Verbalinkontinenz
 
Verbalinkontinenz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 247
Uploads: 2
Originally Posted by sirinsidiator
Originally Posted by Verbalinkontinenz
Well Siri, i dont know wether wether it makes sense, adjusting it for someone who uses 115 addons. O,O
Well Verbales, if MM is working fine for me, why should ATT - which is supposed to offer better performance - produce freezes for me?
I'll see if I can find what is causing the freezes.
Would be interesting yes. I am working with ATT since nearly half a year now, and it feels bette rfor me, for many other as well. I am not saying, there is no room for improvement, but your suggestion only might cause those problems, arka is trying to fix.
Report comment to moderator  
Reply With Quote
Unread 07/02/17, 08:57 AM  
justo

Forum posts: 0
File comments: 21
Uploads: 0
thx for the addon but can you please add a option to disable the HUGE graph??
Report comment to moderator  
Reply With Quote
Unread 07/02/17, 08:21 PM  
Scootworks
 
Scootworks's Avatar
AddOn Author - Click to view AddOns

Forum posts: 312
File comments: 64
Uploads: 28

bei einem Rechtsklick...
Report comment to moderator  
Reply With Quote
Unread 07/03/17, 01:32 AM  
Verbalinkontinenz
 
Verbalinkontinenz's Avatar
AddOn Author - Click to view AddOns

Forum posts: 11
File comments: 247
Uploads: 2
Originally Posted by Scootworks

bei einem Rechtsklick...
Absicht. Der User wird immer je nach Gusto seine Clientsprache und englisch (im internationalen Sektor) benutzen können.

Edit:
Here a longer explanation. The idea to make it like this came from me, so i have at least some competence to answer this. After 2 or 3 month, when we were internally already testing ATT somewhere in spring 2017, i just stombled accross the situation, that someone in Just Traders asked for a PC and then 3 or 4 price checks where posted and they were russian, german and english. Sure we already know the base structure of those price checks and are able to read them, even when they are not in our language or english. Still its a huge mashup and really disturbing for the eye and the reader, new players will have problems reading price checks from other "unknown" languages. So ATT will support the option of an english price check additionally to the normal client language controlled price check - if client language isnt english. The user then is able to chose depending on situation wether he uses his client language or english for a price check.
Last edited by Verbalinkontinenz : 07/03/17 at 02:55 AM.
Report comment to moderator  
Reply With Quote
Unread 07/03/17, 04:39 AM  
Sueedo

Forum posts: 0
File comments: 1
Uploads: 0
Hey there! Thank you for such an awesome addon it's just like what i wanted.
Just noticed if i click craft materials on chat log it gives me that error;
I also see this if i change day sliders on item pop-up screen.
(Yesterday it was perfect, guess i broke my addon damn)

Last edited by Sueedo : 07/03/17 at 04:44 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: