Quantcast
Download
(4 Kb)
Download
Updated: 09/22/20 06:42 PM
Pictures
File Info
Compatibility:
Stonethorn (6.1.5)
Greymoor (6.0.5)
Updated:09/22/20 06:42 PM
Created:09/11/20 08:38 PM
Monthly downloads:273
Total downloads:285
Favorites:1
MD5:
6.1.5
Custom Player Pins  Updated Today!
Version: 1.2.0
by: QuantumPie [More]
Custom Player Pins allows you to change the map marker for individual players so they can be easily distinguished on a minimap. The addon was created for use in a Dawnbringer (stair) prog. The addon was built off of Votan's Group Pins and a majority of the code is Votan's own work.

Note:
As this was built off of an addon for Votan's Minimap, I am unsure if this plays nicely with others




OLD USAGE (now use addon setting menu):
Usage:

/mappin - get info about the commands in game
/mappin add [@name] [icon] [color]
/mappin remove [@name]
/mappin reset
/mappin list

Valid icons include: mundus, skyshard, dolmen, boss, delve, quest, and champion
Valid colors include: red, green, blue, white
# 1.2.0
- Custom pins are now displayed on top of other group member's pins

# 1.1.1
- Fixed crown no longer being visible
- Made GetColor a local function

# 1.1.0
- Added setting menu as opposed to commands

# 1.0.1
- Fixed the player icon not showing
- Replaced mention of a "shield" icon in the help command
Optional Files (0)


Archived Files (3)
File Name
Version
Size
Uploader
Date
1.1.0
6kB
QuantumPie
09/17/20 06:30 PM
1.0.1
6kB
QuantumPie
09/15/20 06:49 PM
1.0.0
6kB
09/11/20 08:38 PM


Post A Reply Comment Options
Unread 09/17/20, 06:25 PM  
QuantumPie
AddOn Author - Click to view AddOns

Forum posts: 24
File comments: 4
Uploads: 1
Originally Posted by Baertram
Please make your function GetColor local or add it to your addon's namespace CUSTOM_PLAYER_PINS (function addon.GetColor...) as you overwrite all other GetColor functions this way and it is a very widely spread name.

And you still include the language files AND load them from your manifest txt file AND overwrite VOTAN's language strings!
Code:
## Title: Custom Player Pins
## Author: @QuantumPie [NA] / votan
...
lang/strings.lua
lang/$(language).lua
...
e.g. you are using
Code:
ZO_CreateStringId("SI_VOTANS_GROUPPINS_SHOW_CROWN", "Show Leader Crown")
in strings.lua
Code:
SafeAddString(SI_VOTANS_GROUPPINS_MODE_HEALTH, "Modus - Leben")
in de.lua

Please rename the language strings or remove the language files from your addon, else you are overwriting the strings with yours even if Votan would change them in his addon!

YOu also have left in code from votans addon using an identifier which was made for HIS addon. You should rename this as well to your own addon's identifier as identifiers normally should be unique:
Code:
	local updateIdentifier = "VOTANS_GROUP_PINS_UPDATE"
Another left over variable is
Code:
	compassPinType = "VOTANS_GROUP_COMPASS_PIN",
It's not used in your code so you can strip it or rename it at best.

And you still left in a referene to Votans Group Pings addon folder in live(AddOns/VotansGroupPins:
Code:
ZO_MapPin.PIN_DATA[MAP_PIN_TYPE_PLAYER].texture = "VotansGroupPins/art/Pointer1.dds"
If the folder would not exist and the file /art/Pointer1.dds does not exist you'd have a white rectangle shown, so better copy the file (with Votan's permission) to your addon's folders and reference corectly to your OWN addon's folder.

Thank you.
Thanks for the heads up! I'll fix it tomorrow in v1.1.1
Report comment to moderator  
Reply With Quote
Unread 09/16/20, 07:54 AM  
Baertram
 
Baertram's Avatar
AddOn Author - Click to view AddOns

Forum posts: 3093
File comments: 3718
Uploads: 63
Please make your function GetColor local or add it to your addon's namespace CUSTOM_PLAYER_PINS (function addon.GetColor...) as you overwrite all other GetColor functions this way and it is a very widely spread name.

And you still include the language files AND load them from your manifest txt file AND overwrite VOTAN's language strings!
Code:
## Title: Custom Player Pins
## Author: @QuantumPie [NA] / votan
...
lang/strings.lua
lang/$(language).lua
...
e.g. you are using
Code:
ZO_CreateStringId("SI_VOTANS_GROUPPINS_SHOW_CROWN", "Show Leader Crown")
in strings.lua
Code:
SafeAddString(SI_VOTANS_GROUPPINS_MODE_HEALTH, "Modus - Leben")
in de.lua

Please rename the language strings or remove the language files from your addon, else you are overwriting the strings with yours even if Votan would change them in his addon!

YOu also have left in code from votans addon using an identifier which was made for HIS addon. You should rename this as well to your own addon's identifier as identifiers normally should be unique:
Code:
	local updateIdentifier = "VOTANS_GROUP_PINS_UPDATE"
Another left over variable is
Code:
	compassPinType = "VOTANS_GROUP_COMPASS_PIN",
It's not used in your code so you can strip it or rename it at best.

And you still left in a referene to Votans Group Pings addon folder in live(AddOns/VotansGroupPins:
Code:
ZO_MapPin.PIN_DATA[MAP_PIN_TYPE_PLAYER].texture = "VotansGroupPins/art/Pointer1.dds"
If the folder would not exist and the file /art/Pointer1.dds does not exist you'd have a white rectangle shown, so better copy the file (with Votan's permission) to your addon's folders and reference corectly to your OWN addon's folder.

Thank you.
Last edited by Baertram : 09/16/20 at 08:02 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: