Quantcast
Download
(5 Kb)
Download
Updated: 11/21/21 12:05 PM
Patch for:
Fisherman's Friend.
Pictures
File Info
Compatibility:
Deadlands (7.2.5)
Updated:11/21/21 12:05 PM
Created:01/17/21 03:58 PM
Monthly downloads:800
Total downloads:4,775
Favorites:17
MD5:
7.2.5
Fisherman's Friend - Update
Version: 1.4.4
by: Sem [More]
Fisherman's Friend automatically equips the appropriate bait when looking at a fishing hole and changes bait when you run out of one type.
May inform you briefly if no appropriate bait is available; disabled by default.


###
This is an updated version fixing some bugs and adding language support.
The AddOn is originally authored by Zention.
###


Defaults to using the alternate baits first that you receive from fishing (chub, shad, fish roe, and minnow).
Alternate bait increases the chance to catch rare fish.
Settings menu has an option to use the regular baits first instead (worms, guts, insect parts, and crawlers).


Current languages supported: EN, DE, RU, FR
You can help with translation. Just give me all the names for fishing holes for your language and I can add them to the list.


Attention: If you substitute Fisherman 1.1 by Zention with this Patch the savedvar has to be deleted by hand. Usually it is located in:
"C:\Users\< username >\Documents\Elder Scrolls Online\live\SavedVariables\FishermansFriend.lua"
1.4.4
- update API version
- fix french again

1.4.3
- update API version

1.4.2
- downgrade calculation of bait quantity

1.4.1
- fix french

1.4.0
- change the calculation of bait quantity
- add french language support, merci Frackou

1.3.3
- add russian language support, спасибо Aspect

1.3.2
- update API version
- add message (optional) if no appropriate bait is available
- change variable names internally

1.3.1
- simplifiy menu

1.3.0
- remove unused code
- use preHookHandler instead of hooking into ZOS functions by hand

1.2.0
- bugfix: equipping bait at start now works
- bugfix: changing bait when the other type is empty now works
- language support for english and german
- improved code readability
Archived Files (7)
File Name
Version
Size
Uploader
Date
1.4.3
5kB
Sem
08/29/21 01:37 AM
1.4.2
5kB
Sem
08/28/21 08:20 AM
1.4.1
5kB
Sem
08/20/21 09:56 AM
1.3.3
4kB
Sem
08/10/21 12:06 PM
1.3.2
4kB
Sem
03/23/21 07:26 AM
1.3.1
3kB
Sem
02/21/21 06:22 AM
1.2.0
5kB
Sem
01/17/21 03:58 PM


Post A Reply Comment Options
Unread 12/02/21, 10:34 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Oh No! This is my fault.
I compressed a folder FishermansFriend_1.4.4 instead of just renaming the zip. This means everyone now has two folders of FishermansFriend, not just you.
The correct one to keep is FishermansFriend_1.4.4.
Sorry for the hastle. Gonna see what I can do about that.
Report comment to moderator  
Reply With Quote
Unread 12/01/21, 06:24 PM  
Rosalyne1

Forum posts: 0
File comments: 20
Uploads: 0
Originally Posted by Sem
Originally Posted by Rosalyne1
Mystic and Oily pools are still not automatically selecting the bait though.
Hey @Rosalyne1,

Please help me out by finding the typo!

The text in the language file has to exactly match the name of the fishing hole. For languages besides german and english as well as for oily and mystic water I rely on user translations. If you see a problem with these, please make sure the correct text is in your language file and once you confirmed it's working, please share the changes with me.

The language files are located in the addon folder (by default in):
C:\Users\< username >\Documents\Elder Scrolls Online\live\AddOns\FishermansFriend\lang\< language >.lua

You can edit lua files with windows notepad.
Sorry! I had a very busy week!

It turns out that the issue with Mystic and Oily was also due to having both addons installed. Last week when I was trying to fix the LUA error, I uninstalled the old version of the addon, but then my game didn't recognize Fisherman's Friend at all, so I reinstalled it and deleted the saved variables.

But when I read your post tonight and went looking for a typo, I found two FishermansFriend folders - one called FishermansFriend (old addon) and one called FishermansFriend-1.44 (this addon). The old version doesn't even have entries for Oily and Mystic in its LUA files, so that made me realize that the old version was active and your update was not.

So I renamed the FishermansFriend-1.44 folder by removing the -1.44 bit and now everything works exactly as intended.

TL;DR - I'm dumb and your addon works fabulously!
Report comment to moderator  
Reply With Quote
Unread 11/24/21, 02:09 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Rosalyne1
Mystic and Oily pools are still not automatically selecting the bait though.
Hey @Rosalyne1,

Please help me out by finding the typo!

The text in the language file has to exactly match the name of the fishing hole. For languages besides german and english as well as for oily and mystic water I rely on user translations. If you see a problem with these, please make sure the correct text is in your language file and once you confirmed it's working, please share the changes with me.

The language files are located in the addon folder (by default in):
C:\Users\< username >\Documents\Elder Scrolls Online\live\AddOns\FishermansFriend\lang\< language >.lua

You can edit lua files with windows notepad.
Last edited by Sem : 11/24/21 at 02:28 AM.
Report comment to moderator  
Reply With Quote
Unread 11/24/21, 02:02 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by EnigmaniteZ
warning for people mistakenly using this + the 'update' mod, but the saved vars use a different format for a variable between the two. not sure if this addon changed the format it uses, or if it's just the other addon doin it, but if you see the following error remove the savedvars for the addon and keep only ONE of the addons:
Code:
2021-11-22T17:42:46.726-08:00 |cff0000Lua Error: user:/AddOns/FishermansFriend/FishermansFriend.lua:165: attempt to index a boolean value
Thank you for bringing this to my attention. Indeed using both the original addon and this update will give this error. This addon is a direct substitution to the original and using the original savedvar was intended.
Thats why it's listed as a patch in the original mod.

Anyway, since I made changes to the savedvars to keep one more entry, I deleted the old savedvar in a specific update once. However, if I'd delete the savedvar every update you'd have to reset your preferences every update.

So please do this workaround if you currently switch from the original to this update. I will post the workaround on the main page soonish. I might also consider renaming the savedvar, since there is a difference to the original.
Last edited by Sem : 11/24/21 at 02:13 AM.
Report comment to moderator  
Reply With Quote
Unread 11/23/21, 04:16 PM  
Rosalyne1

Forum posts: 0
File comments: 20
Uploads: 0
Originally Posted by EnigmaniteZ
warning for people mistakenly using this + the 'update' mod, but the saved vars use a different format for a variable between the two. not sure if this addon changed the format it uses, or if it's just the other addon doin it, but if you see the following error remove the savedvars for the addon and keep only ONE of the addons:
Code:
2021-11-22T17:42:46.726-08:00 |cff0000Lua Error: user:/AddOns/FishermansFriend/FishermansFriend.lua:165: attempt to index a boolean value
This is the same error I'm getting and I apparently do have the old version of the addon installed for some reason. Going to test this fix out after work!

EDIT: This did fix the LUA error I reported! Deleted the saved variables for the "old" version of the addon and fishing in The Reach works properly again. Mystic and Oily pools are still not automatically selecting the bait though.
Last edited by Rosalyne1 : 11/23/21 at 06:50 PM.
Report comment to moderator  
Reply With Quote
Unread 11/22/21, 09:16 PM  
EnigmaniteZ

Forum posts: 0
File comments: 64
Uploads: 0
warning for people mistakenly using this + the 'update' mod, but the saved vars use a different format for a variable between the two. not sure if this addon changed the format it uses, or if it's just the other addon doin it, but if you see the following error remove the savedvars for the addon and keep only ONE of the addons:
Code:
2021-11-22T17:42:46.726-08:00 |cff0000Lua Error: user:/AddOns/FishermansFriend/FishermansFriend.lua:165: attempt to index a boolean value
Report comment to moderator  
Reply With Quote
Unread 11/22/21, 05:28 PM  
Rosalyne1

Forum posts: 0
File comments: 20
Uploads: 0
So I was able to reproduce in Blackwood (Lake Water), The Reach (River) and Shadowfen (River). English game client, I believe I have the option enabled to use rare bait first (screenshot below shows why I say I believe).

LUA error in Blackwood: https://i.imgur.com/JtU1eJr.png
LUA error in Shadowfen: https://i.imgur.com/yxmUenP.jpg?1
Settings menu is not correctly loading: https://i.imgur.com/sNy7dpb.png
Mystic Pools act as if the addon is disabled: https://i.imgur.com/zFEmFoO.jpg
Oily Pools also act like addon is disabled: https://i.imgur.com/VK6OZM0.jpg
Report comment to moderator  
Reply With Quote
Unread 11/22/21, 01:14 PM  
Rosalyne1

Forum posts: 0
File comments: 20
Uploads: 0
Originally Posted by Sem
Originally Posted by Rosalyne1
Updated today (11/21) and first fishing hole I put my cursor on, I got an LUA error that hijacked all keyboard/gamepad control. Couldn't dismiss it, couldn't copy it and had to ctrl-alt-delete to get out of the game. It was a River spot in The Reach if that's at all helpful.
Thanks for reporting.
I don't have that dlc, can't test anything in the reach nor can I test mystic or oily water.

I can't reproduce any problem with english, german or french in stormhaven with any type of normal fishing hole (salt,lake,river,foul) with both types of bate.

What language do you play on? Did you use standard or rare bate first?
Can you try and reproduce that bug and maybe take a screenshot of the logs? Can you rule out other addons?
I play in English with rare bait first. I didn't think to screenshot before force closing (I wanted to get back in the game to loot a Thieves Trove lol) but I can definitely re-enable the addon later today and see if I can reproduce and get a screenshot. If there's anything else that would be useful to help you, I'm happy to help!
Report comment to moderator  
Reply With Quote
Unread 11/21/21, 05:20 PM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Rosalyne1
Updated today (11/21) and first fishing hole I put my cursor on, I got an LUA error that hijacked all keyboard/gamepad control. Couldn't dismiss it, couldn't copy it and had to ctrl-alt-delete to get out of the game. It was a River spot in The Reach if that's at all helpful.
Thanks for reporting.
I don't have that dlc, can't test anything in the reach nor can I test mystic or oily water.

I can't reproduce any problem with english, german or french in stormhaven with any type of normal fishing hole (salt,lake,river,foul) with both types of bate.

What language do you play on? Did you use standard or rare bate first?
Can you try and reproduce that bug and maybe take a screenshot of the logs? Can you rule out other addons?
Report comment to moderator  
Reply With Quote
Unread 11/21/21, 02:20 PM  
Rosalyne1

Forum posts: 0
File comments: 20
Uploads: 0
Updated today (11/21) and first fishing hole I put my cursor on, I got an LUA error that hijacked all keyboard/gamepad control. Couldn't dismiss it, couldn't copy it and had to ctrl-alt-delete to get out of the game. It was a River spot in The Reach if that's at all helpful.
Report comment to moderator  
Reply With Quote
Unread 08/29/21, 05:18 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Frackou
you forgot to update french strings for oily and mystic
One day I will deliver a complete, working update xD
Good thing I am not paid for this.
Report comment to moderator  
Reply With Quote
Unread 08/29/21, 04:14 AM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
Originally Posted by Sem
Originally Posted by Rosalyne1
With the newest version, it's defaulting to normal bait even with Alternative Bait turned on.
Originally Posted by Rosalyne1
I haven't fished in a while and my memory is terrible, but didn't it automatically switch to the normal bait if you ran out of alternative before?
Both problems are created by the function, votan gave me. Does not work with itemID. I don't know how it works. Gonna downgrade this again.

EDIT: I downgraded it now. Downgrade is live now.
you forgot to update french strings for oily and mystic

Code:
SafeAddString(FISHERMANSFRIEND_MYST_FISHING_HOLE, "Trou de pêche mystique",0)
SafeAddString(FISHERMANSFRIEND_OILY_FISHING_HOLE, "Trou de pêche huileux", 	0)
Last edited by Frackou : 08/29/21 at 04:14 AM.
Report comment to moderator  
Reply With Quote
Unread 08/28/21, 07:54 AM  
Sem
AddOn Author - Click to view AddOns

Forum posts: 0
File comments: 13
Uploads: 2
Originally Posted by Rosalyne1
With the newest version, it's defaulting to normal bait even with Alternative Bait turned on.
Originally Posted by Rosalyne1
I haven't fished in a while and my memory is terrible, but didn't it automatically switch to the normal bait if you ran out of alternative before?
Both problems are created by the function, votan gave me. Does not work with itemID. I don't know how it works. Gonna downgrade this again.

EDIT: I downgraded it now. Downgrade is live now.
Last edited by Sem : 08/29/21 at 01:38 AM.
Report comment to moderator  
Reply With Quote
Unread 08/21/21, 07:24 PM  
Rosalyne1

Forum posts: 0
File comments: 20
Uploads: 0
With the newest version, it's defaulting to normal bait even with Alternative Bait turned on. Turning that option off uses the Alternative Bait, but I only had 5 Shad and once those were used up, it didn't automatically switch to Insect Parts. I haven't fished in awhile and my memory is terrible, but didn't it automatically switch to the normal bait if you ran out of alternative before?
Report comment to moderator  
Reply With Quote
Unread 08/21/21, 04:33 AM  
Frackou
 
Frackou's Avatar

Forum posts: 2
File comments: 62
Uploads: 0
Originally Posted by Sem
Originally Posted by Frackou
About last version and french you have to use UTF-8 instead ANSI cause of the "é, è, ê, à" etc or they are showed as a square.
This was one of two problems with the french translation which created the bug. Since the addon compares the full string of the fishing hole you had to send me the full translated string. I added the missing words and now it works in french as well. I can't vouch for mystic and oily water since I dont have the addon.
hi here the good ones for mystic and oiled

Code:
SafeAddString(FISHERMANSFRIEND_MYST_FISHING_HOLE, "Trou de pêche mystique",0)
SafeAddString(FISHERMANSFRIEND_OILY_FISHING_HOLE, "Trou de pêche huileux", 	0)
Also for me using alternative baits option is reversed, when it is off , it uses better baits and when it is on it uses basic ones

And also ya if i turn on "bag message" it always says that i don't have baits in bag cause of eso +, i dont really care because i know why but maybe it could be for some users maybe if possible you could work on this too, idk

Nevermind it works fine now , sorry for my mistake about translation xD
Last edited by Frackou : 08/21/21 at 04:36 AM.
Report comment to moderator  
Reply With Quote
Post A Reply



Category Jump: