| Results: 8Comments by: Tiath |
| File: IsJusta Decon Carried Items List07/13/24 |
 I may have implemented this change...
Posted By: Tiath
I may have implemented this change incorrectly
No. I think you're right and I made a mistake somewhere.
Today I reinstalled 3.3.1 from scratch and only changed shouldAddItem to:
local function shouldAddItem(bagId, slotIndex)
local filters = {}
-- only need to run this onse per item
if IsItemBoPAndTradeab...
|
| File: IsJusta Decon Carried Items List07/11/24 |
|
This is the true order of the quali...
Posted By: Tiath
This is the true order of the qualityFilters. But, the order does not matter for this table.
Yes. Sorry, I agree with you: I can see that it shouldn't depend on how filterTable is ordered, because shouldAddItem is constructing its own local filters table.
But it does work if you change the filterTable order - and doesn't work...
|
| File: IsJusta Decon Carried Items List07/11/24 |
|
If you would like to test that....
Posted By: Tiath
If you would like to test that.
This version of shouldAddItem works as expected (so far), if you also change filterTable to be in order of specificity:
i.e. ornate, intricate, retraited and reconstructed are mutually exclusive so their order isn't important, but the "bigger" filters that can have members that are also in other...
|
| File: IsJusta Decon Carried Items List07/10/24 |
|
Thanks for the patch :)
I've j...
Posted By: Tiath
Thanks for the patch :)
I've just spotted something else that seems counter-intuitive with 3.3.1 (and is probably a filter precedence issue).
If you have "Set items" ON but "Can research" OFF, set items that have traits which can be researched are included in Add All.
My expectation with those filter settings is that "Can...
|
| File: IsJusta Decon Carried Items List07/09/24 |
|
The issue is likely because of this...
Posted By: Tiath
The issue is likely because of this.
if ZO_IsTableEmpty(filters) then
table.insert(filters, qualityFilters)
end
Yes, that looks like it.
I replaced shouldAddItem with your new version and it's working as expected, both with the "Ignore stolen" toggle and the stolen quality filter.
|
| File: IsJusta Decon Carried Items List07/09/24 |
|
I added those options.
I was not a...
Posted By: Tiath
I added those options.
I was not able to fully test it, however. The ability to have every deconstruct able item in every quality and in every trait and, now, stolen and not, is way beyond me.
But, I tested it for general errors and basic functionality. If anything else comes up, just let me know and I'll do what I can.
I unders...
|
| File: IsJusta Decon Carried Items List07/07/24 |
|
Generally, if you're optimising, yo...
Posted By: Tiath
Generally, if you're optimising, you want to launder stolen items before deconstructing: You get less materials and inspiration back from deconstructing items while they're still flagged as stolen.
My preference would be to add a general "Ignore stolen items" like you already have for group tradeable items.
|
| File: IsJusta Decon Carried Items List07/07/24 |
|
Can we have a filter for Stolen Items?
Posted By: Tiath
Can we have a filter that ignores stolen items from "Add All"?
I'd prefer to launder or sell them to a fence, rather than have them swept up in deconstruction.
|
AddOn Sites
© 2014 - 2022 MMOUI