--to have name and the info whether it's a player (or named mob but that's ok for migration purposes) and in group for each unitId
unitList = {                     
   [unitId] = {name,player,group}
}
--this is the important thing, you need names as key with id as value too!!!
nameIdPairs = {          
   [name] = Id
}
--data saved to each unitId
dataArray = {
   [unitId] = dataForUnit
}

--on every combat and effect event this is done, data collection into the "dataArray" is done somewhere else
function GroupDamage:UpdateUnitList(unitId, unitName, unitType)
    if unitName == "" and (unitType ~= 3 or unitType ~= 1) then return end
    if self.unitList[unitId] == nil then 
        self.unitList[unitId] = {
            ["name"] = "<placeholder>" .. unitId, 
            ["player"] = false, 
            ["group"] = false
        } 
    end
    if targetName ~= "" then
        self.unitList[unitId]["name"] = zo_strformat("<<C:1>>", unitName)
        
        --magic starts here
        --if a name contains a "^" it isn't a general mob, and in any case(?) at least unique, or unique enough to not make problems
        if unitName:match("%^")~=nil then 
            self.unitList[unitId]["player"] = true --this is bull**** because of that, but it helps filtering out general mobs in my addon (do mobs have an x after f/m too?)
            
            --so now check if you already had that name with an id before and if the id for the name changed
            if self.nameIdPairs[unitName] ~= nil and self.nameIdPairs[unitName] ~= unitId then
                --yes? you now have the old and new ID!
                self:MigrateToNewId(self.nameIdPairs[unitName], unitId) 
            end
            self.nameIdPairs[unitName] = unitId --assign new id to the name
            
        end
    
    
    end
    if unitType == 3 or unitType == 1 then
        self.unitList[unitId]["group"] = true
    end
end
 
function GroupDamage:MigrateToNewId(oldId, newId) --WIP
    d("Id for player or named mob changed!")
    d("Old name: " .. self.unitList[oldId]["name"] .. " with ID: " .. oldId)
    d("New name: " .. self.unitList[newId]["name"] .. " with ID: " .. newId)
    --copy data from one unitId to the new unitId in "dataArray", or add it if it already exists, which is highly probable with combat event...
    self.unitList[oldId] = nil   --also remove old from unitList
    self.currentFightData["units"][oldId] = nil   --and also old data in the "dataArray"
end

if unitName == "" and (unitType ~= 3 or unitType ~= 1) then return end
 
-- this doesn't do anything, its always true:
-- and (unitType ~= 3 or unitType ~= 1)

isPlayer = (unitName:find("%^.x") ~= nil)
isGrouped = IsPlayerInGroup(zo_strformat("<<1>>", unitName))

if self.unitList[unit] ~= nil then
            values["name"] = self.unitList[unit]["name"]
            values["player"] = self.unitList[unit]["player"]
            values["group"] = self.unitList[unit]["group"]
        end

function GroupDamage.onCombatEvent(_, result, isError, _, _, _, sourceName, sourceType, targetName, targetType, hitValue, _, _, _, sourceUnitId, targetUnitId, abilityId)       
    if isError then return end
    
    GroupDamage:UpdateUnitList(sourceUnitId, sourceName, sourceType)
    GroupDamage:UpdateUnitList(targetUnitId, targetName, targetType)
    
    local isHeal = result==ACTION_RESULT_HEAL or result==ACTION_RESULT_CRITICAL_HEAL or result==ACTION_RESULT_HOT_TICK or result==ACTION_RESULT_HOT_TICK_CRITICAL
    local isDamage = result==ACTION_RESULT_BLOCKED_DAMAGE or result==ACTION_RESULT_DAMAGE or result==ACTION_RESULT_CRITICAL_DAMAGE or result==ACTION_RESULT_DOT_TICK or result==ACTION_RESULT_DOT_TICK_CRITICAL or result==ACTION_RESULT_DAMAGE_SHIELDED    
    
    --only go on if it's an actual hit event
    if (not isDamage and not isHeal) or abilityId == 41467 or abilityId == 57466 or abilityId == 57468 or hitValue < 2 then return end
    local isCrit = result==ACTION_RESULT_CRITICAL_DAMAGE or result==ACTION_RESULT_CRITICAL_HEAL or result==ACTION_RESULT_DOT_TICK_CRITICAL or result==ACTION_RESULT_HOT_TICK_CRITICAL   
    local hit = {
        ["sourceId"]    = sourceUnitId,
        ["targetId"]    = targetUnitId,
        ["hitValue"]    = hitValue,
        ["abilityId"]   = abilityId,
        ["crit"]        = isCrit,
        ["heal"]        = isHeal,
        ["timeMs"]      = GetGameTimeMilliseconds()
    }
 
    GroupDamage:Proces****Event(hit)
end
 
function GroupDamage.onEffectChanged(_, _, _, _, unitTag, _, _, _, _, _, _, _, _, unitName, unitId, _)  
    if unitTag:match("group") ~= nil then 
        unitTag = 3 
    end
    GroupDamage:UpdateUnitList(unitId, unitName, unitTag)
end

local filters = {
        [self.onCombatEventDmg] = {
            ACTION_RESULT_DAMAGE,
            ACTION_RESULT_DOT_TICK,     
            ACTION_RESULT_BLOCKED_DAMAGE,
            ACTION_RESULT_DAMAGE_SHIELDED
        },
        [self.onCombatEventDmgCrit] = {
            ACTION_RESULT_CRITICAL_DAMAGE,  
            ACTION_RESULT_DOT_TICK_CRITICAL 
        },
        [self.onCombatEventHeal] = {
            ACTION_RESULT_HOT_TICK,
            ACTION_RESULT_HEAL
        },
        [self.onCombatEventHealCrit] = {
            ACTION_RESULT_CRITICAL_HEAL,
            ACTION_RESULT_HOT_TICK_CRITICAL
        }
    }
    local nsInc = 1
    for k,v in pairs(filters) do
        for i=1, #v do
            EVENT_MANAGER:RegisterForEvent(self.name..nsInc, EVENT_COMBAT_EVENT, k)
            EVENT_MANAGER:AddFilterForEvent(self.name..nsInc, EVENT_COMBAT_EVENT, REGISTER_FILTER_COMBAT_RESULT , v[i], REGISTER_FILTER_IS_ERROR, false)
            nsInc = nsInc+1
        end 
    end