View Single Post
07/22/15, 03:29 PM   #22
circonian
AddOn Author - Click to view addons
Join Date: May 2014
Posts: 613
This code is unnecessary:
Warning: Spoiler


Those columns are already hidden. If your seeing them then some other addon is messing it up:
Warning: Spoiler


Bug? Or are you only counting on me to call this function in FilterIt?
Lua Code:
  1. -- What if multiple addons call this:
  2. function libCIF:addBackpackLayoutShiftY(shiftY)
  3.     libCIF._backpackLayoutShiftY = (libCIF._backpackLayoutShiftY or 0) + shiftY
  4. end
  5. libCIF._backpackLayoutShiftY = nil
  6. libCIF:addBackpackLayoutShiftY(40) -- now its 40
  7. libCIF:addBackpackLayoutShiftY(40) -- now 80
  8. libCIF:addBackpackLayoutShiftY(40) -- now 120


Are we sure these items you left out aren't needed anywhere else?
I know that currentFilter = TradingHouseFilter is used in ShouldAddSlotToList(..) to filter out bound items...although we are breaking that by allowing the menu bar to be shown & buttons to be clicked (yes we also fixed it by adding to the additional filter to hide bound items), but are we sure its not also needed somewhere else? What about code we don't have access to?
Warning: Spoiler

This may be trivial, but by leaving those out it prevents code from knowing which btn was previously selected & returning to it. By saving the current filter, then reloading it, & then calling ZO_MenuBar_SelectDescriptor(inventory.filterBar, inventory.currentFilter) It returns the menu bar to its previously selected descriptor.

Last edited by circonian : 07/22/15 at 03:58 PM.
  Reply With Quote