Thread Tools Display Modes
04/24/24, 06:45 PM   #1
Sharlikran
 
Sharlikran's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 692
@Baertram

TTC doesn't use LibHistoire. He and I have talked about that. He specifically avoids using any automatic requests when LibHistoire is detected.

Thanks for the feedback on how you manage things.
  Reply With Quote
04/25/24, 03:11 AM   #2
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 5,187
Originally Posted by Sharlikran View Post
TTC doesn't use LibHistoire. He and I have talked about that. He specifically avoids using any automatic requests when LibHistoire is detected.

Thanks for the feedback on how you manage things.
Okay thanks for the info but it still calls the internal function RequestGuildHistoryLoop which then calls API of the guild history, even if LibHistoire is enabled, e.g.
GetNumGuildHistoryEventRanges(guildId, GUILD_HISTORY_EVENT_CATEGORY_TRADER)
then loop it and GetGuildHistoryEventRangeInfo(guildId, GUILD_HISTORY_EVENT_CATEGORY_TRADER, i)
and if any requestId is found it also calls DestroyGuildHistoryRequest later on it at several places.

I noticed that if TTC is enabled my stuff got stuck (before last updates of ESO guild history at least) and I had to reset my caches or categories several times to make it work.

Not sure if this was coincident then or not but perhaps TTC should prefer the NEW API of LibHistoire then, if Histy is loaded, to request the history data of a timerange, instead of manually doing it. Would make all more compatible I guess.
  Reply With Quote

ESOUI » AddOns » AddOn Help/Support » Guild History Issues thread


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off