FindFirstEmptySlotInBag not updating

Hey guys it's me again ;-)

I have some issues with the function FindFirstEmptySlotInBag(BAG_BACKPACK).

I want to move items from the bank into my inventory but it always just moves one item.
I dumped the values of the variables and found out that the Destination SlotID (slotId_Bag) always stays the same.
So I think that this is the issue - but unfortunately I cannot image why it is not updating because I call it in every loop of the for-loop so it should update correctly.

function LootManager.GetIngredientsFromBank()
    local name
    local item
    local slotId
    local count
    local bagId = BAG_BANK
    local slots = GetBagSize(bagId)
    local slotId_Bag
    local bag_Dest = BAG_BACKPACK
 
    for i=0, slots - 1 do
        slotId = i
        name = zo_strformat(SI_UNIT_NAME, GetItemName(bagId, slotId))
        item, count = GetItemInfo(bagId, slotId)
        slotId_Bag = FindFirstEmptySlotInBag(bag_Dest)
 
        if name == LootManager.savedVars.ingredient1 then
            LootManager.MoveItem(bagId, slotId, bag_Dest, slotId_Bag, count)
        end 
 
        if name == LootManager.savedVars.ingredient2 then   
            LootManager.MoveItem(bagId, slotId, bag_Dest, slotId_Bag, count)
        end 
        
        if name == LootManager.savedVars.ingredient3 then
            LootManager.MoveItem(bagId, slotId, bag_Dest, slotId_Bag, count)
        end 
 
    end
 
end
 
------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------
 
function LootManager.MoveItem(srcBag, srcSlot, destBag, destSlot, quantity)
    ClearCursor()
    zo_callLater(function() 
        if CallSecureProtected("PickupInventoryItem", srcBag, srcSlot, quantity) then
            CallSecureProtected("PlaceInInventory",destBag, destSlot)
        end
    end, 500)   
    ClearCursor()   
    d("Moved: " .. zo_strformat(SI_UNIT_NAME, GetItemName(srcBag, srcSlot)) .. " x " .. quantity .. " to inventory")
    d("SrcBag: " .. srcBag .. " SrcSlot: " .. srcSlot .. " DestBag: " .. destBag .. " DestSlot: " .. destSlot .. " Quantity: " .. quantity)
end

Do you see any error here?

Thanks in advance

[merlight]

That's probably by design. The items are not actually moved immediately, your commands are carried out after your handler exits.

Some time ago I wrote my own function for finding an empty slot, which allows me to start the search after the previous one:

local function findEmptySlotInBag(bagId, prevIndex, lastIndex)
    local slotIndex = prevIndex or -1
    while slotIndex < lastIndex do
        slotIndex = slotIndex + 1
        if GetItemType(bagId, slotIndex) == ITEMTYPE_NONE then
            return slotIndex
        end
    end
    return nil
end
 
-- usage
local numSlots = GetBagSize(BAG_BANK)
local emptyIndex = findEmptySlotInBag(BAG_BANK, nil, numSlots - 1)
while emptyIndex do
   -- we have an empty slot in bank
   ... put something in there
    emptyIndex = findEmptySlotInBag(BAG_BANK, emptyIndex, numSlots - 1)
end
-- bank full

Thanks for your reply.

I already thought about making my own Slotfinder but i hoped that there was some working built-in function ....

[circonian]

I'm pretty sure the keys in the slots table matches the slotIndices. So you could loop through the slots and check to see if each key exists in the table.

local inventory = PLAYER_INVENTORY.inventories[INVENTORY_BACKPACK].slots
local bagSize = GetBagSize(BAG_BACKPACK)
    
for i = 0, bagSize-1 do
   if not inventory[i] then
      -- do whatever inventory[i] is an empty slot
   end
end

Or you could make it into a function and each time you find an empty slot throw it into a table, then return the table & you'll have all of the empty slots to do whatever you want with them.

Although merlights answer is probably better for what your doing, just giving some options.

[Garkin]

This issue is because of 500ms delay in you function LootManager.MoveItems. All calls of the FindFirstEmptySlotInBag within this 500ms will return still the same slot. If you remove zo_callLater from the function, it should work correctly.

And I think it will be better if you use RequestMoveItem function instead of PickupInventoryItem and PlaceInInventory functions.

[merlight]

Originally Posted by Garkin This issue is because of 500ms delay in you function LootManager.MoveItems. All calls of the FindFirstEmptySlotInBag within this 500ms will return still the same slot. If you remove zo_callLater from the function, it should work correctly.

They might have changed it, but I don't think so. I did the same thing some time ago (the addon in question still has APIVersion 100008), and FindFirstEmptySlotInBag kept returning the same value over and over.

Similar thing happens if you handle EVENT_LOOT_UPDATED. Functions GetLootMoney/GetNumLootItems will keep returning the values applicable when the handler was called, even after you call LootMoney/LootItemById inside the handler. After the handler exits, items are actually moved, and a new event generated with updated state.

Originally Posted by Garkin And I think it will be better if you use RequestMoveItem function instead of PickupInventoryItem and PlaceInInventory functions.

Good point, this one was added recently. And has a better name - request indicates the action is not carried out immediately.