Thread Tools Display Modes
11/17/21, 06:12 PM   #1
andy.s
AddOn Author - Click to view addons
Join Date: Jul 2014
Posts: 40
Originally Posted by Baertram View Post
Nice to know. Thank you andy.s.

This one? https://github.com/esoui/esoui/blob/...ctpool.lua#L35
Seems we need to manually add "ZO_ObjectPool_DefaultResetControl" now as "resetFunction" parameter to the call of ZO_ObjectPool, or what is the change needed here to solve your bug?

I recently noticed some weird "frozen" (not removed/hiden?) lines in the merTorchbug table lines here and there which I never noticed before.
Maybe it got to do with it.

Thank you!
Yeh, it might cause small visual bugs in several addons because objects are not automatically hidden anymore. Basically, anything that can obviously (like in this example) break backward compatibility would be nice to have mentioned somewhere
  Reply With Quote
11/18/21, 05:07 AM   #2
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,579
Seeing how the ingame code still relies on resetFunction being an optional argument in many places, I feel this is more of a bug than an intended change and should be fixed in the game.

EDIT: I clarified it with Dan. The reason it was removed was because the ingame code truly does not need a reset function in some cases and in the past they would pass in function() end, which is quite awful. The new behavior is that the reset function is completely optional and if you need one you have to pass in either a custom function, ZO_ObjectPool_DefaultResetObject or ZO_ObjectPool_DefaultResetControl.

Last edited by sirinsidiator : 11/18/21 at 09:42 AM.
  Reply With Quote
11/18/21, 10:11 AM   #3
Baertram
Super Moderator
 
Baertram's Avatar
WoWInterface Super Mod
AddOn Author - Click to view addons
Join Date: Mar 2014
Posts: 5,003
Thanks andy.s, siri and ZOsDanBatson for the info!
  Reply With Quote
11/17/21, 09:02 AM   #4
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,579
The idea is not bad, but it's actually a bit tricky to do that in a reasonable way. The changeset between live and pts is huge. How would one decide what to include in such a list without just copy pasting the full list of changes? You speak of core classes, but what would that even be? Just files in the libraries folder? Even then you'd get 42 entries in the list.
I guess for now I will just add a link to the changes and let everyone figure it out for themselves. Maybe somebody has a better idea.
  Reply With Quote
10/06/21, 12:17 PM   #5
sirinsidiator
 
sirinsidiator's Avatar
AddOn Author - Click to view addons
Join Date: Apr 2014
Posts: 1,579
Originally Posted by snichols7778 View Post
is there a gps bug on pts since last update i was trying to write the guide for community level guide addon and /zgpos gps no longer seems to work unless i delete all saved variables and can only be done as soon as i login

bad argument #2 to 'string.format' (integer expected, got nil)
stack traceback:
[C]: in function 'string.format'
user:/AddOns/ZGESO/Pointer.lua:1235: in function 'fn'
|caaaaaa<Locals> checker = "gps", gps = [table:1]{offsetY = 0.7257384210825, id = 243, zoneId = 381, offsetX = 0.21938160061836, scaleX = 0.031974401324987, scaleY = 0.031974401324987}, tex = 243 </Locals>|r
/EsoUI/Ingame/SlashCommands/SlashCommands_Shared.lua:204: in function 'DoCommand'
|caaaaaa<Locals> text = "/zgpos gps", command = "/zgpos", arguments = "gps", fn = user:/AddOns/ZGESO/Pointer.lua:1229 </Locals>|r
/EsoUI/Ingame/ChatSystem/SharedChatSystem.lua:1807: in function 'SharedChatSystem:SubmitTextEntry'
|caaaaaa<Locals> self = [table:2]{minContainerWidth = 300, numUnreadMails = 26, isAgentChatActive = F, loaded = T, isMinimizingOrMaximizing = F, isMinimized = F, ignoreTextEntryChangedEvent = F, shouldMinimizeAfterEntry = F, allowMultipleContainers = F, currentChannel = 0, maxContainerWidth = 550, maxContainerHeight = 380, suppressSave = F, currentNumNotifications = 3, minContainerHeight = 170}, text = "/zgpos gps", valid = F, prefix = 47 </Locals>|r
/EsoUI/Ingame/ChatSystem/SharedChatSystem.lua:2532: in function 'ZO_ChatTextEntry_Execute'
|caaaaaa<Locals> control = ud </Locals>|r
ZO_ChatWindowTextEntryEditBox_Enter:3: in function '(main chunk)'
|caaaaaa<Locals> self = ud </Locals>|r
(tail call): ?
(tail call): ?
I don't know which addon the /zgpos command is from, but I suppose it will need an update to work with the next game version. You are advised to report the error in its comment section, as this thread is meant as a place for addon authors to share information about the next game update and not for users to report addon problems.
  Reply With Quote

ESOUI » Developer Discussions » Tutorials & Other Helpful Info » Update 32 (Version 7.2)


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off